* [PATCH, RESEND, pci, v2] pci: Delete PCI disabling informational messages
@ 2018-04-04 15:10 Desnes A. Nunes do Rosario
2018-04-10 19:36 ` Bjorn Helgaas
0 siblings, 1 reply; 4+ messages in thread
From: Desnes A. Nunes do Rosario @ 2018-04-04 15:10 UTC (permalink / raw)
To: linux-kernel, linux-pci, linuxppc-dev; +Cc: bhelgaas
The disabling informational messages on the PCI subsystem should be deleted
since they do not represent any real value for the system logs.
These messages are either not presented, or presented for all PCI devices
(e.g., powerpc now realigns all PCI devices to its page size). Thus, they
are flooding system logs and can be interpreted as a false positive for
total PCI failure on the system.
[root@system user]# dmesg | grep -i disabling
[ 0.692270] pci 0000:00:00.0: Disabling memory decoding and releasing memory resources
[ 0.692324] pci 0000:00:00.0: disabling bridge mem windows
[ 0.729134] pci 0001:00:00.0: Disabling memory decoding and releasing memory resources
[ 0.737352] pci 0001:00:00.0: disabling bridge mem windows
[ 0.776295] pci 0002:00:00.0: Disabling memory decoding and releasing memory resources
[ 0.784509] pci 0002:00:00.0: disabling bridge mem windows
... and goes on for all PCI devices on the system ...
Fixes: 38274637699 ("powerpc/powernv: Override pcibios_default_alignment() to force PCI devices to be page aligned")
Signed-off-by: Desnes A. Nunes do Rosario <desnesn@linux.vnet.ibm.com>
---
drivers/pci/pci.c | 1 -
drivers/pci/setup-res.c | 2 --
2 files changed, 3 deletions(-)
diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index 8c71d1a66cdd..1563ce1ee091 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -5505,7 +5505,6 @@ void pci_reassigndev_resource_alignment(struct pci_dev *dev)
return;
}
- pci_info(dev, "Disabling memory decoding and releasing memory resources\n");
pci_read_config_word(dev, PCI_COMMAND, &command);
command &= ~PCI_COMMAND_MEMORY;
pci_write_config_word(dev, PCI_COMMAND, command);
diff --git a/drivers/pci/setup-res.c b/drivers/pci/setup-res.c
index 369d48d6c6f1..6bd35e8e7cde 100644
--- a/drivers/pci/setup-res.c
+++ b/drivers/pci/setup-res.c
@@ -172,8 +172,6 @@ EXPORT_SYMBOL(pci_claim_resource);
void pci_disable_bridge_window(struct pci_dev *dev)
{
- pci_info(dev, "disabling bridge mem windows\n");
-
/* MMIO Base/Limit */
pci_write_config_dword(dev, PCI_MEMORY_BASE, 0x0000fff0);
--
2.14.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH, RESEND, pci, v2] pci: Delete PCI disabling informational messages
2018-04-04 15:10 [PATCH, RESEND, pci, v2] pci: Delete PCI disabling informational messages Desnes A. Nunes do Rosario
@ 2018-04-10 19:36 ` Bjorn Helgaas
2018-04-10 19:55 ` Bjorn Helgaas
0 siblings, 1 reply; 4+ messages in thread
From: Bjorn Helgaas @ 2018-04-10 19:36 UTC (permalink / raw)
To: Desnes A. Nunes do Rosario
Cc: linux-kernel, linux-pci, linuxppc-dev, bhelgaas
On Wed, Apr 04, 2018 at 12:10:35PM -0300, Desnes A. Nunes do Rosario wrote:
> The disabling informational messages on the PCI subsystem should be deleted
> since they do not represent any real value for the system logs.
>
> These messages are either not presented, or presented for all PCI devices
> (e.g., powerpc now realigns all PCI devices to its page size). Thus, they
> are flooding system logs and can be interpreted as a false positive for
> total PCI failure on the system.
>
> [root@system user]# dmesg | grep -i disabling
> [ 0.692270] pci 0000:00:00.0: Disabling memory decoding and releasing memory resources
> [ 0.692324] pci 0000:00:00.0: disabling bridge mem windows
> [ 0.729134] pci 0001:00:00.0: Disabling memory decoding and releasing memory resources
> [ 0.737352] pci 0001:00:00.0: disabling bridge mem windows
> [ 0.776295] pci 0002:00:00.0: Disabling memory decoding and releasing memory resources
> [ 0.784509] pci 0002:00:00.0: disabling bridge mem windows
> ... and goes on for all PCI devices on the system ...
>
> Fixes: 38274637699 ("powerpc/powernv: Override pcibios_default_alignment() to force PCI devices to be page aligned")
> Signed-off-by: Desnes A. Nunes do Rosario <desnesn@linux.vnet.ibm.com>
Applied to pci/resource for v4.18, thanks!
I should have gotten this in for v4.17, but I didn't; sorry about that.
> ---
> drivers/pci/pci.c | 1 -
> drivers/pci/setup-res.c | 2 --
> 2 files changed, 3 deletions(-)
>
> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> index 8c71d1a66cdd..1563ce1ee091 100644
> --- a/drivers/pci/pci.c
> +++ b/drivers/pci/pci.c
> @@ -5505,7 +5505,6 @@ void pci_reassigndev_resource_alignment(struct pci_dev *dev)
> return;
> }
>
> - pci_info(dev, "Disabling memory decoding and releasing memory resources\n");
> pci_read_config_word(dev, PCI_COMMAND, &command);
> command &= ~PCI_COMMAND_MEMORY;
> pci_write_config_word(dev, PCI_COMMAND, command);
> diff --git a/drivers/pci/setup-res.c b/drivers/pci/setup-res.c
> index 369d48d6c6f1..6bd35e8e7cde 100644
> --- a/drivers/pci/setup-res.c
> +++ b/drivers/pci/setup-res.c
> @@ -172,8 +172,6 @@ EXPORT_SYMBOL(pci_claim_resource);
>
> void pci_disable_bridge_window(struct pci_dev *dev)
> {
> - pci_info(dev, "disabling bridge mem windows\n");
> -
> /* MMIO Base/Limit */
> pci_write_config_dword(dev, PCI_MEMORY_BASE, 0x0000fff0);
>
> --
> 2.14.3
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH, RESEND, pci, v2] pci: Delete PCI disabling informational messages
2018-04-10 19:36 ` Bjorn Helgaas
@ 2018-04-10 19:55 ` Bjorn Helgaas
2018-04-10 19:58 ` Desnes A. Nunes do Rosario
0 siblings, 1 reply; 4+ messages in thread
From: Bjorn Helgaas @ 2018-04-10 19:55 UTC (permalink / raw)
To: Desnes A. Nunes do Rosario
Cc: linux-kernel, linux-pci, linuxppc-dev, bhelgaas
On Tue, Apr 10, 2018 at 02:36:31PM -0500, Bjorn Helgaas wrote:
> On Wed, Apr 04, 2018 at 12:10:35PM -0300, Desnes A. Nunes do Rosario wrote:
> > The disabling informational messages on the PCI subsystem should be deleted
> > since they do not represent any real value for the system logs.
> >
> > These messages are either not presented, or presented for all PCI devices
> > (e.g., powerpc now realigns all PCI devices to its page size). Thus, they
> > are flooding system logs and can be interpreted as a false positive for
> > total PCI failure on the system.
> >
> > [root@system user]# dmesg | grep -i disabling
> > [ 0.692270] pci 0000:00:00.0: Disabling memory decoding and releasing memory resources
> > [ 0.692324] pci 0000:00:00.0: disabling bridge mem windows
> > [ 0.729134] pci 0001:00:00.0: Disabling memory decoding and releasing memory resources
> > [ 0.737352] pci 0001:00:00.0: disabling bridge mem windows
> > [ 0.776295] pci 0002:00:00.0: Disabling memory decoding and releasing memory resources
> > [ 0.784509] pci 0002:00:00.0: disabling bridge mem windows
> > ... and goes on for all PCI devices on the system ...
> >
> > Fixes: 38274637699 ("powerpc/powernv: Override pcibios_default_alignment() to force PCI devices to be page aligned")
> > Signed-off-by: Desnes A. Nunes do Rosario <desnesn@linux.vnet.ibm.com>
>
> Applied to pci/resource for v4.18, thanks!
>
> I should have gotten this in for v4.17, but I didn't; sorry about that.
This is trivial and I'm planning to squeeze a few more things into v4.17,
so I moved this to my "for-linus" branch for v4.17.
> > ---
> > drivers/pci/pci.c | 1 -
> > drivers/pci/setup-res.c | 2 --
> > 2 files changed, 3 deletions(-)
> >
> > diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> > index 8c71d1a66cdd..1563ce1ee091 100644
> > --- a/drivers/pci/pci.c
> > +++ b/drivers/pci/pci.c
> > @@ -5505,7 +5505,6 @@ void pci_reassigndev_resource_alignment(struct pci_dev *dev)
> > return;
> > }
> >
> > - pci_info(dev, "Disabling memory decoding and releasing memory resources\n");
> > pci_read_config_word(dev, PCI_COMMAND, &command);
> > command &= ~PCI_COMMAND_MEMORY;
> > pci_write_config_word(dev, PCI_COMMAND, command);
> > diff --git a/drivers/pci/setup-res.c b/drivers/pci/setup-res.c
> > index 369d48d6c6f1..6bd35e8e7cde 100644
> > --- a/drivers/pci/setup-res.c
> > +++ b/drivers/pci/setup-res.c
> > @@ -172,8 +172,6 @@ EXPORT_SYMBOL(pci_claim_resource);
> >
> > void pci_disable_bridge_window(struct pci_dev *dev)
> > {
> > - pci_info(dev, "disabling bridge mem windows\n");
> > -
> > /* MMIO Base/Limit */
> > pci_write_config_dword(dev, PCI_MEMORY_BASE, 0x0000fff0);
> >
> > --
> > 2.14.3
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH, RESEND, pci, v2] pci: Delete PCI disabling informational messages
2018-04-10 19:55 ` Bjorn Helgaas
@ 2018-04-10 19:58 ` Desnes A. Nunes do Rosario
0 siblings, 0 replies; 4+ messages in thread
From: Desnes A. Nunes do Rosario @ 2018-04-10 19:58 UTC (permalink / raw)
To: Bjorn Helgaas; +Cc: linux-kernel, linux-pci, linuxppc-dev, bhelgaas
Bjorn,
On 04/10/2018 04:55 PM, Bjorn Helgaas wrote:
> On Tue, Apr 10, 2018 at 02:36:31PM -0500, Bjorn Helgaas wrote:
>> On Wed, Apr 04, 2018 at 12:10:35PM -0300, Desnes A. Nunes do Rosario wrote:
>>> The disabling informational messages on the PCI subsystem should be deleted
>>> since they do not represent any real value for the system logs.
>>>
>>> These messages are either not presented, or presented for all PCI devices
>>> (e.g., powerpc now realigns all PCI devices to its page size). Thus, they
>>> are flooding system logs and can be interpreted as a false positive for
>>> total PCI failure on the system.
>>>
>>> [root@system user]# dmesg | grep -i disabling
>>> [ 0.692270] pci 0000:00:00.0: Disabling memory decoding and releasing memory resources
>>> [ 0.692324] pci 0000:00:00.0: disabling bridge mem windows
>>> [ 0.729134] pci 0001:00:00.0: Disabling memory decoding and releasing memory resources
>>> [ 0.737352] pci 0001:00:00.0: disabling bridge mem windows
>>> [ 0.776295] pci 0002:00:00.0: Disabling memory decoding and releasing memory resources
>>> [ 0.784509] pci 0002:00:00.0: disabling bridge mem windows
>>> ... and goes on for all PCI devices on the system ...
>>>
>>> Fixes: 38274637699 ("powerpc/powernv: Override pcibios_default_alignment() to force PCI devices to be page aligned")
>>> Signed-off-by: Desnes A. Nunes do Rosario <desnesn@linux.vnet.ibm.com>
>>
>> Applied to pci/resource for v4.18, thanks!
>>
>> I should have gotten this in for v4.17, but I didn't; sorry about that.
>
> This is trivial and I'm planning to squeeze a few more things into v4.17,
> so I moved this to my "for-linus" branch for v4.17.
No need for apologies.
On the contrary, thank you very much for your review and branch change.
>
>>> ---
>>> drivers/pci/pci.c | 1 -
>>> drivers/pci/setup-res.c | 2 --
>>> 2 files changed, 3 deletions(-)
>>>
>>> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
>>> index 8c71d1a66cdd..1563ce1ee091 100644
>>> --- a/drivers/pci/pci.c
>>> +++ b/drivers/pci/pci.c
>>> @@ -5505,7 +5505,6 @@ void pci_reassigndev_resource_alignment(struct pci_dev *dev)
>>> return;
>>> }
>>>
>>> - pci_info(dev, "Disabling memory decoding and releasing memory resources\n");
>>> pci_read_config_word(dev, PCI_COMMAND, &command);
>>> command &= ~PCI_COMMAND_MEMORY;
>>> pci_write_config_word(dev, PCI_COMMAND, command);
>>> diff --git a/drivers/pci/setup-res.c b/drivers/pci/setup-res.c
>>> index 369d48d6c6f1..6bd35e8e7cde 100644
>>> --- a/drivers/pci/setup-res.c
>>> +++ b/drivers/pci/setup-res.c
>>> @@ -172,8 +172,6 @@ EXPORT_SYMBOL(pci_claim_resource);
>>>
>>> void pci_disable_bridge_window(struct pci_dev *dev)
>>> {
>>> - pci_info(dev, "disabling bridge mem windows\n");
>>> -
>>> /* MMIO Base/Limit */
>>> pci_write_config_dword(dev, PCI_MEMORY_BASE, 0x0000fff0);
>>>
>>> --
>>> 2.14.3
>>>
>
--
Desnes A. Nunes do Rosario
--------------------------
Linux Developer - IBM
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-04-10 19:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-04 15:10 [PATCH, RESEND, pci, v2] pci: Delete PCI disabling informational messages Desnes A. Nunes do Rosario
2018-04-10 19:36 ` Bjorn Helgaas
2018-04-10 19:55 ` Bjorn Helgaas
2018-04-10 19:58 ` Desnes A. Nunes do Rosario
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).