From: Scott Wood <oss@buserror.net>
To: Darren Stevens <darren@stevens-zone.net>, linuxppc-dev@lists.ozlabs.org
Cc: chzigotzky@xenosoft.de
Subject: Re: [PATCH 5/5] powerpc/mpc85xx: Add Cyrus P5040 device tree source
Date: Fri, 08 May 2020 15:42:25 -0500 [thread overview]
Message-ID: <d64d04f010598ada6e7ddb3af63fee2592b3ebeb.camel@buserror.net> (raw)
In-Reply-To: <20200507223025.0164b95b@Cyrus.lan>
On Thu, 2020-05-07 at 22:30 +0100, Darren Stevens wrote:
>
> +/include/ "p5040si-pre.dtsi"
> +
> +/ {
> + model = "varisys,CYRUS5040";
> + compatible = "varisys,CYRUS";
Is this board 100% compatible with the Cyrus P5020 board, down to every last
quirk, except for the SoC plugged into it? If not, they shouldn't have the
same compatible. If they are, then couldn't everything in this file but the
SoC include be moved to a dtsi shared with cyrus_p5020.dts?
> + #address-cells = <2>;
> + #size-cells = <2>;
> + interrupt-parent = <&mpic>;
> +
> + aliases{
> + ethernet0 = &enet4;
> + ethernet1 = &enet10;
> + };
Space after "aliases"
-Scott
next prev parent reply other threads:[~2020-05-08 20:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-07 21:30 [PATCH 5/5] powerpc/mpc85xx: Add Cyrus P5040 device tree source Darren Stevens
2020-05-08 20:42 ` Scott Wood [this message]
2020-05-13 22:02 ` Darren Stevens
2020-05-14 6:42 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d64d04f010598ada6e7ddb3af63fee2592b3ebeb.camel@buserror.net \
--to=oss@buserror.net \
--cc=chzigotzky@xenosoft.de \
--cc=darren@stevens-zone.net \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).