From: Marc Zyngier <marc.zyngier@arm.com>
To: Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com>,
Thomas Gleixner <tglx@linutronix.de>
Cc: monstr@monstr.eu, jason@lakedaemon.net,
linux-kernel@vger.kernel.org, michal.simek@xilinx.com,
linuxppc-dev@lists.ozlabs.org, mpe@ellerman.id.au
Subject: Re: [Patch v7 6/7] irqchip: xilinx: Try to fall back if xlnx,kind-of-intr not provided
Date: Mon, 21 Nov 2016 14:17:26 +0000 [thread overview]
Message-ID: <dc6b4246-80fa-af8a-49ad-cddb66be1a65@arm.com> (raw)
In-Reply-To: <7f07be12-fb2e-e8ad-e0e6-52c58542470a@imgtec.com>
On 21/11/16 14:05, Zubair Lutfullah Kakakhel wrote:
> Hi,
>
> On 11/18/2016 01:29 PM, Thomas Gleixner wrote:
>> On Mon, 14 Nov 2016, Zubair Lutfullah Kakakhel wrote:
>>
>>> The powerpc dts file does not have the xlnx,kind-of-intr property.
>>> Instead of erroring out, give a warning instead. And attempt to
>>> continue to probe the interrupt controller while assuming
>>> kind-of-intr is 0x0 as a fall back.
>>
>> This is broken, really. On multiplatform kernels this will try to probe the
>> chip no matter what.
>
> I'm not sure I understand why this driver will probe on multi-platform kernels
> if the compatible string isn't in the DT?
>
>>
>> Powerpc already has:
>>
>> static const struct of_device_id xilinx_intc_match[] __initconst = {
>> { .compatible = "xlnx,opb-intc-1.00.c", },
>> { .compatible = "xlnx,xps-intc-1.00.a", },
>> {}
>> };
>>
>> Unless I'm missing something important, then adding those compatible
>> strings to the driver will just keep stuff working as expected instead of
>> adding unsafe and broken heuristics.
>>
>
> The last two lines of the driver already specify the compatible strings.
>
> "
> IRQCHIP_DECLARE(xilinx_intc_xps, "xlnx,xps-intc-1.00.a", xilinx_intc_of_init);
> IRQCHIP_DECLARE(xilinx_intc_opb, "xlnx,opb-intc-1.00.c", xilinx_intc_of_init);
> "
Is PPC actually using this infrastructure? It predates the whole
IRQCHIP_DECLARE business by about a decade. You seem to have tested it
using QEMU, so I assume it "just works", but I'd feel more reassured it
you stated so...
Thanks,
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2016-11-21 14:17 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-14 12:13 [Patch v7 0/7] microblaze/PowerPC: Move irq-xilinx to irqchip Zubair Lutfullah Kakakhel
2016-11-14 12:13 ` [Patch v7 1/7] microblaze: irqchip: Move intc driver " Zubair Lutfullah Kakakhel
2016-11-15 12:22 ` Michal Simek
2016-11-14 12:13 ` [Patch v7 2/7] irqchip: xilinx: clean up print messages Zubair Lutfullah Kakakhel
2016-11-15 12:23 ` Michal Simek
2016-11-14 12:13 ` [Patch v7 3/7] irqchip: xilinx: restructure and use jump label api Zubair Lutfullah Kakakhel
2016-11-15 12:49 ` Michal Simek
2016-11-15 16:03 ` Zubair Lutfullah Kakakhel
2016-11-16 9:24 ` Michal Simek
2016-11-14 12:13 ` [Patch v7 4/7] irqchip: xilinx: Rename get_irq to xintc_get_irq Zubair Lutfullah Kakakhel
2016-11-15 12:24 ` Michal Simek
2016-11-14 12:13 ` [Patch v7 5/7] irqchip: xilinx: Add support for parent intc Zubair Lutfullah Kakakhel
2016-11-14 12:13 ` [Patch v7 6/7] irqchip: xilinx: Try to fall back if xlnx, kind-of-intr not provided Zubair Lutfullah Kakakhel
2016-11-15 12:26 ` [Patch v7 6/7] irqchip: xilinx: Try to fall back if xlnx,kind-of-intr " Michal Simek
2016-11-18 13:29 ` [Patch v7 6/7] irqchip: xilinx: Try to fall back if xlnx, kind-of-intr " Thomas Gleixner
2016-11-21 14:05 ` [Patch v7 6/7] irqchip: xilinx: Try to fall back if xlnx,kind-of-intr " Zubair Lutfullah Kakakhel
2016-11-21 14:17 ` Marc Zyngier [this message]
2016-11-21 14:36 ` Zubair Lutfullah Kakakhel
2016-11-21 15:48 ` [Patch v7 6/7] irqchip: xilinx: Try to fall back if xlnx, kind-of-intr " Thomas Gleixner
2016-11-14 12:13 ` [Patch v7 7/7] powerpc/virtex: Use generic xilinx irqchip driver Zubair Lutfullah Kakakhel
2016-11-15 12:28 ` Michal Simek
2016-11-22 10:55 ` [Patch v7 0/7] microblaze/PowerPC: Move irq-xilinx to irqchip Marc Zyngier
2016-11-22 11:10 ` Zubair Lutfullah Kakakhel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc6b4246-80fa-af8a-49ad-cddb66be1a65@arm.com \
--to=marc.zyngier@arm.com \
--cc=Zubair.Kakakhel@imgtec.com \
--cc=jason@lakedaemon.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=michal.simek@xilinx.com \
--cc=monstr@monstr.eu \
--cc=mpe@ellerman.id.au \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).