linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] powerpc/microwatt: Add litesd
@ 2022-09-29  2:25 Joel Stanley
  2022-09-30  4:27 ` Matt Johnston
  0 siblings, 1 reply; 2+ messages in thread
From: Joel Stanley @ 2022-09-29  2:25 UTC (permalink / raw)
  To: linuxppc-dev; +Cc: Jeremy Kerr, Matt Johnston

This is the register layout of the litesd peripheral for the fusesoc
based Microwatt SoC.

Signed-off-by: Joel Stanley <joel@jms.id.au>
---
 arch/powerpc/boot/dts/microwatt.dts | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/arch/powerpc/boot/dts/microwatt.dts b/arch/powerpc/boot/dts/microwatt.dts
index b69db1d275cd..0a2e82ca1c79 100644
--- a/arch/powerpc/boot/dts/microwatt.dts
+++ b/arch/powerpc/boot/dts/microwatt.dts
@@ -141,6 +141,21 @@ ethernet@8020000 {
 			litex,slot-size = <0x800>;
 			interrupts = <0x11 0x1>;
 		};
+
+		mmc@8040000 {
+			compatible = "litex,mmc";
+			reg = <0x8042800 0x800
+				0x8041000 0x800
+				0x8040800 0x800
+				0x8042000 0x800
+				0x8041800 0x800>;
+			reg-names = "phy", "core", "reader", "writer", "irq";
+			bus-width = <4>;
+			interrupts = <0x13 1>;
+			cap-sd-highspeed;
+			non-removeable;
+			status = "disabled";
+		};
 	};
 
 	chosen {
-- 
2.35.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] powerpc/microwatt: Add litesd
  2022-09-29  2:25 [PATCH] powerpc/microwatt: Add litesd Joel Stanley
@ 2022-09-30  4:27 ` Matt Johnston
  0 siblings, 0 replies; 2+ messages in thread
From: Matt Johnston @ 2022-09-30  4:27 UTC (permalink / raw)
  To: Joel Stanley, linuxppc-dev; +Cc: Jeremy Kerr

On Thu, 2022-09-29 at 11:55 +0930, Joel Stanley wrote:
> This is the register layout of the litesd peripheral for the fusesoc
> based Microwatt SoC.

The register layout looks right, but the upstream litemmc driver also now
needs the property

clocks = <&sys_clk>;

(and associated sys_clk node).

"non-removable" has a typo, though I'm not sure we want non-removable anyway?
Most devices have a SD or microSD socket, and eMMC needs other driver litemmc
changes.

Cheers,
Matt


> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
>  arch/powerpc/boot/dts/microwatt.dts | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/arch/powerpc/boot/dts/microwatt.dts b/arch/powerpc/boot/dts/microwatt.dts
> index b69db1d275cd..0a2e82ca1c79 100644
> --- a/arch/powerpc/boot/dts/microwatt.dts
> +++ b/arch/powerpc/boot/dts/microwatt.dts
> @@ -141,6 +141,21 @@ ethernet@8020000 {
>  			litex,slot-size = <0x800>;
>  			interrupts = <0x11 0x1>;
>  		};
> +
> +		mmc@8040000 {
> +			compatible = "litex,mmc";
> +			reg = <0x8042800 0x800
> +				0x8041000 0x800
> +				0x8040800 0x800
> +				0x8042000 0x800
> +				0x8041800 0x800>;
> +			reg-names = "phy", "core", "reader", "writer", "irq";
> +			bus-width = <4>;
> +			interrupts = <0x13 1>;
> +			cap-sd-highspeed;
> +			non-removeable;
> +			status = "disabled";
> +		};
>  	};
>  
>  	chosen {


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-09-30 21:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-29  2:25 [PATCH] powerpc/microwatt: Add litesd Joel Stanley
2022-09-30  4:27 ` Matt Johnston

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).