From: "Leonardo Brás" <leobras.c@gmail.com>
To: Alexey Kardashevskiy <aik@ozlabs.ru>,
Michael Ellerman <mpe@ellerman.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>, Joel Stanley <joel@jms.id.au>,
Christophe Leroy <christophe.leroy@c-s.fr>,
Nicolin Chen <nicoleotsuka@gmail.com>,
Niklas Schnelle <schnelle@linux.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 07/11] powerpc/pseries/iommu: Reorganize iommu_table_setparms*() with new helper
Date: Wed, 14 Jul 2021 16:02:00 -0300 [thread overview]
Message-ID: <ff03c08047e0cdc79471d7bc35e48fa70efc1215.camel@gmail.com> (raw)
In-Reply-To: <88e3b97e-201d-0782-0e95-8e3d2d850a38@ozlabs.ru>
On Wed, 2021-07-14 at 18:32 +1000, Alexey Kardashevskiy wrote:
>
>
> On 13/07/2021 14:47, Leonardo Brás wrote:
> > Hello Alexey,
> >
> > On Fri, 2021-06-18 at 19:26 -0300, Leonardo Brás wrote:
> > > >
> > > > > + unsigned long liobn,
> > > > > unsigned long win_addr,
> > > > > + unsigned long
> > > > > window_size,
> > > > > unsigned long page_shift,
> > > > > + unsigned long base,
> > > > > struct
> > > > > iommu_table_ops *table_ops)
> > > >
> > > >
> > > > iommu_table_setparms() rather than passing 0 around.
> > > >
> > > > The same comment about "liobn" - set it in
> > > > iommu_table_setparms_lpar().
> > > > The reviewer will see what field atters in what situation imho.
> > > >
> > >
> > > The idea here was to keep all tbl parameters setting in
> > > _iommu_table_setparms (or iommu_table_setparms_common).
> > >
> > > I understand the idea that each one of those is optional in the
> > > other
> > > case, but should we keep whatever value is present in the other
> > > variable (not zeroing the other variable), or do someting like:
> > >
> > > tbl->it_index = 0;
> > > tbl->it_base = basep;
> > > (in iommu_table_setparms)
> > >
> > > tbl->it_index = liobn;
> > > tbl->it_base = 0;
> > > (in iommu_table_setparms_lpar)
> > >
> >
> > This one is supposed to be a question, but I missed the question
> > mark.
> > Sorry about that.
>
> Ah ok :)
>
> > I would like to get your opinion in this :)
>
> Besides making the "base" parameter a pointer, I really do not have
> strong preference, just make it not hurting eyes of a reader, that's
> all :)
Ok, done :)
> imho in general, rather than answering 5 weeks later, it is more
> productive to address whatever comments were made, add comments (in
> the
> code or commit logs) why you are sticking to your initial approach,
> rebase and repost the whole thing. Thanks,
Thanks for the tip, and for the reviewing :)
Best regards,
Leonardo Bras
next prev parent reply other threads:[~2021-07-14 19:02 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-30 16:31 [PATCH v4 00/11] DDW + Indirect Mapping Leonardo Bras
2021-04-30 16:31 ` [PATCH v4 01/11] powerpc/pseries/iommu: Replace hard-coded page shift Leonardo Bras
2021-04-30 16:31 ` [PATCH v4 02/11] powerpc/kernel/iommu: Add new iommu_table_in_use() helper Leonardo Bras
2021-05-10 7:34 ` Alexey Kardashevskiy
2021-04-30 16:31 ` [PATCH v4 03/11] powerpc/pseries/iommu: Add iommu_pseries_alloc_table() helper Leonardo Bras
2021-04-30 16:31 ` [PATCH v4 04/11] powerpc/pseries/iommu: Add ddw_list_new_entry() helper Leonardo Bras
2021-04-30 16:31 ` [PATCH v4 05/11] powerpc/pseries/iommu: Allow DDW windows starting at 0x00 Leonardo Bras
2021-04-30 16:31 ` [PATCH v4 06/11] powerpc/pseries/iommu: Add ddw_property_create() and refactor enable_ddw() Leonardo Bras
2021-05-10 7:34 ` Alexey Kardashevskiy
2021-04-30 16:31 ` [PATCH v4 07/11] powerpc/pseries/iommu: Reorganize iommu_table_setparms*() with new helper Leonardo Bras
2021-05-10 7:34 ` Alexey Kardashevskiy
2021-06-18 22:26 ` Leonardo Brás
2021-07-13 4:47 ` Leonardo Brás
2021-07-14 8:32 ` Alexey Kardashevskiy
2021-07-14 19:02 ` Leonardo Brás [this message]
2021-04-30 16:31 ` [PATCH v4 08/11] powerpc/pseries/iommu: Update remove_dma_window() to accept property name Leonardo Bras
2021-05-11 7:57 ` Alexey Kardashevskiy
2021-04-30 16:31 ` [PATCH v4 09/11] powerpc/pseries/iommu: Find existing DDW with given " Leonardo Bras
2021-05-11 7:57 ` Alexey Kardashevskiy
2021-04-30 16:31 ` [PATCH v4 10/11] powerpc/pseries/iommu: Make use of DDW for indirect mapping Leonardo Bras
2021-05-11 7:57 ` Alexey Kardashevskiy
2021-07-13 4:36 ` Leonardo Brás
2021-07-14 8:38 ` Alexey Kardashevskiy
2021-07-14 19:25 ` Leonardo Brás
2021-04-30 16:31 ` [PATCH v4 11/11] powerpc/pseries/iommu: Rename "direct window" to "dma window" Leonardo Bras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff03c08047e0cdc79471d7bc35e48fa70efc1215.camel@gmail.com \
--to=leobras.c@gmail.com \
--cc=aik@ozlabs.ru \
--cc=benh@kernel.crashing.org \
--cc=christophe.leroy@c-s.fr \
--cc=joel@jms.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=nicoleotsuka@gmail.com \
--cc=paulus@samba.org \
--cc=schnelle@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).