[PATCH 41/87] sound: ppc: remove memset after dma_alloc_coherent

[PATCH 41/87] sound: ppc: remove memset after dma_alloc_coherent

[Fuqian Huang]

In commit af7ddd8a627c
("Merge tag 'dma-mapping-4.21' of git://git.infradead.org/users/hch/dma-mapping"),
dma_alloc_coherent has already zeroed the memory.
So memset is not needed.

Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
---
 sound/ppc/pmac.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/sound/ppc/pmac.c b/sound/ppc/pmac.c
index 1b11e53f6a62..1ab12f4f8631 100644
--- a/sound/ppc/pmac.c
+++ b/sound/ppc/pmac.c
@@ -56,7 +56,6 @@ static int snd_pmac_dbdma_alloc(struct snd_pmac *chip, struct pmac_dbdma *rec, i
 	if (rec->space == NULL)
 		return -ENOMEM;
 	rec->size = size;
-	memset(rec->space, 0, rsize);
 	rec->cmds = (void __iomem *)DBDMA_ALIGN(rec->space);
 	rec->addr = rec->dma_base + (unsigned long)((char *)rec->cmds - (char *)rec->space);
 
-- 
2.11.0

Re: [PATCH 41/87] sound: ppc: remove memset after dma_alloc_coherent

[Takashi Iwai]

On Thu, 27 Jun 2019 19:40:17 +0200,
Fuqian Huang wrote:
> 
> In commit af7ddd8a627c
> ("Merge tag 'dma-mapping-4.21' of git://git.infradead.org/users/hch/dma-mapping"),
> dma_alloc_coherent has already zeroed the memory.
> So memset is not needed.
> 
> Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>

Applied, thanks.


Takashi

Re: [PATCH 41/87] sound: ppc: remove memset after dma_alloc_coherent

[Christophe Leroy]

Le 28/06/2019 à 10:48, Takashi Iwai a écrit :
> On Thu, 27 Jun 2019 19:40:17 +0200,
> Fuqian Huang wrote:
>>
>> In commit af7ddd8a627c
>> ("Merge tag 'dma-mapping-4.21' of git://git.infradead.org/users/hch/dma-mapping"),
>> dma_alloc_coherent has already zeroed the memory.
>> So memset is not needed.
>>
>> Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
> 
> Applied, thanks.
> 

Euh ... looks like a v2 of this series was sent out.

Christophe

Re: [PATCH 41/87] sound: ppc: remove memset after dma_alloc_coherent

[Takashi Iwai]

On Fri, 28 Jun 2019 10:53:14 +0200,
Christophe Leroy wrote:
> 
> 
> 
> Le 28/06/2019 à 10:48, Takashi Iwai a écrit :
> > On Thu, 27 Jun 2019 19:40:17 +0200,
> > Fuqian Huang wrote:
> >>
> >> In commit af7ddd8a627c
> >> ("Merge tag 'dma-mapping-4.21' of git://git.infradead.org/users/hch/dma-mapping"),
> >> dma_alloc_coherent has already zeroed the memory.
> >> So memset is not needed.
> >>
> >> Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
> >
> > Applied, thanks.
> >
> 
> Euh ... looks like a v2 of this series was sent out.

OK, then I take back.  Luckily, the tree wasn't pushed out yet.
Thanks for the quick notice.


Takashi

Re: [PATCH 41/87] sound: ppc: remove memset after dma_alloc_coherent

[Takashi Iwai]

On Fri, 28 Jun 2019 10:54:34 +0200,
Takashi Iwai wrote:
> 
> On Fri, 28 Jun 2019 10:53:14 +0200,
> Christophe Leroy wrote:
> > 
> > 
> > 
> > Le 28/06/2019 à 10:48, Takashi Iwai a écrit :
> > > On Thu, 27 Jun 2019 19:40:17 +0200,
> > > Fuqian Huang wrote:
> > >>
> > >> In commit af7ddd8a627c
> > >> ("Merge tag 'dma-mapping-4.21' of git://git.infradead.org/users/hch/dma-mapping"),
> > >> dma_alloc_coherent has already zeroed the memory.
> > >> So memset is not needed.
> > >>
> > >> Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
> > >
> > > Applied, thanks.
> > >
> > 
> > Euh ... looks like a v2 of this series was sent out.
> 
> OK, then I take back.  Luckily, the tree wasn't pushed out yet.
> Thanks for the quick notice.

... and this turned out to be because of our mail server change.
Now I'm going to review & take v2 patches.


Takashi