archive mirror
 help / color / mirror / Atom feed
From: "chengjian (D)" <>
To: <>, <>
Cc: <>, <>,
	<>, <>,
	<>, <>
Subject: Re: [PATCH] module: make module symbols visible after init
Date: Thu, 4 Jun 2020 20:55:46 +0800	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Hi, Petr, Jessica and Miroslav

Thank you for your reply

On 2020/6/4 16:57, Petr Mladek wrote:
> On Wed 2020-06-03 14:12:00, Cheng Jian wrote:
> It is really handful that module symbols can be found already when
> the module is MODULE_STATE_COMING state. It is used by livepatching,
> ftrace, and maybe some other subsystems.

Yes, you are right, I missed this before.

There are many scenes that lookup the symbols of module when the module is


in livepatch:


-=> klp_write_object_relocations

-=> klp_resolve_symbols

-=> module_kallsyms_on_each_symbol

My patch is incorrect.

> The problem is that nobody is allowed to use (call) module symbols
> before mod->init() is called and the module is moved to
> By other words. Any code that calls module symbols before the module
> is fully initialized is buggy. The caller should get fixed,
> not the kallsyms side.
> Have you seen such a problem in the real life, please?
> Best Regards,
> Petr
> .

     Thank you very much.

         -- Cheng Jian.

      parent reply	other threads:[~2020-06-04 12:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-03 14:12 [PATCH] module: make module symbols visible after init Cheng Jian
2020-06-03 17:00 ` Miroslav Benes
2020-06-04  9:49   ` Jessica Yu
2020-06-04  8:57 ` Petr Mladek
2020-06-04 12:55 ` chengjian (D) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).