From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Samuel Zou <zou_wei@huawei.com>
Cc: jikos@kernel.org, mbenes@suse.cz, pmladek@suse.com,
joe.lawrence@redhat.com, live-patching@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] livepatch: Make klp_apply_object_relocs static
Date: Fri, 8 May 2020 10:53:35 -0500 [thread overview]
Message-ID: <20200508155335.jyfo4rhdvbyoq5kl@treble> (raw)
In-Reply-To: <1588939594-58255-1-git-send-email-zou_wei@huawei.com>
On Fri, May 08, 2020 at 08:06:34PM +0800, Samuel Zou wrote:
> Fix the following sparse warning:
>
> kernel/livepatch/core.c:748:5: warning: symbol 'klp_apply_object_relocs'
> was not declared. Should it be static?
Yes, it should :-)
So instead of the question, the patch description should probably state
that it should be static because its only caller is in the file.
With that change:
Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>
--
Josh
next prev parent reply other threads:[~2020-05-08 15:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-08 12:06 [PATCH -next] livepatch: Make klp_apply_object_relocs static Samuel Zou
2020-05-08 14:34 ` Kamalesh Babulal
2020-05-08 15:53 ` Josh Poimboeuf [this message]
2020-05-08 15:55 ` Josh Poimboeuf
2020-05-09 0:38 ` Samuel Zou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200508155335.jyfo4rhdvbyoq5kl@treble \
--to=jpoimboe@redhat.com \
--cc=jikos@kernel.org \
--cc=joe.lawrence@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=pmladek@suse.com \
--cc=zou_wei@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).