live-patching.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Samuel Zou <zou_wei@huawei.com>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: <jikos@kernel.org>, <mbenes@suse.cz>, <pmladek@suse.com>,
	<joe.lawrence@redhat.com>, <live-patching@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] livepatch: Make klp_apply_object_relocs static
Date: Sat, 9 May 2020 08:38:39 +0800	[thread overview]
Message-ID: <b06688df-787e-4b60-6707-cf26426627d1@huawei.com> (raw)
In-Reply-To: <20200508155511.462d6pnbebcryi2j@treble>

Hi Josh,

Thanks for your review and reply.

Yes, I just copied and pasted the warning message, so I brought a 
question mark.

I will modify the description and add the fixes tag which introduced the 
issue, then will send the v2 soon.

On 2020/5/8 23:55, Josh Poimboeuf wrote:
> On Fri, May 08, 2020 at 10:53:41AM -0500, Josh Poimboeuf wrote:
>> On Fri, May 08, 2020 at 08:06:34PM +0800, Samuel Zou wrote:
>>> Fix the following sparse warning:
>>>
>>> kernel/livepatch/core.c:748:5: warning: symbol 'klp_apply_object_relocs'
>>> was not declared. Should it be static?
>>
>> Yes, it should :-)
>>
>> So instead of the question, the patch description should probably state
>> that it should be static because its only caller is in the file.
> 
> ... and it probably should also have a Fixes tag which references the
> commit which introduced this issue.
> 
>> With that change:
>>
>> Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>
> 


      reply	other threads:[~2020-05-09  0:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-08 12:06 [PATCH -next] livepatch: Make klp_apply_object_relocs static Samuel Zou
2020-05-08 14:34 ` Kamalesh Babulal
2020-05-08 15:53 ` Josh Poimboeuf
2020-05-08 15:55   ` Josh Poimboeuf
2020-05-09  0:38     ` Samuel Zou [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b06688df-787e-4b60-6707-cf26426627d1@huawei.com \
    --to=zou_wei@huawei.com \
    --cc=jikos@kernel.org \
    --cc=joe.lawrence@redhat.com \
    --cc=jpoimboe@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=live-patching@vger.kernel.org \
    --cc=mbenes@suse.cz \
    --cc=pmladek@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).