From: Miroslav Benes <mbenes@suse.cz>
To: Yannick Cote <ycote@redhat.com>
Cc: live-patching@vger.kernel.org, linux-kselftest@vger.kernel.org,
joe.lawrence@redhat.com
Subject: Re: [PATCH 3/4] selftests/livepatch: more verification in test-klp-shadow-vars
Date: Mon, 1 Jun 2020 13:39:35 +0200 (CEST) [thread overview]
Message-ID: <alpine.LSU.2.21.2006011337560.2043@pobox.suse.cz> (raw)
In-Reply-To: <20200528134849.7890-4-ycote@redhat.com>
Noticed one more thing nevertheless...
> + /* pass 6: free all the <objs[*], SV_ID2> svar pairs too. */
> + shadow_free_all(SV_ID2, NULL); /* 'int' pairs */
> + for (i = 0; i < NUM_OBJS; i++) {
> + sv = shadow_get(&objs[i], SV_ID2);
> + if (!sv)
> + pr_info(" shadow_get() got expected NULL result\n");
> + }
I think that shadow_get() should be removed from the message to make it
consistent with the rest.
Miroslav
next prev parent reply other threads:[~2020-06-01 11:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 13:48 [PATCH 0/4] selftests/livepatch: rework of test-klp-{callbacks,shadow_vars} Yannick Cote
2020-05-28 13:48 ` [PATCH 1/4] selftests/livepatch: rework test-klp-callbacks to use completion variables Yannick Cote
2020-06-02 8:16 ` Petr Mladek
2020-05-28 13:48 ` [PATCH 2/4] selftests/livepatch: rework test-klp-shadow-vars Yannick Cote
2020-06-02 9:25 ` Petr Mladek
2020-05-28 13:48 ` [PATCH 3/4] selftests/livepatch: more verification in test-klp-shadow-vars Yannick Cote
2020-06-01 11:27 ` Miroslav Benes
2020-06-01 11:39 ` Miroslav Benes [this message]
2020-06-02 12:35 ` Petr Mladek
2020-05-28 13:48 ` [PATCH 4/4] selftests/livepatch: fix mem leaks " Yannick Cote
2020-06-02 9:57 ` Petr Mladek
2020-05-29 15:12 ` [PATCH 0/4] selftests/livepatch: rework of test-klp-{callbacks,shadow_vars} Joe Lawrence
2020-06-01 11:48 ` Miroslav Benes
2020-06-02 5:01 ` Kamalesh Babulal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.21.2006011337560.2043@pobox.suse.cz \
--to=mbenes@suse.cz \
--cc=joe.lawrence@redhat.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=ycote@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).