From: Miroslav Benes <mbenes@suse.cz>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
David Laight <David.Laight@aculab.com>,
Nick Desaulniers <ndesaulniers@google.com>,
Bill Wendling <morbo@google.com>,
"x86@kernel.org" <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"dvyukov@google.com" <dvyukov@google.com>,
"seanjc@google.com" <seanjc@google.com>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"llvm@lists.linux.dev" <llvm@lists.linux.dev>,
"linux-toolchains@vger.kernel.org"
<linux-toolchains@vger.kernel.org>,
live-patching@vger.kernel.org
Subject: Re: [PATCH 20/22] x86,word-at-a-time: Remove .fixup usage
Date: Mon, 15 Nov 2021 13:59:36 +0100 (CET) [thread overview]
Message-ID: <alpine.LSU.2.21.2111151353550.29981@pobox.suse.cz> (raw)
In-Reply-To: <20211113053500.jcnx5airbn7g763a@treble>
On Fri, 12 Nov 2021, Josh Poimboeuf wrote:
> If the child schedules out, and then the parent gets patched, things can
> go off-script if the child later jumps back to the unpatched version of
> the parent, and then for example the old parent tries to call another
> patched function with a since-changed ABI.
...
> I don't know about other patch creation tooling, but I'd imagine they
> also need to know about .cold functions, unless they have that
> optimization disabled. Because the func and its .cold counterpart
> always need to be patched together.
We, at SUSE, solve the issue differently... the new patched parent would
call that another patched function with a changed ABI statically in a live
patch. So in that example, .cold child would jump back to the unpatched
parent which would then call, also, the unpatched function.
The situation would change if we ever were to have some notion of global
consistency. Then it would be really fragile, so it is worth of improving
this, I think.
Miroslav
next prev parent reply other threads:[~2021-11-15 12:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20211105171821.654356149@infradead.org>
[not found] ` <20211108164711.mr2cqdcvedin2lvx@treble>
[not found] ` <YYlshkTmf5zdvf1Q@hirez.programming.kicks-ass.net>
[not found] ` <CAKwvOdkFZ4PSN0GGmKMmoCrcp7_VVNjau_b0sNRm3MuqVi8yow@mail.gmail.com>
[not found] ` <YYov8SVHk/ZpFsUn@hirez.programming.kicks-ass.net>
[not found] ` <CAKwvOdn8yrRopXyfd299=SwZS9TAPfPj4apYgdCnzPb20knhbg@mail.gmail.com>
[not found] ` <20211109210736.GV174703@worktop.programming.kicks-ass.net>
[not found] ` <f6dbe42651e84278b44e44ed7d0ed74f@AcuMS.aculab.com>
[not found] ` <YYuogZ+2Dnjyj1ge@hirez.programming.kicks-ass.net>
[not found] ` <2734a37ebed2432291345aaa8d9fd47e@AcuMS.aculab.com>
2021-11-12 1:50 ` [PATCH 20/22] x86,word-at-a-time: Remove .fixup usage Josh Poimboeuf
2021-11-12 9:33 ` Peter Zijlstra
2021-11-13 5:35 ` Josh Poimboeuf
2021-11-15 12:36 ` Miroslav Benes
2021-11-15 13:01 ` Joe Lawrence
2021-11-15 23:40 ` Josh Poimboeuf
2021-11-16 7:25 ` Miroslav Benes
2021-11-15 12:59 ` Miroslav Benes [this message]
2021-11-16 21:27 ` Josh Poimboeuf
2021-11-18 7:15 ` Miroslav Benes
2021-11-22 17:46 ` Petr Mladek
2021-11-24 17:42 ` Josh Poimboeuf
2021-11-25 8:18 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.21.2111151353550.29981@pobox.suse.cz \
--to=mbenes@suse.cz \
--cc=David.Laight@aculab.com \
--cc=dvyukov@google.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-toolchains@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mark.rutland@arm.com \
--cc=morbo@google.com \
--cc=ndesaulniers@google.com \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=seanjc@google.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).