From: Miroslav Benes <mbenes@suse.cz>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Joe Lawrence <joe.lawrence@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
David Laight <David.Laight@aculab.com>,
Nick Desaulniers <ndesaulniers@google.com>,
Bill Wendling <morbo@google.com>,
"x86@kernel.org" <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"dvyukov@google.com" <dvyukov@google.com>,
"seanjc@google.com" <seanjc@google.com>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"llvm@lists.linux.dev" <llvm@lists.linux.dev>,
"linux-toolchains@vger.kernel.org"
<linux-toolchains@vger.kernel.org>,
live-patching@vger.kernel.org
Subject: Re: [PATCH 20/22] x86,word-at-a-time: Remove .fixup usage
Date: Tue, 16 Nov 2021 08:25:31 +0100 (CET) [thread overview]
Message-ID: <alpine.LSU.2.21.2111160823350.2250@pobox.suse.cz> (raw)
In-Reply-To: <20211115230327.m3zswzgrshotocju@treble>
On Mon, 15 Nov 2021, Josh Poimboeuf wrote:
> On Mon, Nov 15, 2021 at 08:01:13AM -0500, Joe Lawrence wrote:
> > > This reminded me... one of the things I have on my todo list for a long
> > > time is to add an option for a live patch creator to specify functions
> > > which are not contained in the live patch but their presence on stacks
> > > should be checked for. It could save some space in the final live patch
> > > when one would add functions (callers) just because the consistency
> > > requires it.
> > >
> >
> > Yea, I've used this technique once (adding a nop to a function so
> > kpatch-build would detect and include in klp_funcs[]) to make a set of
> > changes safer with respect to the consistency model. Making it simpler
> > to for the livepatch author to say, "I'm not changing foo(), but I don't
> > want it doing anything while patching a task" sounds reasonable.
> >
> > > I took as a convenience feature with a low priority and forgot about it.
> > > The problem above changes it. So should we take the opportunity and
> > > implement both in one step? I wanted to include a list of functions in
> > > on a patch level (klp_patch structure) and klp_check_stack() would just
> > > have more to check.
> > >
> >
> > As far as I read the original problem, I think it would solve for that,
> > too, so I would say go for it.
>
> Sounds good to me.
>
> Miroslav, do I understand correctly that you're volunteering to make
> this change? ;-)
Yes, you do. I am not superfast peterz, so it will take some time, but
I'll be happy to do it :).
Miroslav
next prev parent reply other threads:[~2021-11-16 7:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20211105171821.654356149@infradead.org>
[not found] ` <20211108164711.mr2cqdcvedin2lvx@treble>
[not found] ` <YYlshkTmf5zdvf1Q@hirez.programming.kicks-ass.net>
[not found] ` <CAKwvOdkFZ4PSN0GGmKMmoCrcp7_VVNjau_b0sNRm3MuqVi8yow@mail.gmail.com>
[not found] ` <YYov8SVHk/ZpFsUn@hirez.programming.kicks-ass.net>
[not found] ` <CAKwvOdn8yrRopXyfd299=SwZS9TAPfPj4apYgdCnzPb20knhbg@mail.gmail.com>
[not found] ` <20211109210736.GV174703@worktop.programming.kicks-ass.net>
[not found] ` <f6dbe42651e84278b44e44ed7d0ed74f@AcuMS.aculab.com>
[not found] ` <YYuogZ+2Dnjyj1ge@hirez.programming.kicks-ass.net>
[not found] ` <2734a37ebed2432291345aaa8d9fd47e@AcuMS.aculab.com>
2021-11-12 1:50 ` [PATCH 20/22] x86,word-at-a-time: Remove .fixup usage Josh Poimboeuf
2021-11-12 9:33 ` Peter Zijlstra
2021-11-13 5:35 ` Josh Poimboeuf
2021-11-15 12:36 ` Miroslav Benes
2021-11-15 13:01 ` Joe Lawrence
2021-11-15 23:40 ` Josh Poimboeuf
2021-11-16 7:25 ` Miroslav Benes [this message]
2021-11-15 12:59 ` Miroslav Benes
2021-11-16 21:27 ` Josh Poimboeuf
2021-11-18 7:15 ` Miroslav Benes
2021-11-22 17:46 ` Petr Mladek
2021-11-24 17:42 ` Josh Poimboeuf
2021-11-25 8:18 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.21.2111160823350.2250@pobox.suse.cz \
--to=mbenes@suse.cz \
--cc=David.Laight@aculab.com \
--cc=dvyukov@google.com \
--cc=joe.lawrence@redhat.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-toolchains@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mark.rutland@arm.com \
--cc=morbo@google.com \
--cc=ndesaulniers@google.com \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=seanjc@google.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).