Live-Patching Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] MAINTAINERS: adjust to livepatch .klp.arch removal
@ 2020-05-09  7:32 Lukas Bulwahn
  2020-05-09 13:10 ` Kamalesh Babulal
  2020-05-10 21:51 ` Jiri Kosina
  0 siblings, 2 replies; 6+ messages in thread
From: Lukas Bulwahn @ 2020-05-09  7:32 UTC (permalink / raw)
  To: Jiri Kosina, Peter Zijlstra
  Cc: Josh Poimboeuf, Jiri Kosina, Miroslav Benes, Petr Mladek,
	Joe Lawrence, live-patching, Joe Perches, kernel-janitors,
	linux-kernel, Lukas Bulwahn

Commit 1d05334d2899 ("livepatch: Remove .klp.arch") removed
arch/x86/kernel/livepatch.c, but missed to adjust the LIVE PATCHING entry
in MAINTAINERS.

Since then, ./scripts/get_maintainer.pl --self-test=patterns complains:

  warning: no file matches  F:  arch/x86/kernel/livepatch.c

So, drop that obsolete file entry in MAINTAINERS.

Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
Jiri, please take this minor non-urgent patch for livepatching/for-next.
Peter, please ack.

applies cleanly on next-20200508

 MAINTAINERS | 1 -
 1 file changed, 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 92657a132417..642f55c4b556 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -9909,7 +9909,6 @@ T:	git git://git.kernel.org/pub/scm/linux/kernel/git/livepatching/livepatching.g
 F:	Documentation/ABI/testing/sysfs-kernel-livepatch
 F:	Documentation/livepatch/
 F:	arch/x86/include/asm/livepatch.h
-F:	arch/x86/kernel/livepatch.c
 F:	include/linux/livepatch.h
 F:	kernel/livepatch/
 F:	samples/livepatch/
-- 
2.17.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] MAINTAINERS: adjust to livepatch .klp.arch removal
  2020-05-09  7:32 [PATCH] MAINTAINERS: adjust to livepatch .klp.arch removal Lukas Bulwahn
@ 2020-05-09 13:10 ` Kamalesh Babulal
  2020-05-14 21:45   ` Jiri Kosina
  2020-05-10 21:51 ` Jiri Kosina
  1 sibling, 1 reply; 6+ messages in thread
From: Kamalesh Babulal @ 2020-05-09 13:10 UTC (permalink / raw)
  To: Lukas Bulwahn, Jiri Kosina, Peter Zijlstra
  Cc: Josh Poimboeuf, Jiri Kosina, Miroslav Benes, Petr Mladek,
	Joe Lawrence, live-patching, Joe Perches, kernel-janitors,
	linux-kernel

On 5/9/20 1:02 PM, Lukas Bulwahn wrote:
> Commit 1d05334d2899 ("livepatch: Remove .klp.arch") removed
> arch/x86/kernel/livepatch.c, but missed to adjust the LIVE PATCHING entry
> in MAINTAINERS.
> 
> Since then, ./scripts/get_maintainer.pl --self-test=patterns complains:
> 
>   warning: no file matches  F:  arch/x86/kernel/livepatch.c
> 
> So, drop that obsolete file entry in MAINTAINERS.

Patch looks good to me,  you probably want to add following architecture
specific livepatching header files to the list:

arch/s390/include/asm/livepatch.h
arch/powerpc/include/asm/livepatch.h

> 
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
> Jiri, please take this minor non-urgent patch for livepatching/for-next.
> Peter, please ack.
> 
> applies cleanly on next-20200508
> 
>  MAINTAINERS | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 92657a132417..642f55c4b556 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -9909,7 +9909,6 @@ T:	git git://git.kernel.org/pub/scm/linux/kernel/git/livepatching/livepatching.g
>  F:	Documentation/ABI/testing/sysfs-kernel-livepatch
>  F:	Documentation/livepatch/
>  F:	arch/x86/include/asm/livepatch.h
> -F:	arch/x86/kernel/livepatch.c
>  F:	include/linux/livepatch.h
>  F:	kernel/livepatch/
>  F:	samples/livepatch/
> 


-- 
Kamalesh

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] MAINTAINERS: adjust to livepatch .klp.arch removal
  2020-05-09  7:32 [PATCH] MAINTAINERS: adjust to livepatch .klp.arch removal Lukas Bulwahn
  2020-05-09 13:10 ` Kamalesh Babulal
@ 2020-05-10 21:51 ` Jiri Kosina
  1 sibling, 0 replies; 6+ messages in thread
From: Jiri Kosina @ 2020-05-10 21:51 UTC (permalink / raw)
  To: Lukas Bulwahn
  Cc: Peter Zijlstra, Josh Poimboeuf, Miroslav Benes, Petr Mladek,
	Joe Lawrence, live-patching, Joe Perches, kernel-janitors,
	linux-kernel

On Sat, 9 May 2020, Lukas Bulwahn wrote:

> Commit 1d05334d2899 ("livepatch: Remove .klp.arch") removed
> arch/x86/kernel/livepatch.c, but missed to adjust the LIVE PATCHING entry
> in MAINTAINERS.
> 
> Since then, ./scripts/get_maintainer.pl --self-test=patterns complains:
> 
>   warning: no file matches  F:  arch/x86/kernel/livepatch.c
> 
> So, drop that obsolete file entry in MAINTAINERS.
> 
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>

I've added

	Fixes: 1d05334d2899 ("livepatch: Remove .klp.arch")

and applied, thanks.

-- 
Jiri Kosina
SUSE Labs


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] MAINTAINERS: adjust to livepatch .klp.arch removal
  2020-05-09 13:10 ` Kamalesh Babulal
@ 2020-05-14 21:45   ` Jiri Kosina
  2020-05-15  8:11     ` Kamalesh Babulal
  0 siblings, 1 reply; 6+ messages in thread
From: Jiri Kosina @ 2020-05-14 21:45 UTC (permalink / raw)
  To: Kamalesh Babulal
  Cc: Lukas Bulwahn, Peter Zijlstra, Josh Poimboeuf, Miroslav Benes,
	Petr Mladek, Joe Lawrence, live-patching, Joe Perches,
	kernel-janitors, linux-kernel

On Sat, 9 May 2020, Kamalesh Babulal wrote:

> > Commit 1d05334d2899 ("livepatch: Remove .klp.arch") removed
> > arch/x86/kernel/livepatch.c, but missed to adjust the LIVE PATCHING entry
> > in MAINTAINERS.
> > 
> > Since then, ./scripts/get_maintainer.pl --self-test=patterns complains:
> > 
> >   warning: no file matches  F:  arch/x86/kernel/livepatch.c
> > 
> > So, drop that obsolete file entry in MAINTAINERS.
> 
> Patch looks good to me,  you probably want to add following architecture
> specific livepatching header files to the list:
> 
> arch/s390/include/asm/livepatch.h
> arch/powerpc/include/asm/livepatch.h

Good point, thanks for spotting it Kamalesh. I've queued the patch below 
on top.



From: Jiri Kosina <jkosina@suse.cz>
Subject: [PATCH] livepatch: add arch-specific headers to MAINTAINERS

Add arch-specific livepatch.h for s390 and powerpc to MAINTAINERS
F: patterns.

Reported-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 7e0827670425..8e14444eb98d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -9854,6 +9854,8 @@ S:	Maintained
 T:	git git://git.kernel.org/pub/scm/linux/kernel/git/livepatching/livepatching.git
 F:	Documentation/ABI/testing/sysfs-kernel-livepatch
 F:	Documentation/livepatch/
+F:	arch/powerpc/include/asm/livepatch.h
+F:	arch/s390/include/asm/livepatch.h
 F:	arch/x86/include/asm/livepatch.h
 F:	include/linux/livepatch.h
 F:	kernel/livepatch/


-- 
Jiri Kosina
SUSE Labs


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] MAINTAINERS: adjust to livepatch .klp.arch removal
  2020-05-14 21:45   ` Jiri Kosina
@ 2020-05-15  8:11     ` Kamalesh Babulal
  2020-05-15  8:20       ` Jiri Kosina
  0 siblings, 1 reply; 6+ messages in thread
From: Kamalesh Babulal @ 2020-05-15  8:11 UTC (permalink / raw)
  To: Jiri Kosina
  Cc: Lukas Bulwahn, Peter Zijlstra, Josh Poimboeuf, Miroslav Benes,
	Petr Mladek, Joe Lawrence, live-patching, Joe Perches,
	kernel-janitors, linux-kernel

On 5/15/20 3:15 AM, Jiri Kosina wrote:
> On Sat, 9 May 2020, Kamalesh Babulal wrote:
> 
>>> Commit 1d05334d2899 ("livepatch: Remove .klp.arch") removed
>>> arch/x86/kernel/livepatch.c, but missed to adjust the LIVE PATCHING entry
>>> in MAINTAINERS.
>>>
>>> Since then, ./scripts/get_maintainer.pl --self-test=patterns complains:
>>>
>>>   warning: no file matches  F:  arch/x86/kernel/livepatch.c
>>>
>>> So, drop that obsolete file entry in MAINTAINERS.
>>
>> Patch looks good to me,  you probably want to add following architecture
>> specific livepatching header files to the list:
>>
>> arch/s390/include/asm/livepatch.h
>> arch/powerpc/include/asm/livepatch.h
> 
> Good point, thanks for spotting it Kamalesh. I've queued the patch below 
> on top.
> 
> 

Thanks, Jiri. I realized later, that the lib/livepatch directory also needs
to be included in the list of files maintained under livepatch. Earlier, this
week I had sent a patch to the mailing list that includes both arch
headers and lib/livepatch to the list of files, the link to the patch is:

https://lore.kernel.org/live-patching/20200511061014.308675-1-kamalesh@linux.vnet.ibm.com/


-- 
Kamalesh

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] MAINTAINERS: adjust to livepatch .klp.arch removal
  2020-05-15  8:11     ` Kamalesh Babulal
@ 2020-05-15  8:20       ` Jiri Kosina
  0 siblings, 0 replies; 6+ messages in thread
From: Jiri Kosina @ 2020-05-15  8:20 UTC (permalink / raw)
  To: Kamalesh Babulal
  Cc: Lukas Bulwahn, Peter Zijlstra, Josh Poimboeuf, Miroslav Benes,
	Petr Mladek, Joe Lawrence, live-patching, Joe Perches,
	kernel-janitors, linux-kernel

On Fri, 15 May 2020, Kamalesh Babulal wrote:

> Thanks, Jiri. I realized later, that the lib/livepatch directory also 
> needs to be included in the list of files maintained under livepatch. 
> Earlier, this week I had sent a patch to the mailing list that includes 
> both arch headers and lib/livepatch to the list of files, the link to 
> the patch is:
> 
> https://lore.kernel.org/live-patching/20200511061014.308675-1-kamalesh@linux.vnet.ibm.com/

Ah, I wasn't CCed, so it fell in between cracks, sorry. Could you please 
resend the lib/livepatch part separately? I'll apply it on top.

Thanks,

-- 
Jiri Kosina
SUSE Labs


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, back to index

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-09  7:32 [PATCH] MAINTAINERS: adjust to livepatch .klp.arch removal Lukas Bulwahn
2020-05-09 13:10 ` Kamalesh Babulal
2020-05-14 21:45   ` Jiri Kosina
2020-05-15  8:11     ` Kamalesh Babulal
2020-05-15  8:20       ` Jiri Kosina
2020-05-10 21:51 ` Jiri Kosina

Live-Patching Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/live-patching/0 live-patching/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 live-patching live-patching/ https://lore.kernel.org/live-patching \
		live-patching@vger.kernel.org
	public-inbox-index live-patching

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.live-patching


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git