WARNING in shark_write_val/usb_submit_urb

WARNING in shark_write_val/usb_submit_urb

[syzbot]

Hello,

syzbot found the following crash on:

HEAD commit:    6a3599ce usb-fuzzer: main usb gadget fuzzer driver
git tree:       https://github.com/google/kasan.git usb-fuzzer
console output: https://syzkaller.appspot.com/x/log.txt?x=138da9d0600000
kernel config:  https://syzkaller.appspot.com/x/.config?x=700ca426ab83faae
dashboard link: https://syzkaller.appspot.com/bug?extid=1cb937c125adb93fad2d
compiler:       gcc (GCC) 9.0.0 20181231 (experimental)
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=159ab958600000
C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=177bd6afa00000

IMPORTANT: if you fix the bug, please add the following tag to the commit:
Reported-by: syzbot+1cb937c125adb93fad2d@syzkaller.appspotmail.com

usb 1-1: string descriptor 0 read error: -22
usb 1-1: New USB device found, idVendor=077d, idProduct=627a, bcdDevice=  
0.01
usb 1-1: New USB device strings: Mfr=1, Product=64, SerialNumber=255
------------[ cut here ]------------
usb 1-1: BOGUS urb xfer, pipe 1 != type 3
WARNING: CPU: 1 PID: 21 at drivers/usb/core/urb.c:477  
usb_submit_urb+0x1188/0x13b0 /drivers/usb/core/urb.c:477
Kernel panic - not syncing: panic_on_warn set ...
CPU: 1 PID: 21 Comm: kworker/1:1 Not tainted 5.2.0-rc6+ #15
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS  
Google 01/01/2011
Workqueue: usb_hub_wq hub_event
Call Trace:
  __dump_stack /lib/dump_stack.c:77 [inline]
  dump_stack+0xca/0x13e /lib/dump_stack.c:113
  panic+0x292/0x6c9 /kernel/panic.c:219
  __warn.cold+0x20/0x4b /kernel/panic.c:576
  report_bug+0x262/0x2a0 /lib/bug.c:186
  fixup_bug /arch/x86/kernel/traps.c:179 [inline]
  fixup_bug /arch/x86/kernel/traps.c:174 [inline]
  do_error_trap+0x12b/0x1e0 /arch/x86/kernel/traps.c:272
  do_invalid_op+0x32/0x40 /arch/x86/kernel/traps.c:291
  invalid_op+0x14/0x20 /arch/x86/entry/entry_64.S:986
RIP: 0010:usb_submit_urb+0x1188/0x13b0 /drivers/usb/core/urb.c:477
Code: 4d 85 ed 74 2c e8 f8 d3 f4 fd 4c 89 f7 e8 a0 51 1c ff 41 89 d8 44 89  
e1 4c 89 ea 48 89 c6 48 c7 c7 00 0e f7 85 e8 83 98 ca fd <0f> 0b e9 20 f4  
ff ff e8 cc d3 f4 fd 4c 89 f2 48 b8 00 00 00 00 00
RSP: 0018:ffff8881d9efefe0 EFLAGS: 00010286
RAX: 0000000000000000 RBX: 0000000000000003 RCX: 0000000000000000
RDX: 0000000000000000 RSI: ffffffff8127ef3d RDI: ffffed103b3dfdee
RBP: ffff8881d41e5e60 R08: ffff8881d9e36000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000001
R13: ffff8881cff4cbd0 R14: ffff8881d7b33c20 R15: ffff8881d41c9b00
  usb_start_wait_urb+0x108/0x2b0 /drivers/usb/core/message.c:57
  usb_bulk_msg+0x228/0x550 /drivers/usb/core/message.c:253
  shark_write_val+0x20b/0x310 /drivers/media/radio/radio-shark.c:94
  snd_tea575x_write+0x78/0x330 /drivers/media/radio/tea575x.c:88
  snd_tea575x_hw_init+0x8d/0x170 /drivers/media/radio/tea575x.c:506
  snd_tea575x_init+0x1f/0x6b8 /drivers/media/radio/tea575x.c:521
  usb_shark_probe+0x5e1/0x770 /drivers/media/radio/radio-shark.c:353
  usb_probe_interface+0x305/0x7a0 /drivers/usb/core/driver.c:361
  really_probe+0x281/0x660 /drivers/base/dd.c:509
  driver_probe_device+0x104/0x210 /drivers/base/dd.c:670
  __device_attach_driver+0x1c2/0x220 /drivers/base/dd.c:777
  bus_for_each_drv+0x15c/0x1e0 /drivers/base/bus.c:454
  __device_attach+0x217/0x360 /drivers/base/dd.c:843
  bus_probe_device+0x1e4/0x290 /drivers/base/bus.c:514
  device_add+0xae6/0x16f0 /drivers/base/core.c:2111
  usb_set_configuration+0xdf6/0x1670 /drivers/usb/core/message.c:2023
  generic_probe+0x9d/0xd5 /drivers/usb/core/generic.c:210
  usb_probe_device+0x99/0x100 /drivers/usb/core/driver.c:266
  really_probe+0x281/0x660 /drivers/base/dd.c:509
  driver_probe_device+0x104/0x210 /drivers/base/dd.c:670
  __device_attach_driver+0x1c2/0x220 /drivers/base/dd.c:777
  bus_for_each_drv+0x15c/0x1e0 /drivers/base/bus.c:454
  __device_attach+0x217/0x360 /drivers/base/dd.c:843
  bus_probe_device+0x1e4/0x290 /drivers/base/bus.c:514
  device_add+0xae6/0x16f0 /drivers/base/core.c:2111
  usb_new_device.cold+0x6a4/0xe61 /drivers/usb/core/hub.c:2536
  hub_port_connect /drivers/usb/core/hub.c:5098 [inline]
  hub_port_connect_change /drivers/usb/core/hub.c:5213 [inline]
  port_event /drivers/usb/core/hub.c:5359 [inline]
  hub_event+0x1abd/0x3550 /drivers/usb/core/hub.c:5441
  process_one_work+0x905/0x1570 /kernel/workqueue.c:2269
  worker_thread+0x96/0xe20 /kernel/workqueue.c:2415
  kthread+0x30b/0x410 /kernel/kthread.c:255
  ret_from_fork+0x24/0x30 /arch/x86/entry/entry_64.S:352
Kernel Offset: disabled
Rebooting in 86400 seconds..


---
This bug is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller@googlegroups.com.

syzbot will keep track of this bug report. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
syzbot can test patches for this bug, for details see:
https://goo.gl/tpsmEJ#testing-patches

Re: [syzbot] [usb?] WARNING in shark_write_val/usb_submit_urb

[syzbot]

syzbot suspects this issue was fixed by commit:

commit 76e31045ba030e94e72105c01b2e98f543d175ac
Author: Alan Stern <stern@rowland.harvard.edu>
Date:   Mon Apr 10 19:40:05 2023 +0000

    media: radio-shark: Add endpoint checks

bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=17cfcfca280000
start commit:   b229b6ca5abb Merge tag 'perf-tools-fixes-for-v6.1-2022-10-..
git tree:       upstream
kernel config:  https://syzkaller.appspot.com/x/.config?x=2f98d9171d58550f
dashboard link: https://syzkaller.appspot.com/bug?extid=1cb937c125adb93fad2d
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=17070aa6880000
C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=177ab2da880000

If the result looks correct, please mark the issue as fixed by replying with:

#syz fix: media: radio-shark: Add endpoint checks

For information about bisection process see: https://goo.gl/tpsmEJ#bisection

Re: [syzbot] [usb?] WARNING in shark_write_val/usb_submit_urb

[Alan Stern]

On Fri, May 12, 2023 at 02:31:34PM -0700, syzbot wrote:
> syzbot suspects this issue was fixed by commit:
> 
> commit 76e31045ba030e94e72105c01b2e98f543d175ac
> Author: Alan Stern <stern@rowland.harvard.edu>
> Date:   Mon Apr 10 19:40:05 2023 +0000
> 
>     media: radio-shark: Add endpoint checks
> 
> bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=17cfcfca280000
> start commit:   b229b6ca5abb Merge tag 'perf-tools-fixes-for-v6.1-2022-10-..
> git tree:       upstream
> kernel config:  https://syzkaller.appspot.com/x/.config?x=2f98d9171d58550f
> dashboard link: https://syzkaller.appspot.com/bug?extid=1cb937c125adb93fad2d
> syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=17070aa6880000
> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=177ab2da880000
> 
> If the result looks correct, please mark the issue as fixed by replying with:

#syz fix: media: radio-shark: Add endpoint checks

> For information about bisection process see: https://goo.gl/tpsmEJ#bisection