* BUG: unable to handle kernel paging request in io_wq_cancel_all @ 2019-10-30 5:32 syzbot 2019-10-30 7:44 ` syzbot 0 siblings, 1 reply; 7+ messages in thread From: syzbot @ 2019-10-30 5:32 UTC (permalink / raw) To: linux-fsdevel, linux-kernel, syzkaller-bugs, viro Hello, syzbot found the following crash on: HEAD commit: c57cf383 Add linux-next specific files for 20191029 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=161e9e04e00000 kernel config: https://syzkaller.appspot.com/x/.config?x=cb86688f30db053d dashboard link: https://syzkaller.appspot.com/bug?extid=221cc24572a2fed23b6b compiler: gcc (GCC) 9.0.0 20181231 (experimental) syz repro: https://syzkaller.appspot.com/x/repro.syz?x=168671d4e00000 C reproducer: https://syzkaller.appspot.com/x/repro.c?x=140f4898e00000 IMPORTANT: if you fix the bug, please add the following tag to the commit: Reported-by: syzbot+221cc24572a2fed23b6b@syzkaller.appspotmail.com BUG: unable to handle page fault for address: fffffc0000000000 #PF: supervisor read access in kernel mode #PF: error_code(0x0000) - not-present page PGD 0 P4D 0 Oops: 0000 [#1] PREEMPT SMP KASAN CPU: 1 PID: 8856 Comm: syz-executor355 Not tainted 5.4.0-rc5-next-20191029 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 RIP: 0010:bytes_is_nonzero mm/kasan/generic.c:92 [inline] RIP: 0010:memory_is_nonzero mm/kasan/generic.c:109 [inline] RIP: 0010:memory_is_poisoned_n mm/kasan/generic.c:135 [inline] RIP: 0010:memory_is_poisoned mm/kasan/generic.c:166 [inline] RIP: 0010:check_memory_region_inline mm/kasan/generic.c:182 [inline] RIP: 0010:check_memory_region+0x123/0x1a0 mm/kasan/generic.c:192 Code: 49 89 d9 49 29 c1 e9 68 ff ff ff 5b b8 01 00 00 00 41 5c 41 5d 5d c3 4d 85 c9 74 ef 4d 01 e1 eb 09 48 83 c0 01 4c 39 c8 74 e1 <80> 38 00 74 f2 eb 8c 4d 39 c2 74 4d e8 8c e4 ff ff 31 c0 5b 41 5c RSP: 0018:ffff888090717b30 EFLAGS: 00010216 RAX: fffffc0000000000 RBX: dffffc0000000001 RCX: ffffffff81d256a8 RDX: 0000000000000001 RSI: 0000000000000008 RDI: fffffffffffffffc RBP: ffff888090717b48 R08: 1fffffffffffffff R09: dffffc0000000001 R10: dffffc0000000000 R11: 0000000000000003 R12: fffffbffffffffff R13: ffff8880a0f685c0 R14: ffff8880a4146458 R15: 0000000000000000 FS: 0000000001f6c880(0000) GS:ffff8880ae900000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: fffffc0000000000 CR3: 00000000a0083000 CR4: 00000000001406e0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 Call Trace: __kasan_check_write+0x14/0x20 mm/kasan/common.c:98 set_bit include/asm-generic/bitops-instrumented.h:28 [inline] io_wq_cancel_all+0x28/0x2a0 fs/io-wq.c:617 io_uring_flush+0x35a/0x4e0 fs/io_uring.c:3936 filp_close+0xbd/0x170 fs/open.c:1174 close_files fs/file.c:388 [inline] put_files_struct fs/file.c:416 [inline] put_files_struct+0x1d7/0x2f0 fs/file.c:413 exit_files+0x83/0xb0 fs/file.c:445 do_exit+0x8d2/0x2e60 kernel/exit.c:812 do_group_exit+0x135/0x360 kernel/exit.c:921 __do_sys_exit_group kernel/exit.c:932 [inline] __se_sys_exit_group kernel/exit.c:930 [inline] __x64_sys_exit_group+0x44/0x50 kernel/exit.c:930 do_syscall_64+0xfa/0x760 arch/x86/entry/common.c:290 entry_SYSCALL_64_after_hwframe+0x49/0xbe RIP: 0033:0x440018 Code: 00 00 be 3c 00 00 00 eb 19 66 0f 1f 84 00 00 00 00 00 48 89 d7 89 f0 0f 05 48 3d 00 f0 ff ff 77 21 f4 48 89 d7 44 89 c0 0f 05 <48> 3d 00 f0 ff ff 76 e0 f7 d8 64 41 89 01 eb d8 0f 1f 84 00 00 00 RSP: 002b:00007ffc5afbadb8 EFLAGS: 00000246 ORIG_RAX: 00000000000000e7 RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 0000000000440018 RDX: 0000000000000000 RSI: 000000000000003c RDI: 0000000000000000 RBP: 00000000004bfcf0 R08: 00000000000000e7 R09: ffffffffffffffd0 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000001 R13: 00000000006d2180 R14: 0000000000000000 R15: 0000000000000000 Modules linked in: CR2: fffffc0000000000 ---[ end trace 3dc71453331dd723 ]--- RIP: 0010:bytes_is_nonzero mm/kasan/generic.c:92 [inline] RIP: 0010:memory_is_nonzero mm/kasan/generic.c:109 [inline] RIP: 0010:memory_is_poisoned_n mm/kasan/generic.c:135 [inline] RIP: 0010:memory_is_poisoned mm/kasan/generic.c:166 [inline] RIP: 0010:check_memory_region_inline mm/kasan/generic.c:182 [inline] RIP: 0010:check_memory_region+0x123/0x1a0 mm/kasan/generic.c:192 Code: 49 89 d9 49 29 c1 e9 68 ff ff ff 5b b8 01 00 00 00 41 5c 41 5d 5d c3 4d 85 c9 74 ef 4d 01 e1 eb 09 48 83 c0 01 4c 39 c8 74 e1 <80> 38 00 74 f2 eb 8c 4d 39 c2 74 4d e8 8c e4 ff ff 31 c0 5b 41 5c RSP: 0018:ffff888090717b30 EFLAGS: 00010216 RAX: fffffc0000000000 RBX: dffffc0000000001 RCX: ffffffff81d256a8 RDX: 0000000000000001 RSI: 0000000000000008 RDI: fffffffffffffffc RBP: ffff888090717b48 R08: 1fffffffffffffff R09: dffffc0000000001 R10: dffffc0000000000 R11: 0000000000000003 R12: fffffbffffffffff R13: ffff8880a0f685c0 R14: ffff8880a4146458 R15: 0000000000000000 FS: 0000000001f6c880(0000) GS:ffff8880ae900000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: fffffc0000000000 CR3: 00000000a0083000 CR4: 00000000001406e0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 --- This bug is generated by a bot. It may contain errors. See https://goo.gl/tpsmEJ for more information about syzbot. syzbot engineers can be reached at syzkaller@googlegroups.com. syzbot will keep track of this bug report. See: https://goo.gl/tpsmEJ#status for how to communicate with syzbot. syzbot can test patches for this bug, for details see: https://goo.gl/tpsmEJ#testing-patches ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: BUG: unable to handle kernel paging request in io_wq_cancel_all 2019-10-30 5:32 BUG: unable to handle kernel paging request in io_wq_cancel_all syzbot @ 2019-10-30 7:44 ` syzbot 2019-10-30 14:41 ` Jens Axboe 0 siblings, 1 reply; 7+ messages in thread From: syzbot @ 2019-10-30 7:44 UTC (permalink / raw) To: akpm, axboe, dan.j.williams, dhowells, gregkh, hannes, joel, linux-block, linux-fsdevel, linux-kernel, mchehab+samsung, mingo, patrick.bellasi, rgb, rostedt, syzkaller-bugs, viro, yamada.masahiro syzbot has bisected this bug to: commit ef0524d3654628ead811f328af0a4a2953a8310f Author: Jens Axboe <axboe@kernel.dk> Date: Thu Oct 24 13:25:42 2019 +0000 io_uring: replace workqueue usage with io-wq bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=16acf5d0e00000 start commit: c57cf383 Add linux-next specific files for 20191029 git tree: linux-next final crash: https://syzkaller.appspot.com/x/report.txt?x=15acf5d0e00000 console output: https://syzkaller.appspot.com/x/log.txt?x=11acf5d0e00000 kernel config: https://syzkaller.appspot.com/x/.config?x=cb86688f30db053d dashboard link: https://syzkaller.appspot.com/bug?extid=221cc24572a2fed23b6b syz repro: https://syzkaller.appspot.com/x/repro.syz?x=168671d4e00000 C reproducer: https://syzkaller.appspot.com/x/repro.c?x=140f4898e00000 Reported-by: syzbot+221cc24572a2fed23b6b@syzkaller.appspotmail.com Fixes: ef0524d36546 ("io_uring: replace workqueue usage with io-wq") For information about bisection process see: https://goo.gl/tpsmEJ#bisection ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: BUG: unable to handle kernel paging request in io_wq_cancel_all 2019-10-30 7:44 ` syzbot @ 2019-10-30 14:41 ` Jens Axboe 2019-11-01 17:50 ` Dmitry Vyukov 0 siblings, 1 reply; 7+ messages in thread From: Jens Axboe @ 2019-10-30 14:41 UTC (permalink / raw) To: syzbot, akpm, dan.j.williams, dhowells, gregkh, hannes, joel, linux-block, linux-fsdevel, linux-kernel, mchehab+samsung, mingo, patrick.bellasi, rgb, rostedt, syzkaller-bugs, viro, yamada.masahiro On 10/30/19 1:44 AM, syzbot wrote: > syzbot has bisected this bug to: > > commit ef0524d3654628ead811f328af0a4a2953a8310f > Author: Jens Axboe <axboe@kernel.dk> > Date: Thu Oct 24 13:25:42 2019 +0000 > > io_uring: replace workqueue usage with io-wq > > bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=16acf5d0e00000 > start commit: c57cf383 Add linux-next specific files for 20191029 > git tree: linux-next > final crash: https://syzkaller.appspot.com/x/report.txt?x=15acf5d0e00000 > console output: https://syzkaller.appspot.com/x/log.txt?x=11acf5d0e00000 > kernel config: https://syzkaller.appspot.com/x/.config?x=cb86688f30db053d > dashboard link: https://syzkaller.appspot.com/bug?extid=221cc24572a2fed23b6b > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=168671d4e00000 > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=140f4898e00000 > > Reported-by: syzbot+221cc24572a2fed23b6b@syzkaller.appspotmail.com > Fixes: ef0524d36546 ("io_uring: replace workqueue usage with io-wq") Good catch, it's a case of NULL vs ERR_PTR() confusion. I'll fold in the below fix. diff --git a/fs/io_uring.c b/fs/io_uring.c index af1937d66aee..76d653085987 100644 --- a/fs/io_uring.c +++ b/fs/io_uring.c @@ -3534,8 +3534,9 @@ static int io_sq_offload_start(struct io_ring_ctx *ctx, /* Do QD, or 4 * CPUS, whatever is smallest */ concurrency = min(ctx->sq_entries, 4 * num_online_cpus()); ctx->io_wq = io_wq_create(concurrency, ctx->sqo_mm); - if (!ctx->io_wq) { - ret = -ENOMEM; + if (IS_ERR(ctx->io_wq)) { + ret = PTR_ERR(ctx->io_wq); + ctx->io_wq = NULL; goto err; } -- Jens Axboe ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: BUG: unable to handle kernel paging request in io_wq_cancel_all 2019-10-30 14:41 ` Jens Axboe @ 2019-11-01 17:50 ` Dmitry Vyukov 2019-11-01 17:56 ` Jens Axboe 0 siblings, 1 reply; 7+ messages in thread From: Dmitry Vyukov @ 2019-11-01 17:50 UTC (permalink / raw) To: Jens Axboe Cc: syzbot, Andrew Morton, Dan Williams, David Howells, Greg Kroah-Hartman, Johannes Weiner, Joel Fernandes, linux-block, linux-fsdevel, LKML, mchehab+samsung, Ingo Molnar, patrick.bellasi, Richard Guy Briggs, Steven Rostedt, syzkaller-bugs, Al Viro, Masahiro Yamada On Wed, Oct 30, 2019 at 3:41 PM Jens Axboe <axboe@kernel.dk> wrote: > > On 10/30/19 1:44 AM, syzbot wrote: > > syzbot has bisected this bug to: > > > > commit ef0524d3654628ead811f328af0a4a2953a8310f > > Author: Jens Axboe <axboe@kernel.dk> > > Date: Thu Oct 24 13:25:42 2019 +0000 > > > > io_uring: replace workqueue usage with io-wq > > > > bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=16acf5d0e00000 > > start commit: c57cf383 Add linux-next specific files for 20191029 > > git tree: linux-next > > final crash: https://syzkaller.appspot.com/x/report.txt?x=15acf5d0e00000 > > console output: https://syzkaller.appspot.com/x/log.txt?x=11acf5d0e00000 > > kernel config: https://syzkaller.appspot.com/x/.config?x=cb86688f30db053d > > dashboard link: https://syzkaller.appspot.com/bug?extid=221cc24572a2fed23b6b > > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=168671d4e00000 > > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=140f4898e00000 > > > > Reported-by: syzbot+221cc24572a2fed23b6b@syzkaller.appspotmail.com > > Fixes: ef0524d36546 ("io_uring: replace workqueue usage with io-wq") > > Good catch, it's a case of NULL vs ERR_PTR() confusion. I'll fold in > the below fix. Hi Jens, Please either add the syzbot tag to commit, or close manually with "#syz fix" (though requires waiting until the fixed commit is in linux-next). See https://goo.gl/tpsmEJ#rebuilt-treesamended-patches for details. Otherwise, the bug will be considered open and will waste time of humans looking at open bugs and prevent syzbot from reporting new bugs in io_uring. > diff --git a/fs/io_uring.c b/fs/io_uring.c > index af1937d66aee..76d653085987 100644 > --- a/fs/io_uring.c > +++ b/fs/io_uring.c > @@ -3534,8 +3534,9 @@ static int io_sq_offload_start(struct io_ring_ctx *ctx, > /* Do QD, or 4 * CPUS, whatever is smallest */ > concurrency = min(ctx->sq_entries, 4 * num_online_cpus()); > ctx->io_wq = io_wq_create(concurrency, ctx->sqo_mm); > - if (!ctx->io_wq) { > - ret = -ENOMEM; > + if (IS_ERR(ctx->io_wq)) { > + ret = PTR_ERR(ctx->io_wq); > + ctx->io_wq = NULL; > goto err; > } > > > -- > Jens Axboe > > -- > You received this message because you are subscribed to the Google Groups "syzkaller-bugs" group. > To unsubscribe from this group and stop receiving emails from it, send an email to syzkaller-bugs+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/syzkaller-bugs/0e2bc2bf-2a7a-73c5-03e2-9d08f89f0ffa%40kernel.dk. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: BUG: unable to handle kernel paging request in io_wq_cancel_all 2019-11-01 17:50 ` Dmitry Vyukov @ 2019-11-01 17:56 ` Jens Axboe 2019-11-01 18:03 ` Dmitry Vyukov 0 siblings, 1 reply; 7+ messages in thread From: Jens Axboe @ 2019-11-01 17:56 UTC (permalink / raw) To: Dmitry Vyukov Cc: syzbot, Andrew Morton, Dan Williams, David Howells, Greg Kroah-Hartman, Johannes Weiner, Joel Fernandes, linux-block, linux-fsdevel, LKML, mchehab+samsung, Ingo Molnar, patrick.bellasi, Richard Guy Briggs, Steven Rostedt, syzkaller-bugs, Al Viro, Masahiro Yamada On 11/1/19 11:50 AM, Dmitry Vyukov wrote: > On Wed, Oct 30, 2019 at 3:41 PM Jens Axboe <axboe@kernel.dk> wrote: >> >> On 10/30/19 1:44 AM, syzbot wrote: >>> syzbot has bisected this bug to: >>> >>> commit ef0524d3654628ead811f328af0a4a2953a8310f >>> Author: Jens Axboe <axboe@kernel.dk> >>> Date: Thu Oct 24 13:25:42 2019 +0000 >>> >>> io_uring: replace workqueue usage with io-wq >>> >>> bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=16acf5d0e00000 >>> start commit: c57cf383 Add linux-next specific files for 20191029 >>> git tree: linux-next >>> final crash: https://syzkaller.appspot.com/x/report.txt?x=15acf5d0e00000 >>> console output: https://syzkaller.appspot.com/x/log.txt?x=11acf5d0e00000 >>> kernel config: https://syzkaller.appspot.com/x/.config?x=cb86688f30db053d >>> dashboard link: https://syzkaller.appspot.com/bug?extid=221cc24572a2fed23b6b >>> syz repro: https://syzkaller.appspot.com/x/repro.syz?x=168671d4e00000 >>> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=140f4898e00000 >>> >>> Reported-by: syzbot+221cc24572a2fed23b6b@syzkaller.appspotmail.com >>> Fixes: ef0524d36546 ("io_uring: replace workqueue usage with io-wq") >> >> Good catch, it's a case of NULL vs ERR_PTR() confusion. I'll fold in >> the below fix. > > Hi Jens, > > Please either add the syzbot tag to commit, or close manually with > "#syz fix" (though requires waiting until the fixed commit is in > linux-next). > See https://goo.gl/tpsmEJ#rebuilt-treesamended-patches for details. > Otherwise, the bug will be considered open and will waste time of > humans looking at open bugs and prevent syzbot from reporting new bugs > in io_uring. It's queued up since two days ago: http://git.kernel.dk/cgit/linux-block/commit/?h=for-5.5/io_uring&id=975c99a570967dd48e917dd7853867fee3febabd and should have the right attributions, so hopefully it'll catch up eventually. -- Jens Axboe ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: BUG: unable to handle kernel paging request in io_wq_cancel_all 2019-11-01 17:56 ` Jens Axboe @ 2019-11-01 18:03 ` Dmitry Vyukov 2019-11-01 18:07 ` Jens Axboe 0 siblings, 1 reply; 7+ messages in thread From: Dmitry Vyukov @ 2019-11-01 18:03 UTC (permalink / raw) To: Jens Axboe Cc: syzbot, Andrew Morton, Dan Williams, David Howells, Greg Kroah-Hartman, Johannes Weiner, Joel Fernandes, linux-block, linux-fsdevel, LKML, mchehab+samsung, Ingo Molnar, patrick.bellasi, Richard Guy Briggs, Steven Rostedt, syzkaller-bugs, Al Viro, Masahiro Yamada On Fri, Nov 1, 2019 at 6:56 PM Jens Axboe <axboe@kernel.dk> wrote: > > On 11/1/19 11:50 AM, Dmitry Vyukov wrote: > > On Wed, Oct 30, 2019 at 3:41 PM Jens Axboe <axboe@kernel.dk> wrote: > >> > >> On 10/30/19 1:44 AM, syzbot wrote: > >>> syzbot has bisected this bug to: > >>> > >>> commit ef0524d3654628ead811f328af0a4a2953a8310f > >>> Author: Jens Axboe <axboe@kernel.dk> > >>> Date: Thu Oct 24 13:25:42 2019 +0000 > >>> > >>> io_uring: replace workqueue usage with io-wq > >>> > >>> bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=16acf5d0e00000 > >>> start commit: c57cf383 Add linux-next specific files for 20191029 > >>> git tree: linux-next > >>> final crash: https://syzkaller.appspot.com/x/report.txt?x=15acf5d0e00000 > >>> console output: https://syzkaller.appspot.com/x/log.txt?x=11acf5d0e00000 > >>> kernel config: https://syzkaller.appspot.com/x/.config?x=cb86688f30db053d > >>> dashboard link: https://syzkaller.appspot.com/bug?extid=221cc24572a2fed23b6b > >>> syz repro: https://syzkaller.appspot.com/x/repro.syz?x=168671d4e00000 > >>> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=140f4898e00000 > >>> > >>> Reported-by: syzbot+221cc24572a2fed23b6b@syzkaller.appspotmail.com > >>> Fixes: ef0524d36546 ("io_uring: replace workqueue usage with io-wq") > >> > >> Good catch, it's a case of NULL vs ERR_PTR() confusion. I'll fold in > >> the below fix. > > > > Hi Jens, > > > > Please either add the syzbot tag to commit, or close manually with > > "#syz fix" (though requires waiting until the fixed commit is in > > linux-next). > > See https://goo.gl/tpsmEJ#rebuilt-treesamended-patches for details. > > Otherwise, the bug will be considered open and will waste time of > > humans looking at open bugs and prevent syzbot from reporting new bugs > > in io_uring. > > It's queued up since two days ago: > > http://git.kernel.dk/cgit/linux-block/commit/?h=for-5.5/io_uring&id=975c99a570967dd48e917dd7853867fee3febabd > > and should have the right attributions, so hopefully it'll catch up > eventually. > > -- > Jens Axboe > Cool! Thanks! I've seen "fold in" and historically lots of developers did not add the tag during amending, so wanted to double check. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: BUG: unable to handle kernel paging request in io_wq_cancel_all 2019-11-01 18:03 ` Dmitry Vyukov @ 2019-11-01 18:07 ` Jens Axboe 0 siblings, 0 replies; 7+ messages in thread From: Jens Axboe @ 2019-11-01 18:07 UTC (permalink / raw) To: Dmitry Vyukov Cc: syzbot, Andrew Morton, Dan Williams, David Howells, Greg Kroah-Hartman, Johannes Weiner, Joel Fernandes, linux-block, linux-fsdevel, LKML, mchehab+samsung, Ingo Molnar, patrick.bellasi, Richard Guy Briggs, Steven Rostedt, syzkaller-bugs, Al Viro, Masahiro Yamada On 11/1/19 12:03 PM, Dmitry Vyukov wrote: > On Fri, Nov 1, 2019 at 6:56 PM Jens Axboe <axboe@kernel.dk> wrote: >> >> On 11/1/19 11:50 AM, Dmitry Vyukov wrote: >>> On Wed, Oct 30, 2019 at 3:41 PM Jens Axboe <axboe@kernel.dk> wrote: >>>> >>>> On 10/30/19 1:44 AM, syzbot wrote: >>>>> syzbot has bisected this bug to: >>>>> >>>>> commit ef0524d3654628ead811f328af0a4a2953a8310f >>>>> Author: Jens Axboe <axboe@kernel.dk> >>>>> Date: Thu Oct 24 13:25:42 2019 +0000 >>>>> >>>>> io_uring: replace workqueue usage with io-wq >>>>> >>>>> bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=16acf5d0e00000 >>>>> start commit: c57cf383 Add linux-next specific files for 20191029 >>>>> git tree: linux-next >>>>> final crash: https://syzkaller.appspot.com/x/report.txt?x=15acf5d0e00000 >>>>> console output: https://syzkaller.appspot.com/x/log.txt?x=11acf5d0e00000 >>>>> kernel config: https://syzkaller.appspot.com/x/.config?x=cb86688f30db053d >>>>> dashboard link: https://syzkaller.appspot.com/bug?extid=221cc24572a2fed23b6b >>>>> syz repro: https://syzkaller.appspot.com/x/repro.syz?x=168671d4e00000 >>>>> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=140f4898e00000 >>>>> >>>>> Reported-by: syzbot+221cc24572a2fed23b6b@syzkaller.appspotmail.com >>>>> Fixes: ef0524d36546 ("io_uring: replace workqueue usage with io-wq") >>>> >>>> Good catch, it's a case of NULL vs ERR_PTR() confusion. I'll fold in >>>> the below fix. >>> >>> Hi Jens, >>> >>> Please either add the syzbot tag to commit, or close manually with >>> "#syz fix" (though requires waiting until the fixed commit is in >>> linux-next). >>> See https://goo.gl/tpsmEJ#rebuilt-treesamended-patches for details. >>> Otherwise, the bug will be considered open and will waste time of >>> humans looking at open bugs and prevent syzbot from reporting new bugs >>> in io_uring. >> >> It's queued up since two days ago: >> >> http://git.kernel.dk/cgit/linux-block/commit/?h=for-5.5/io_uring&id=975c99a570967dd48e917dd7853867fee3febabd >> >> and should have the right attributions, so hopefully it'll catch up >> eventually. >> >> -- >> Jens Axboe >> > > Cool! Thanks! > I've seen "fold in" and historically lots of developers did not add > the tag during amending, so wanted to double check. I'm often guilty of that, I think, but for this one I just kept it separate since I didn't want to rebase things at this point. So I do appreciate the reminder, I'm sure it'll be pertinent in many other cases... -- Jens Axboe ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-11-01 18:07 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-10-30 5:32 BUG: unable to handle kernel paging request in io_wq_cancel_all syzbot 2019-10-30 7:44 ` syzbot 2019-10-30 14:41 ` Jens Axboe 2019-11-01 17:50 ` Dmitry Vyukov 2019-11-01 17:56 ` Jens Axboe 2019-11-01 18:03 ` Dmitry Vyukov 2019-11-01 18:07 ` Jens Axboe
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).