* [PATCH] scsi: ufs: ufshcd: Drop loglevel of WriteBoost message
@ 2022-07-09 0:00 ` Bjorn Andersson
2022-07-09 10:04 ` Alim Akhtar
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Bjorn Andersson @ 2022-07-09 0:00 UTC (permalink / raw)
To: Alim Akhtar, Avri Altman, Bart Van Assche, James E.J. Bottomley,
Martin K. Petersen
Cc: Bean Huo, Adrian Hunter, Yue Hu, linux-scsi, linux-kernel
Commit '3b5f3c0d0548 ("scsi: ufs: core: Tidy up WB configuration code")'
changed the log level of the write boost enable/disable notification
from debug to info, this results in a lot of noise in the kernel log
during normal operation.
Drop it back to debug level to avoid this.
Fixes: 3b5f3c0d0548 ("scsi: ufs: core: Tidy up WB configuration code")
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
drivers/ufs/core/ufshcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
index 22042ee3af14..be65d5bf123e 100644
--- a/drivers/ufs/core/ufshcd.c
+++ b/drivers/ufs/core/ufshcd.c
@@ -5747,7 +5747,7 @@ int ufshcd_wb_toggle(struct ufs_hba *hba, bool enable)
}
hba->dev_info.wb_enabled = enable;
- dev_info(hba->dev, "%s Write Booster %s\n",
+ dev_dbg(hba->dev, "%s Write Booster %s\n",
__func__, enable ? "enabled" : "disabled");
return ret;
--
2.35.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [PATCH] scsi: ufs: ufshcd: Drop loglevel of WriteBoost message
2022-07-09 0:00 ` [PATCH] scsi: ufs: ufshcd: Drop loglevel of WriteBoost message Bjorn Andersson
@ 2022-07-09 10:04 ` Alim Akhtar
2022-07-10 21:04 ` Bean Huo
2022-07-14 4:22 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Alim Akhtar @ 2022-07-09 10:04 UTC (permalink / raw)
To: 'Bjorn Andersson', 'Avri Altman',
'Bart Van Assche', 'James E.J. Bottomley',
'Martin K. Petersen'
Cc: 'Bean Huo', 'Adrian Hunter', 'Yue Hu',
linux-scsi, linux-kernel
>-----Original Message-----
>From: Bjorn Andersson [mailto:bjorn.andersson@linaro.org]
>Sent: Saturday, July 9, 2022 5:30 AM
>To: Alim Akhtar <alim.akhtar@samsung.com>; Avri Altman
><avri.altman@wdc.com>; Bart Van Assche <bvanassche@acm.org>; James
>E.J. Bottomley <jejb@linux.ibm.com>; Martin K. Petersen
><martin.petersen@oracle.com>
>Cc: Bean Huo <beanhuo@micron.com>; Adrian Hunter
><adrian.hunter@intel.com>; Yue Hu <huyue2@yulong.com>; linux-
>scsi@vger.kernel.org; linux-kernel@vger.kernel.org
>Subject: [PATCH] scsi: ufs: ufshcd: Drop loglevel of WriteBoost message
>
>Commit '3b5f3c0d0548 ("scsi: ufs: core: Tidy up WB configuration code")'
>changed the log level of the write boost enable/disable notification from
>debug to info, this results in a lot of noise in the kernel log during
normal
>operation.
>
>Drop it back to debug level to avoid this.
>
>Fixes: 3b5f3c0d0548 ("scsi: ufs: core: Tidy up WB configuration code")
>Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
>---
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
> drivers/ufs/core/ufshcd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c index
>22042ee3af14..be65d5bf123e 100644
>--- a/drivers/ufs/core/ufshcd.c
>+++ b/drivers/ufs/core/ufshcd.c
>@@ -5747,7 +5747,7 @@ int ufshcd_wb_toggle(struct ufs_hba *hba, bool
>enable)
> }
>
> hba->dev_info.wb_enabled = enable;
>- dev_info(hba->dev, "%s Write Booster %s\n",
>+ dev_dbg(hba->dev, "%s Write Booster %s\n",
> __func__, enable ? "enabled" : "disabled");
>
> return ret;
>--
>2.35.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: ufs: ufshcd: Drop loglevel of WriteBoost message
2022-07-09 0:00 ` [PATCH] scsi: ufs: ufshcd: Drop loglevel of WriteBoost message Bjorn Andersson
2022-07-09 10:04 ` Alim Akhtar
@ 2022-07-10 21:04 ` Bean Huo
2022-07-14 4:22 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Bean Huo @ 2022-07-10 21:04 UTC (permalink / raw)
To: Bjorn Andersson, Alim Akhtar, Avri Altman, Bart Van Assche,
James E.J. Bottomley, Martin K. Petersen
Cc: Bean Huo, Adrian Hunter, Yue Hu, linux-scsi, linux-kernel
On Fri, 2022-07-08 at 17:00 -0700, Bjorn Andersson wrote:
> Commit '3b5f3c0d0548 ("scsi: ufs: core: Tidy up WB configuration
> code")'
> changed the log level of the write boost enable/disable notification
> from debug to info, this results in a lot of noise in the kernel log
> during normal operation.
>
> Drop it back to debug level to avoid this.
>
> Fixes: 3b5f3c0d0548 ("scsi: ufs: core: Tidy up WB configuration
> code")
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
>
Acked-by: Bean Huo <beanhuo@micron.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: ufs: ufshcd: Drop loglevel of WriteBoost message
2022-07-09 0:00 ` [PATCH] scsi: ufs: ufshcd: Drop loglevel of WriteBoost message Bjorn Andersson
2022-07-09 10:04 ` Alim Akhtar
2022-07-10 21:04 ` Bean Huo
@ 2022-07-14 4:22 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2022-07-14 4:22 UTC (permalink / raw)
To: Bart Van Assche, Bjorn Andersson, James E.J. Bottomley,
Alim Akhtar, Avri Altman
Cc: Martin K . Petersen, Adrian Hunter, Bean Huo, linux-scsi,
linux-kernel, Yue Hu
On Fri, 8 Jul 2022 17:00:27 -0700, Bjorn Andersson wrote:
> Commit '3b5f3c0d0548 ("scsi: ufs: core: Tidy up WB configuration code")'
> changed the log level of the write boost enable/disable notification
> from debug to info, this results in a lot of noise in the kernel log
> during normal operation.
>
> Drop it back to debug level to avoid this.
>
> [...]
Applied to 5.19/scsi-fixes, thanks!
[1/1] scsi: ufs: ufshcd: Drop loglevel of WriteBoost message
https://git.kernel.org/mkp/scsi/c/2ae57c995003
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-07-14 4:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20220708235759epcas5p3705680d639a85558bdbc26d827deb563@epcas5p3.samsung.com>
2022-07-09 0:00 ` [PATCH] scsi: ufs: ufshcd: Drop loglevel of WriteBoost message Bjorn Andersson
2022-07-09 10:04 ` Alim Akhtar
2022-07-10 21:04 ` Bean Huo
2022-07-14 4:22 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).