* Re: [PATCH 01/19] rtc: rtc-mv: remove erroneous __exit annotation
@ 2013-02-28 9:41 Jingoo Han
0 siblings, 0 replies; 2+ messages in thread
From: Jingoo Han @ 2013-02-28 9:41 UTC (permalink / raw)
To: 'Andrew Morton'
Cc: linux-kernel, 'Alessandro Zummo',
rtc-linux, 'Geert Uytterhoeven', 'Jingoo Han'
On Thursday, February 28, 2013 5:38 PM, Jingoo Han wrote:
>
> __init/__exit annotations for probe()/remove() are supposed to be
> __devinit/__devexit, because __init/__exit for probe()/remove()
> are not correct. However, __devinit/__devexit are not used,
> because CONFIG_HOTPLUG was removed. Thus, these annotations
> should be removed.
>
Hi Andrew,
As Geert Uytterhoeven mentioned, the patchset is useless
because the drivers I sent for use platform_driver_probe().
Please, abandon all patchset that I sent.
Thank you.
Best regards,
Jingoo Han
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/rtc/rtc-mv.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/rtc/rtc-mv.c b/drivers/rtc/rtc-mv.c
> index 57233c8..8cb15d2 100644
> --- a/drivers/rtc/rtc-mv.c
> +++ b/drivers/rtc/rtc-mv.c
> @@ -284,7 +284,7 @@ static int mv_rtc_probe(struct platform_device *pdev)
> return 0;
> }
>
> -static int __exit mv_rtc_remove(struct platform_device *pdev)
> +static int mv_rtc_remove(struct platform_device *pdev)
> {
> struct rtc_plat_data *pdata = platform_get_drvdata(pdev);
>
> @@ -303,7 +303,7 @@ static struct of_device_id rtc_mv_of_match_table[] = {
> #endif
>
> static struct platform_driver mv_rtc_driver = {
> - .remove = __exit_p(mv_rtc_remove),
> + .remove = mv_rtc_remove,
> .driver = {
> .name = "rtc-mv",
> .owner = THIS_MODULE,
> --
> 1.7.2.5
^ permalink raw reply [flat|nested] 2+ messages in thread* [PATCH 01/19] rtc: rtc-mv: remove erroneous __exit annotation
@ 2013-02-28 8:38 Jingoo Han
0 siblings, 0 replies; 2+ messages in thread
From: Jingoo Han @ 2013-02-28 8:38 UTC (permalink / raw)
To: 'Andrew Morton'
Cc: linux-kernel, 'Alessandro Zummo',
rtc-linux, 'Jingoo Han'
__init/__exit annotations for probe()/remove() are supposed to be
__devinit/__devexit, because __init/__exit for probe()/remove()
are not correct. However, __devinit/__devexit are not used,
because CONFIG_HOTPLUG was removed. Thus, these annotations
should be removed.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/rtc/rtc-mv.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/rtc/rtc-mv.c b/drivers/rtc/rtc-mv.c
index 57233c8..8cb15d2 100644
--- a/drivers/rtc/rtc-mv.c
+++ b/drivers/rtc/rtc-mv.c
@@ -284,7 +284,7 @@ static int mv_rtc_probe(struct platform_device *pdev)
return 0;
}
-static int __exit mv_rtc_remove(struct platform_device *pdev)
+static int mv_rtc_remove(struct platform_device *pdev)
{
struct rtc_plat_data *pdata = platform_get_drvdata(pdev);
@@ -303,7 +303,7 @@ static struct of_device_id rtc_mv_of_match_table[] = {
#endif
static struct platform_driver mv_rtc_driver = {
- .remove = __exit_p(mv_rtc_remove),
+ .remove = mv_rtc_remove,
.driver = {
.name = "rtc-mv",
.owner = THIS_MODULE,
--
1.7.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-02-28 9:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-02-28 9:41 [PATCH 01/19] rtc: rtc-mv: remove erroneous __exit annotation Jingoo Han
-- strict thread matches above, loose matches on Subject: below --
2013-02-28 8:38 Jingoo Han
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).