From: "Sriram Dash" <sriram.dash@samsung.com>
To: "'Shradha Todi'" <shradha.t@samsung.com>, <kishon@ti.com>
Cc: <lorenzo.pieralisi@arm.com>, <bhelgaas@google.com>,
<pankaj.dubey@samsung.com>, <linux-pci@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] PCI: endpoint: Fix NULL pointer dereference for ->get_features()
Date: Thu, 19 Mar 2020 19:06:01 +0530 [thread overview]
Message-ID: <000d01d5fdf3$55d43af0$017cb0d0$@samsung.com> (raw)
In-Reply-To: <20200311102852.5207-1-shradha.t@samsung.com>
> From: Shradha Todi <shradha.t@samsung.com>
> Subject: [PATCH] PCI: endpoint: Fix NULL pointer dereference for -
> >get_features()
>
> get_features ops of pci_epc_ops may return NULL, causing NULL pointer
> dereference in pci_epf_test_bind function. Let us add a check for
> pci_epc_feature pointer in pci_epf_test_bind before we access it to avoid any
> such NULL pointer dereference and return -ENOTSUPP in case pci_epc_feature
> is not found.
>
> Reviewed-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> Signed-off-by: Sriram Dash <sriram.dash@samsung.com>
> Signed-off-by: Shradha Todi <shradha.t@samsung.com>
> ---
Hi Kishon,
Any update on this?
> drivers/pci/endpoint/functions/pci-epf-test.c | 15 +++++++++------
> 1 file changed, 9 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c
> b/drivers/pci/endpoint/functions/pci-epf-test.c
> index c9121b1b9fa9..af4537a487bf 100644
> --- a/drivers/pci/endpoint/functions/pci-epf-test.c
> +++ b/drivers/pci/endpoint/functions/pci-epf-test.c
> @@ -510,14 +510,17 @@ static int pci_epf_test_bind(struct pci_epf *epf)
> return -EINVAL;
>
> epc_features = pci_epc_get_features(epc, epf->func_no);
> - if (epc_features) {
> - linkup_notifier = epc_features->linkup_notifier;
> - msix_capable = epc_features->msix_capable;
> - msi_capable = epc_features->msi_capable;
> - test_reg_bar = pci_epc_get_first_free_bar(epc_features);
> - pci_epf_configure_bar(epf, epc_features);
> + if (!epc_features) {
> + dev_err(dev, "epc_features not implemented\n");
> + return -ENOTSUPP;
> }
>
> + linkup_notifier = epc_features->linkup_notifier;
> + msix_capable = epc_features->msix_capable;
> + msi_capable = epc_features->msi_capable;
> + test_reg_bar = pci_epc_get_first_free_bar(epc_features);
> + pci_epf_configure_bar(epf, epc_features);
> +
> epf_test->test_reg_bar = test_reg_bar;
> epf_test->epc_features = epc_features;
>
> --
> 2.17.1
next prev parent reply other threads:[~2020-03-19 13:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200311103443epcas5p2e97b8f3a8e52dc6f02eb551e0c97f132@epcas5p2.samsung.com>
2020-03-11 10:28 ` [PATCH] PCI: endpoint: Fix NULL pointer dereference for ->get_features() Shradha Todi
2020-03-19 13:36 ` Sriram Dash [this message]
2020-03-20 10:20 ` Kishon Vijay Abraham I
2020-04-02 14:31 ` Sriram Dash
2020-07-06 11:17 ` Lorenzo Pieralisi
2020-07-06 13:17 ` Sriram Dash
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000d01d5fdf3$55d43af0$017cb0d0$@samsung.com' \
--to=sriram.dash@samsung.com \
--cc=bhelgaas@google.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=pankaj.dubey@samsung.com \
--cc=shradha.t@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).