* [PATCH 1/3] backlight: ep93xx: fix section mismatch
@ 2012-10-25 11:03 Jingoo Han
2012-10-25 11:04 ` [PATCH 2/3] backlight: hp680_bl: add missing __devexit macros for remove Jingoo Han
2012-10-25 11:04 ` [PATCH 3/3] backlight: ili9320: " Jingoo Han
0 siblings, 2 replies; 3+ messages in thread
From: Jingoo Han @ 2012-10-25 11:03 UTC (permalink / raw)
To: 'Andrew Morton', 'LKML'
Cc: 'Richard Purdie', 'H Hartley Sweeten',
'Jingoo Han'
Fix section mismatch warning as below:
WARNING: drivers/video/backlight/built-in.o(.data+0x110): Section mismatch in reference from the variable ep93xxbl_driver to the
function .init.text:ep93xxbl_probe()
The variable ep93xxbl_driver references
the function __init ep93xxbl_probe()
If the reference is valid then annotate the
variable with __init* or __refdata (see linux/init.h) or name the variable:
*_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Cc: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Richard Purdie <rpurdie@rpsys.net>
---
drivers/video/backlight/ep93xx_bl.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/backlight/ep93xx_bl.c b/drivers/video/backlight/ep93xx_bl.c
index 08214e1..d0c688b 100644
--- a/drivers/video/backlight/ep93xx_bl.c
+++ b/drivers/video/backlight/ep93xx_bl.c
@@ -60,7 +60,7 @@ static const struct backlight_ops ep93xxbl_ops = {
.get_brightness = ep93xxbl_get_brightness,
};
-static int __init ep93xxbl_probe(struct platform_device *dev)
+static int __devinit ep93xxbl_probe(struct platform_device *dev)
{
struct ep93xxbl *ep93xxbl;
struct backlight_device *bl;
@@ -106,7 +106,7 @@ static int __init ep93xxbl_probe(struct platform_device *dev)
return 0;
}
-static int ep93xxbl_remove(struct platform_device *dev)
+static int __devexit ep93xxbl_remove(struct platform_device *dev)
{
struct backlight_device *bl = platform_get_drvdata(dev);
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 2/3] backlight: hp680_bl: add missing __devexit macros for remove
2012-10-25 11:03 [PATCH 1/3] backlight: ep93xx: fix section mismatch Jingoo Han
@ 2012-10-25 11:04 ` Jingoo Han
2012-10-25 11:04 ` [PATCH 3/3] backlight: ili9320: " Jingoo Han
1 sibling, 0 replies; 3+ messages in thread
From: Jingoo Han @ 2012-10-25 11:04 UTC (permalink / raw)
To: 'Andrew Morton', 'LKML'
Cc: 'Richard Purdie', 'Jingoo Han'
The __devexit macros is added to remove function. The macros
moves the remove function to devexit section.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Cc: Richard Purdie <rpurdie@rpsys.net>
---
drivers/video/backlight/hp680_bl.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/backlight/hp680_bl.c b/drivers/video/backlight/hp680_bl.c
index 191fbed..31d3a1f 100644
--- a/drivers/video/backlight/hp680_bl.c
+++ b/drivers/video/backlight/hp680_bl.c
@@ -124,7 +124,7 @@ static int __devinit hp680bl_probe(struct platform_device *pdev)
return 0;
}
-static int hp680bl_remove(struct platform_device *pdev)
+static int __devexit hp680bl_remove(struct platform_device *pdev)
{
struct backlight_device *bd = platform_get_drvdata(pdev);
@@ -139,7 +139,7 @@ static int hp680bl_remove(struct platform_device *pdev)
static struct platform_driver hp680bl_driver = {
.probe = hp680bl_probe,
- .remove = hp680bl_remove,
+ .remove = __devexit_p(hp680bl_remove),
.suspend = hp680bl_suspend,
.resume = hp680bl_resume,
.driver = {
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 3/3] backlight: ili9320: add missing __devexit macros for remove
2012-10-25 11:03 [PATCH 1/3] backlight: ep93xx: fix section mismatch Jingoo Han
2012-10-25 11:04 ` [PATCH 2/3] backlight: hp680_bl: add missing __devexit macros for remove Jingoo Han
@ 2012-10-25 11:04 ` Jingoo Han
1 sibling, 0 replies; 3+ messages in thread
From: Jingoo Han @ 2012-10-25 11:04 UTC (permalink / raw)
To: 'Andrew Morton', 'LKML'
Cc: 'Richard Purdie', 'Jingoo Han'
The __devexit macros is added to remove function. The macros
moves the remove function to devexit sections.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Cc: Richard Purdie <rpurdie@rpsys.net>
---
drivers/video/backlight/ili9320.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/video/backlight/ili9320.c b/drivers/video/backlight/ili9320.c
index 09ec735..a0a369d 100644
--- a/drivers/video/backlight/ili9320.c
+++ b/drivers/video/backlight/ili9320.c
@@ -260,7 +260,7 @@ int __devinit ili9320_probe_spi(struct spi_device *spi,
}
EXPORT_SYMBOL_GPL(ili9320_probe_spi);
-int ili9320_remove(struct ili9320 *ili)
+int __devexit ili9320_remove(struct ili9320 *ili)
{
ili9320_power(ili, FB_BLANK_POWERDOWN);
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-10-25 11:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-10-25 11:03 [PATCH 1/3] backlight: ep93xx: fix section mismatch Jingoo Han
2012-10-25 11:04 ` [PATCH 2/3] backlight: hp680_bl: add missing __devexit macros for remove Jingoo Han
2012-10-25 11:04 ` [PATCH 3/3] backlight: ili9320: " Jingoo Han
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).