From: "Namjae Jeon" <namjae.jeon@samsung.com>
To: "'Tetsuhiro Kohada'" <Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp>
Cc: <Mori.Takahiro@ab.MitsubishiElectric.co.jp>,
<motai.hirotaka@aj.mitsubishielectric.co.jp>,
"'Sungjong Seo'" <sj1557.seo@samsung.com>,
<linux-fsdevel@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] exfat: remove 'bps' mount-option
Date: Wed, 8 Apr 2020 09:03:27 +0900 [thread overview]
Message-ID: <001301d60d39$212ccf10$63866d30$@samsung.com> (raw)
In-Reply-To: <20200407083410.79154-1-Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp>
> remount fails because exfat_show_options() returns unsupported option
> 'bps'.
> > # mount -o ro,remount
> > exfat: Unknown parameter 'bps'
>
> To fix the problem, just remove 'bps' option from exfat_show_options().
>
> Signed-off-by: Tetsuhiro Kohada
> <Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp>
I will apply your patches after setting up exfat git tree.
Thanks for your work!
> ---
> fs/exfat/super.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/exfat/super.c b/fs/exfat/super.c index
> 2dd62543a4..1b7d2eb034 100644
> --- a/fs/exfat/super.c
> +++ b/fs/exfat/super.c
> @@ -151,7 +151,6 @@ static int exfat_show_options(struct seq_file *m,
> struct dentry *root)
> seq_puts(m, ",iocharset=utf8");
> else if (sbi->nls_io)
> seq_printf(m, ",iocharset=%s", sbi->nls_io->charset);
> - seq_printf(m, ",bps=%ld", sb->s_blocksize);
> if (opts->errors == EXFAT_ERRORS_CONT)
> seq_puts(m, ",errors=continue");
> else if (opts->errors == EXFAT_ERRORS_PANIC)
> --
> 2.25.0
prev parent reply other threads:[~2020-04-08 0:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200407083445epcas1p243e93ccad42ed28249356d01bbe8bc7d@epcas1p2.samsung.com>
2020-04-07 8:34 ` [PATCH] exfat: remove 'bps' mount-option Tetsuhiro Kohada
2020-04-08 0:03 ` Namjae Jeon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001301d60d39$212ccf10$63866d30$@samsung.com' \
--to=namjae.jeon@samsung.com \
--cc=Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp \
--cc=Mori.Takahiro@ab.MitsubishiElectric.co.jp \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=motai.hirotaka@aj.mitsubishielectric.co.jp \
--cc=sj1557.seo@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).