* [PATCH] exfat: remove 'bps' mount-option
@ 2020-04-07 8:34 ` Tetsuhiro Kohada
2020-04-08 0:03 ` Namjae Jeon
0 siblings, 1 reply; 2+ messages in thread
From: Tetsuhiro Kohada @ 2020-04-07 8:34 UTC (permalink / raw)
To: Kohada.Tetsuhiro
Cc: Mori.Takahiro, motai.hirotaka, Namjae Jeon, Sungjong Seo,
linux-fsdevel, linux-kernel
remount fails because exfat_show_options() returns unsupported option 'bps'.
> # mount -o ro,remount
> exfat: Unknown parameter 'bps'
To fix the problem, just remove 'bps' option from exfat_show_options().
Signed-off-by: Tetsuhiro Kohada <Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp>
---
fs/exfat/super.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/exfat/super.c b/fs/exfat/super.c
index 2dd62543a4..1b7d2eb034 100644
--- a/fs/exfat/super.c
+++ b/fs/exfat/super.c
@@ -151,7 +151,6 @@ static int exfat_show_options(struct seq_file *m, struct dentry *root)
seq_puts(m, ",iocharset=utf8");
else if (sbi->nls_io)
seq_printf(m, ",iocharset=%s", sbi->nls_io->charset);
- seq_printf(m, ",bps=%ld", sb->s_blocksize);
if (opts->errors == EXFAT_ERRORS_CONT)
seq_puts(m, ",errors=continue");
else if (opts->errors == EXFAT_ERRORS_PANIC)
--
2.25.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH] exfat: remove 'bps' mount-option
2020-04-07 8:34 ` [PATCH] exfat: remove 'bps' mount-option Tetsuhiro Kohada
@ 2020-04-08 0:03 ` Namjae Jeon
0 siblings, 0 replies; 2+ messages in thread
From: Namjae Jeon @ 2020-04-08 0:03 UTC (permalink / raw)
To: 'Tetsuhiro Kohada'
Cc: Mori.Takahiro, motai.hirotaka, 'Sungjong Seo',
linux-fsdevel, linux-kernel
> remount fails because exfat_show_options() returns unsupported option
> 'bps'.
> > # mount -o ro,remount
> > exfat: Unknown parameter 'bps'
>
> To fix the problem, just remove 'bps' option from exfat_show_options().
>
> Signed-off-by: Tetsuhiro Kohada
> <Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp>
I will apply your patches after setting up exfat git tree.
Thanks for your work!
> ---
> fs/exfat/super.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/exfat/super.c b/fs/exfat/super.c index
> 2dd62543a4..1b7d2eb034 100644
> --- a/fs/exfat/super.c
> +++ b/fs/exfat/super.c
> @@ -151,7 +151,6 @@ static int exfat_show_options(struct seq_file *m,
> struct dentry *root)
> seq_puts(m, ",iocharset=utf8");
> else if (sbi->nls_io)
> seq_printf(m, ",iocharset=%s", sbi->nls_io->charset);
> - seq_printf(m, ",bps=%ld", sb->s_blocksize);
> if (opts->errors == EXFAT_ERRORS_CONT)
> seq_puts(m, ",errors=continue");
> else if (opts->errors == EXFAT_ERRORS_PANIC)
> --
> 2.25.0
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-08 0:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20200407083445epcas1p243e93ccad42ed28249356d01bbe8bc7d@epcas1p2.samsung.com>
2020-04-07 8:34 ` [PATCH] exfat: remove 'bps' mount-option Tetsuhiro Kohada
2020-04-08 0:03 ` Namjae Jeon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).