From: "Doug Smythies" <dsmythies@telus.net>
To: "'Rafael J. Wysocki'" <rafael@kernel.org>,
"'Jiang Yihe'" <jiangyihe042@gmail.com>
Cc: "'Jacob Pan'" <jacob.jun.pan@linux.intel.com>,
"'Len Brown'" <lenb@kernel.org>, <linux-pm@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
"'Zhang, Rui'" <rui.zhang@intel.com>,
"'Artem Bityutskiy'" <artem.bityutskiy@linux.intel.com>,
"Doug Smythies" <dsmythies@telus.net>
Subject: RE: [PATCH] intel_idle: add Cometlake support
Date: Wed, 29 Nov 2023 07:45:34 -0800 [thread overview]
Message-ID: <001701da22db$180872c0$48195840$@telus.net> (raw)
In-Reply-To: <CAJZ5v0jfEsNVu=fg+Xa118F=hCGGB33U5SbiqWeCMaVMqNpUEA@mail.gmail.com>
Hi All,
This proposed patch has been submitted at least once before.
(I think more than once, but only found 1)
Reference:
https://lore.kernel.org/linux-pm/20200227013411.1.Ica3bb9fa898499d94e0b0a2bfa08ec46c89d84fa@changeid/
I have a Cometlake processor and am not in favor of this patch.
Reference at to why not:
https://bugzilla.kernel.org/show_bug.cgi?id=210741
... Doug
On 2023.11.29 07:19 Rafael wrote:
> +Rui and Artem
>On Wed, Nov 29, 2023 at 3:32 PM Jiang Yihe <jiangyihe042@gmail.com> wrote:
>>
>> Since the Cometlake C-State is supported, support for Cometlake should
>> be added to intel_idle. Just use Kabylake C-State table for Cometlake
>> because they share the same table in intel_cstate.
>>
>> Signed-off-by: Jiang Yihe <jiangyihe042@gmail.com>
>> ---
>> drivers/idle/intel_idle.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/idle/intel_idle.c b/drivers/idle/intel_idle.c
>> index dcda0afec..f83f78037 100644
>> --- a/drivers/idle/intel_idle.c
>> +++ b/drivers/idle/intel_idle.c
>> @@ -1418,6 +1418,8 @@ static const struct x86_cpu_id intel_idle_ids[] __initconst = {
>> X86_MATCH_INTEL_FAM6_MODEL(SKYLAKE, &idle_cpu_skl),
>> X86_MATCH_INTEL_FAM6_MODEL(KABYLAKE_L, &idle_cpu_skl),
>> X86_MATCH_INTEL_FAM6_MODEL(KABYLAKE, &idle_cpu_skl),
>> + X86_MATCH_INTEL_FAM6_MODEL(COMETLAKE_L, &idle_cpu_skl),
>> + X86_MATCH_INTEL_FAM6_MODEL(COMETLAKE, &idle_cpu_skl),
>> X86_MATCH_INTEL_FAM6_MODEL(SKYLAKE_X, &idle_cpu_skx),
>> X86_MATCH_INTEL_FAM6_MODEL(ICELAKE_X, &idle_cpu_icx),
>> X86_MATCH_INTEL_FAM6_MODEL(ICELAKE_D, &idle_cpu_icx),
>> --
next prev parent reply other threads:[~2023-11-29 15:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-29 14:31 [PATCH] intel_idle: add Cometlake support Jiang Yihe
2023-11-29 15:19 ` Rafael J. Wysocki
2023-11-29 15:45 ` Doug Smythies [this message]
2023-11-30 8:24 ` Artem Bityutskiy
-- strict thread matches above, loose matches on Subject: below --
2023-11-29 14:14 Jiang Yihe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001701da22db$180872c0$48195840$@telus.net' \
--to=dsmythies@telus.net \
--cc=artem.bityutskiy@linux.intel.com \
--cc=jacob.jun.pan@linux.intel.com \
--cc=jiangyihe042@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).