From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
To: Doug Smythies <dsmythies@telus.net>,
"'Rafael J. Wysocki'" <rafael@kernel.org>,
'Jiang Yihe' <jiangyihe042@gmail.com>
Cc: 'Jacob Pan' <jacob.jun.pan@linux.intel.com>,
'Len Brown' <lenb@kernel.org>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, "'Zhang,
Rui'" <rui.zhang@intel.com>
Subject: Re: [PATCH] intel_idle: add Cometlake support
Date: Thu, 30 Nov 2023 10:24:19 +0200 [thread overview]
Message-ID: <a9db1de5ab4d2c8fc289654053615a53b9ffc20d.camel@linux.intel.com> (raw)
In-Reply-To: <001701da22db$180872c0$48195840$@telus.net>
On Wed, 2023-11-29 at 07:45 -0800, Doug Smythies wrote:
> Hi All,
>
> This proposed patch has been submitted at least once before.
> (I think more than once, but only found 1)
> Reference:
> https://lore.kernel.org/linux-pm/20200227013411.1.Ica3bb9fa898499d94e0b0a2bfa08ec46c89d84fa@changeid/
>
> I have a Cometlake processor and am not in favor of this patch.
> Reference at to why not:
> https://bugzilla.kernel.org/show_bug.cgi?id=210741
CometLake is a platform from 2020, so I'd classified it as "legacy" and would
not apply this patch without a plausible justification in form of measurement
data.
Comet lake has been used with ACPI C-states for quite a long time, and switching
it to intel_idle now may cause unwelcome changes in user workloads.
Artem.
next prev parent reply other threads:[~2023-11-30 8:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-29 14:31 [PATCH] intel_idle: add Cometlake support Jiang Yihe
2023-11-29 15:19 ` Rafael J. Wysocki
2023-11-29 15:45 ` Doug Smythies
2023-11-30 8:24 ` Artem Bityutskiy [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-11-29 14:14 Jiang Yihe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9db1de5ab4d2c8fc289654053615a53b9ffc20d.camel@linux.intel.com \
--to=artem.bityutskiy@linux.intel.com \
--cc=dsmythies@telus.net \
--cc=jacob.jun.pan@linux.intel.com \
--cc=jiangyihe042@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).