* [PATCH] Input: elantech - fix x_max/y_max values
@ 2020-02-27 11:59 Bernd Edlinger
2020-02-27 12:59 ` Benjamin Tissoires
0 siblings, 1 reply; 8+ messages in thread
From: Bernd Edlinger @ 2020-02-27 11:59 UTC (permalink / raw)
To: linux-kernel, linux-input, Dmitry Torokhov, Benjamin Tissoires,
Kai-Heng Feng, Enrico Weigelt, Allison Randal, Aaron Ma
Since 37548659bb2 moved the querying of the x_max/y_max
values from elantech_set_input_params to elantech_query_info,
the returned x_max/y_max values are different than before,
at least for some firmware versions.
The reason is likely that this is now done before
elantech_set_absolute_mode does run. So it may happen that
the returned values are exactly half of what they used to be,
which makes input_report_abs in PS/2 mode report ABS_X values which
exceed the x_max value, which is very annoying since the mouse stops
to move then, and ABS_Y value become negative, which is benign.
This was observed with a MSI GX70 laptop:
elantech: assuming hardware version 3 (with firmware version 0x250f01)
elantech: Synaptics capabilities query result 0x18, 0x17, 0x0b.
elantech: Elan sample query result 05, 0e, 00
input: ETPS/2 Elantech Touchpad as /devices/platform/i8042/serio...
Correct this by doubling the returned x_max and y_max
value for this specific firmware version.
Fixes: 37548659bb2 ("Input: elantech - query the min/max
information beforehand too")
Signed-off-by: Bernd Edlinger <bernd.edlinger@hotmail.de>
---
drivers/input/mouse/elantech.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c
index 2d8434b..3399db8 100644
--- a/drivers/input/mouse/elantech.c
+++ b/drivers/input/mouse/elantech.c
@@ -1720,6 +1720,10 @@ static int elantech_query_info(struct psmouse *psmouse,
info->x_max = (0x0f & param[0]) << 8 | param[1];
info->y_max = (0xf0 & param[0]) << 4 | param[2];
+ if (info->fw_version == 0x250f01) {
+ info->x_max <<= 1;
+ info->y_max <<= 1;
+ }
break;
case 4:
--
1.9.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] Input: elantech - fix x_max/y_max values 2020-02-27 11:59 [PATCH] Input: elantech - fix x_max/y_max values Bernd Edlinger @ 2020-02-27 12:59 ` Benjamin Tissoires [not found] ` <PR2PR03MB51799BF709B3975A08F139F4E4EB0@PR2PR03MB5179.eurprd03.prod.outlook.com> 0 siblings, 1 reply; 8+ messages in thread From: Benjamin Tissoires @ 2020-02-27 12:59 UTC (permalink / raw) To: Bernd Edlinger, Dave.Wang, jingle Cc: linux-kernel, linux-input, Dmitry Torokhov, Kai-Heng Feng, Enrico Weigelt, Allison Randal, Aaron Ma Hi Bernd, [adding Dave and Jingle] On Thu, Feb 27, 2020 at 12:59 PM Bernd Edlinger <bernd.edlinger@hotmail.de> wrote: > > Since 37548659bb2 moved the querying of the x_max/y_max Hmm, I am pretty sure checkpatch.pl should have complained here: the correct way of mentioning a previous commit is: 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 37548659bb22 ("Input: elantech - query the min/max information beforehand too")' > values from elantech_set_input_params to elantech_query_info, > the returned x_max/y_max values are different than before, > at least for some firmware versions. > > The reason is likely that this is now done before > elantech_set_absolute_mode does run. So it may happen that > the returned values are exactly half of what they used to be, That is weird. Can we get confirmation from Dave or Jingle about that? > which makes input_report_abs in PS/2 mode report ABS_X values which > exceed the x_max value, which is very annoying since the mouse stops > to move then, and ABS_Y value become negative, which is benign. > > This was observed with a MSI GX70 laptop: > > elantech: assuming hardware version 3 (with firmware version 0x250f01) > elantech: Synaptics capabilities query result 0x18, 0x17, 0x0b. > elantech: Elan sample query result 05, 0e, 00 > input: ETPS/2 Elantech Touchpad as /devices/platform/i8042/serio... > > Correct this by doubling the returned x_max and y_max > value for this specific firmware version. > > Fixes: 37548659bb2 ("Input: elantech - query the min/max > information beforehand too") Stephen will complain here: see multiple google results when you search for "lkml linux-next: Fixes tag needs some work" Basically: - SHA1 should be at least 12 digits long - the commit title should not be split, even if it gets longer than 80 columns. Cheers, Benjamin > > Signed-off-by: Bernd Edlinger <bernd.edlinger@hotmail.de> > --- > drivers/input/mouse/elantech.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c > index 2d8434b..3399db8 100644 > --- a/drivers/input/mouse/elantech.c > +++ b/drivers/input/mouse/elantech.c > @@ -1720,6 +1720,10 @@ static int elantech_query_info(struct psmouse *psmouse, > > info->x_max = (0x0f & param[0]) << 8 | param[1]; > info->y_max = (0xf0 & param[0]) << 4 | param[2]; > + if (info->fw_version == 0x250f01) { > + info->x_max <<= 1; > + info->y_max <<= 1; > + } > break; > > case 4: > -- > 1.9.1 > ^ permalink raw reply [flat|nested] 8+ messages in thread
[parent not found: <PR2PR03MB51799BF709B3975A08F139F4E4EB0@PR2PR03MB5179.eurprd03.prod.outlook.com>]
[parent not found: <AM6PR03MB5170F5FC30556BEF89C775C2E4EB0@AM6PR03MB5170.eurprd03.prod.outlook.com>]
* Re: [PATCH v2] Input: elantech - fix x_max/y_max values [not found] ` <AM6PR03MB5170F5FC30556BEF89C775C2E4EB0@AM6PR03MB5170.eurprd03.prod.outlook.com> @ 2020-04-05 5:26 ` Bernd Edlinger 2020-04-05 5:54 ` Bernd Edlinger 0 siblings, 1 reply; 8+ messages in thread From: Bernd Edlinger @ 2020-04-05 5:26 UTC (permalink / raw) To: Benjamin Tissoires, Dave.Wang, jingle Cc: linux-kernel, linux-input, Dmitry Torokhov, Kai-Heng Feng, Enrico Weigelt, Allison Randal, Aaron Ma Ping... This patch works fine for me since several weeks, without it I would not be able to use my laptop any more. Could you please accept this patch? Thanks Bernd. On 2/27/20 11:03 PM, Bernd Edlinger wrote: > Since commit 37548659bb22 ("Input: elantech - query the min/max information beforehand too") > moved the querying of the x_max/y_max values from > elantech_set_input_params to elantech_query_info, > the returned x_max/y_max values are different than before, > at least for some firmware versions. > > The reason is likely that this is now done before > elantech_set_absolute_mode does run. So it may happen that > the returned values are exactly half of what they used to be, > which makes input_report_abs in PS/2 mode report ABS_X values which > exceed the x_max value, which is very annoying since the mouse stops > to move then, and ABS_Y value become negative, which is benign. > > This was observed with a MSI GX70 laptop: > > elantech: assuming hardware version 3 (with firmware version 0x250f01) > elantech: Synaptics capabilities query result 0x18, 0x17, 0x0b. > elantech: Elan sample query result 05, 0e, 00 > input: ETPS/2 Elantech Touchpad as /devices/platform/i8042/serio... > > Correct this by doubling the returned x_max and y_max > value for this specific firmware version. > > Fixes: 37548659bb22 ("Input: elantech - query the min/max information beforehand too") > > Signed-off-by: Bernd Edlinger <bernd.edlinger@hotmail.de> > --- > drivers/input/mouse/elantech.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c > index 2d8434b..3399db8 100644 > --- a/drivers/input/mouse/elantech.c > +++ b/drivers/input/mouse/elantech.c > @@ -1720,6 +1720,10 @@ static int elantech_query_info(struct psmouse *psmouse, > > info->x_max = (0x0f & param[0]) << 8 | param[1]; > info->y_max = (0xf0 & param[0]) << 4 | param[2]; > + if (info->fw_version == 0x250f01) { > + info->x_max <<= 1; > + info->y_max <<= 1; > + } > break; > > case 4: > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] Input: elantech - fix x_max/y_max values 2020-04-05 5:26 ` [PATCH v2] " Bernd Edlinger @ 2020-04-05 5:54 ` Bernd Edlinger 2020-04-09 17:38 ` Bernd Edlinger 0 siblings, 1 reply; 8+ messages in thread From: Bernd Edlinger @ 2020-04-05 5:54 UTC (permalink / raw) To: Benjamin Tissoires, Dave.Wang, jingle Cc: linux-kernel, linux-input, Dmitry Torokhov, Kai-Heng Feng, Enrico Weigelt, Allison Randal, Aaron Ma And, furthermore, there is one thing I find really confusing, I do not see the message v2 quoted below which had an updated commit message, due to that Benjamin Tissoires request. It was from my point of view sent on 2/27/20 11:03 PM, but I cannot find it neither on spinics, nor on marc.info. That is funny. Did it reach you guys at all? Or should I re-send it just in case? Thanks Bernd. On 4/5/20 7:26 AM, Bernd Edlinger wrote: > Ping... > > This patch works fine for me since several weeks, > without it I would not be able to use my laptop any more. > > Could you please accept this patch? > > > Thanks > Bernd. > > > On 2/27/20 11:03 PM, Bernd Edlinger wrote: >> Since commit 37548659bb22 ("Input: elantech - query the min/max information beforehand too") >> moved the querying of the x_max/y_max values from >> elantech_set_input_params to elantech_query_info, >> the returned x_max/y_max values are different than before, >> at least for some firmware versions. >> >> The reason is likely that this is now done before >> elantech_set_absolute_mode does run. So it may happen that >> the returned values are exactly half of what they used to be, >> which makes input_report_abs in PS/2 mode report ABS_X values which >> exceed the x_max value, which is very annoying since the mouse stops >> to move then, and ABS_Y value become negative, which is benign. >> >> This was observed with a MSI GX70 laptop: >> >> elantech: assuming hardware version 3 (with firmware version 0x250f01) >> elantech: Synaptics capabilities query result 0x18, 0x17, 0x0b. >> elantech: Elan sample query result 05, 0e, 00 >> input: ETPS/2 Elantech Touchpad as /devices/platform/i8042/serio... >> >> Correct this by doubling the returned x_max and y_max >> value for this specific firmware version. >> >> Fixes: 37548659bb22 ("Input: elantech - query the min/max information beforehand too") >> >> Signed-off-by: Bernd Edlinger <bernd.edlinger@hotmail.de> >> --- >> drivers/input/mouse/elantech.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c >> index 2d8434b..3399db8 100644 >> --- a/drivers/input/mouse/elantech.c >> +++ b/drivers/input/mouse/elantech.c >> @@ -1720,6 +1720,10 @@ static int elantech_query_info(struct psmouse *psmouse, >> >> info->x_max = (0x0f & param[0]) << 8 | param[1]; >> info->y_max = (0xf0 & param[0]) << 4 | param[2]; >> + if (info->fw_version == 0x250f01) { >> + info->x_max <<= 1; >> + info->y_max <<= 1; >> + } >> break; >> >> case 4: >> ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] Input: elantech - fix x_max/y_max values 2020-04-05 5:54 ` Bernd Edlinger @ 2020-04-09 17:38 ` Bernd Edlinger 2020-04-09 20:07 ` Dmitry Torokhov 0 siblings, 1 reply; 8+ messages in thread From: Bernd Edlinger @ 2020-04-09 17:38 UTC (permalink / raw) To: Benjamin Tissoires, Dave.Wang, jingle Cc: linux-kernel, linux-input, Dmitry Torokhov, Kai-Heng Feng, Enrico Weigelt, Allison Randal, Aaron Ma Are you there? Should I re-post the v2 patch, was that dropped somehow? If I don't hear anything I'll assume I just repost, probably as unchanged v3, right? Thanks, Bernd. On 4/5/20 7:54 AM, Bernd Edlinger wrote: > And, furthermore, there is one thing I find really confusing, > > I do not see the message v2 quoted below which had an updated commit message, > due to that Benjamin Tissoires request. > > It was from my point of view sent on 2/27/20 11:03 PM, > but I cannot find it neither on spinics, nor on marc.info. > That is funny. > > Did it reach you guys at all? > Or should I re-send it just in case? > > > Thanks > Bernd. > > On 4/5/20 7:26 AM, Bernd Edlinger wrote: >> Ping... >> >> This patch works fine for me since several weeks, >> without it I would not be able to use my laptop any more. >> >> Could you please accept this patch? >> >> >> Thanks >> Bernd. >> >> >> On 2/27/20 11:03 PM, Bernd Edlinger wrote: >>> Since commit 37548659bb22 ("Input: elantech - query the min/max information beforehand too") >>> moved the querying of the x_max/y_max values from >>> elantech_set_input_params to elantech_query_info, >>> the returned x_max/y_max values are different than before, >>> at least for some firmware versions. >>> >>> The reason is likely that this is now done before >>> elantech_set_absolute_mode does run. So it may happen that >>> the returned values are exactly half of what they used to be, >>> which makes input_report_abs in PS/2 mode report ABS_X values which >>> exceed the x_max value, which is very annoying since the mouse stops >>> to move then, and ABS_Y value become negative, which is benign. >>> >>> This was observed with a MSI GX70 laptop: >>> >>> elantech: assuming hardware version 3 (with firmware version 0x250f01) >>> elantech: Synaptics capabilities query result 0x18, 0x17, 0x0b. >>> elantech: Elan sample query result 05, 0e, 00 >>> input: ETPS/2 Elantech Touchpad as /devices/platform/i8042/serio... >>> >>> Correct this by doubling the returned x_max and y_max >>> value for this specific firmware version. >>> >>> Fixes: 37548659bb22 ("Input: elantech - query the min/max information beforehand too") >>> >>> Signed-off-by: Bernd Edlinger <bernd.edlinger@hotmail.de> >>> --- >>> drivers/input/mouse/elantech.c | 4 ++++ >>> 1 file changed, 4 insertions(+) >>> >>> diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c >>> index 2d8434b..3399db8 100644 >>> --- a/drivers/input/mouse/elantech.c >>> +++ b/drivers/input/mouse/elantech.c >>> @@ -1720,6 +1720,10 @@ static int elantech_query_info(struct psmouse *psmouse, >>> >>> info->x_max = (0x0f & param[0]) << 8 | param[1]; >>> info->y_max = (0xf0 & param[0]) << 4 | param[2]; >>> + if (info->fw_version == 0x250f01) { >>> + info->x_max <<= 1; >>> + info->y_max <<= 1; >>> + } >>> break; >>> >>> case 4: >>> ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] Input: elantech - fix x_max/y_max values 2020-04-09 17:38 ` Bernd Edlinger @ 2020-04-09 20:07 ` Dmitry Torokhov 2020-04-14 6:09 ` jingle 0 siblings, 1 reply; 8+ messages in thread From: Dmitry Torokhov @ 2020-04-09 20:07 UTC (permalink / raw) To: Bernd Edlinger Cc: Benjamin Tissoires, Dave.Wang, jingle, linux-kernel, linux-input, Kai-Heng Feng, Enrico Weigelt, Allison Randal, Aaron Ma Hi Bernd, On Thu, Apr 09, 2020 at 07:38:17PM +0200, Bernd Edlinger wrote: > Are you there? > > Should I re-post the v2 patch, was that dropped somehow? > > If I don't hear anything I'll assume I just repost, probably > as unchanged v3, right? I do not think we ever got confirmation from Dave or Jingle; from my POV I really dislike arbitrary mangling of the data. I think you are right that the issue is with order of calls, and we need to switch the touchpad into absolute mode to get valid results from the ID query call. Dave, Jingle, any impot here? Benjamin, Kai-Feng, do you know if we try to switch to absolute mode to begin with, will it cause issues with SMBus mode? Thanks. > > Thanks, > Bernd. > > > On 4/5/20 7:54 AM, Bernd Edlinger wrote: > > And, furthermore, there is one thing I find really confusing, > > > > I do not see the message v2 quoted below which had an updated commit message, > > due to that Benjamin Tissoires request. > > > > It was from my point of view sent on 2/27/20 11:03 PM, > > but I cannot find it neither on spinics, nor on marc.info. > > That is funny. > > > > Did it reach you guys at all? > > Or should I re-send it just in case? > > > > > > Thanks > > Bernd. > > > > On 4/5/20 7:26 AM, Bernd Edlinger wrote: > >> Ping... > >> > >> This patch works fine for me since several weeks, > >> without it I would not be able to use my laptop any more. > >> > >> Could you please accept this patch? > >> > >> > >> Thanks > >> Bernd. > >> > >> > >> On 2/27/20 11:03 PM, Bernd Edlinger wrote: > >>> Since commit 37548659bb22 ("Input: elantech - query the min/max information beforehand too") > >>> moved the querying of the x_max/y_max values from > >>> elantech_set_input_params to elantech_query_info, > >>> the returned x_max/y_max values are different than before, > >>> at least for some firmware versions. > >>> > >>> The reason is likely that this is now done before > >>> elantech_set_absolute_mode does run. So it may happen that > >>> the returned values are exactly half of what they used to be, > >>> which makes input_report_abs in PS/2 mode report ABS_X values which > >>> exceed the x_max value, which is very annoying since the mouse stops > >>> to move then, and ABS_Y value become negative, which is benign. > >>> > >>> This was observed with a MSI GX70 laptop: > >>> > >>> elantech: assuming hardware version 3 (with firmware version 0x250f01) > >>> elantech: Synaptics capabilities query result 0x18, 0x17, 0x0b. > >>> elantech: Elan sample query result 05, 0e, 00 > >>> input: ETPS/2 Elantech Touchpad as /devices/platform/i8042/serio... > >>> > >>> Correct this by doubling the returned x_max and y_max > >>> value for this specific firmware version. > >>> > >>> Fixes: 37548659bb22 ("Input: elantech - query the min/max information beforehand too") > >>> > >>> Signed-off-by: Bernd Edlinger <bernd.edlinger@hotmail.de> > >>> --- > >>> drivers/input/mouse/elantech.c | 4 ++++ > >>> 1 file changed, 4 insertions(+) > >>> > >>> diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c > >>> index 2d8434b..3399db8 100644 > >>> --- a/drivers/input/mouse/elantech.c > >>> +++ b/drivers/input/mouse/elantech.c > >>> @@ -1720,6 +1720,10 @@ static int elantech_query_info(struct psmouse *psmouse, > >>> > >>> info->x_max = (0x0f & param[0]) << 8 | param[1]; > >>> info->y_max = (0xf0 & param[0]) << 4 | param[2]; > >>> + if (info->fw_version == 0x250f01) { > >>> + info->x_max <<= 1; > >>> + info->y_max <<= 1; > >>> + } > >>> break; > >>> > >>> case 4: > >>> -- Dmitry ^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH v2] Input: elantech - fix x_max/y_max values 2020-04-09 20:07 ` Dmitry Torokhov @ 2020-04-14 6:09 ` jingle 2021-05-29 15:17 ` Bernd Edlinger 0 siblings, 1 reply; 8+ messages in thread From: jingle @ 2020-04-14 6:09 UTC (permalink / raw) To: 'Dmitry Torokhov', 'Bernd Edlinger' Cc: 'Benjamin Tissoires', 'Dave.Wang', linux-kernel, linux-input, 'Kai-Heng Feng', 'Enrico Weigelt', 'Allison Randal', 'Aaron Ma', '义隆-phoenix' Hi Dmitry, Bernd: We have checked the related function internal. It is right to switch the touchpad into absolute mode first to get valid results from the ID query call in hardware version 2 and 3. Thanks jingle -----Original Message----- From: Dmitry Torokhov [mailto:dmitry.torokhov@gmail.com] Sent: Friday, April 10, 2020 4:08 AM To: Bernd Edlinger Cc: Benjamin Tissoires; Dave.Wang; jingle; linux-kernel@vger.kernel.org; linux-input@vger.kernel.org; Kai-Heng Feng; Enrico Weigelt; Allison Randal; Aaron Ma Subject: Re: [PATCH v2] Input: elantech - fix x_max/y_max values Hi Bernd, On Thu, Apr 09, 2020 at 07:38:17PM +0200, Bernd Edlinger wrote: > Are you there? > > Should I re-post the v2 patch, was that dropped somehow? > > If I don't hear anything I'll assume I just repost, probably as > unchanged v3, right? I do not think we ever got confirmation from Dave or Jingle; from my POV I really dislike arbitrary mangling of the data. I think you are right that the issue is with order of calls, and we need to switch the touchpad into absolute mode to get valid results from the ID query call. Dave, Jingle, any impot here? Benjamin, Kai-Feng, do you know if we try to switch to absolute mode to begin with, will it cause issues with SMBus mode? Thanks. > > Thanks, > Bernd. > > > On 4/5/20 7:54 AM, Bernd Edlinger wrote: > > And, furthermore, there is one thing I find really confusing, > > > > I do not see the message v2 quoted below which had an updated commit > > message, due to that Benjamin Tissoires request. > > > > It was from my point of view sent on 2/27/20 11:03 PM, but I cannot > > find it neither on spinics, nor on marc.info. > > That is funny. > > > > Did it reach you guys at all? > > Or should I re-send it just in case? > > > > > > Thanks > > Bernd. > > > > On 4/5/20 7:26 AM, Bernd Edlinger wrote: > >> Ping... > >> > >> This patch works fine for me since several weeks, without it I > >> would not be able to use my laptop any more. > >> > >> Could you please accept this patch? > >> > >> > >> Thanks > >> Bernd. > >> > >> > >> On 2/27/20 11:03 PM, Bernd Edlinger wrote: > >>> Since commit 37548659bb22 ("Input: elantech - query the min/max > >>> information beforehand too") moved the querying of the x_max/y_max > >>> values from elantech_set_input_params to elantech_query_info, the > >>> returned x_max/y_max values are different than before, at least > >>> for some firmware versions. > >>> > >>> The reason is likely that this is now done before > >>> elantech_set_absolute_mode does run. So it may happen that the > >>> returned values are exactly half of what they used to be, which > >>> makes input_report_abs in PS/2 mode report ABS_X values which > >>> exceed the x_max value, which is very annoying since the mouse > >>> stops to move then, and ABS_Y value become negative, which is benign. > >>> > >>> This was observed with a MSI GX70 laptop: > >>> > >>> elantech: assuming hardware version 3 (with firmware version > >>> 0x250f01) > >>> elantech: Synaptics capabilities query result 0x18, 0x17, 0x0b. > >>> elantech: Elan sample query result 05, 0e, 00 > >>> input: ETPS/2 Elantech Touchpad as /devices/platform/i8042/serio... > >>> > >>> Correct this by doubling the returned x_max and y_max value for > >>> this specific firmware version. > >>> > >>> Fixes: 37548659bb22 ("Input: elantech - query the min/max > >>> information beforehand too") > >>> > >>> Signed-off-by: Bernd Edlinger <bernd.edlinger@hotmail.de> > >>> --- > >>> drivers/input/mouse/elantech.c | 4 ++++ > >>> 1 file changed, 4 insertions(+) > >>> > >>> diff --git a/drivers/input/mouse/elantech.c > >>> b/drivers/input/mouse/elantech.c index 2d8434b..3399db8 100644 > >>> --- a/drivers/input/mouse/elantech.c > >>> +++ b/drivers/input/mouse/elantech.c > >>> @@ -1720,6 +1720,10 @@ static int elantech_query_info(struct > >>> psmouse *psmouse, > >>> > >>> info->x_max = (0x0f & param[0]) << 8 | param[1]; > >>> info->y_max = (0xf0 & param[0]) << 4 | param[2]; > >>> + if (info->fw_version == 0x250f01) { > >>> + info->x_max <<= 1; > >>> + info->y_max <<= 1; > >>> + } > >>> break; > >>> > >>> case 4: > >>> -- Dmitry ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] Input: elantech - fix x_max/y_max values 2020-04-14 6:09 ` jingle @ 2021-05-29 15:17 ` Bernd Edlinger 0 siblings, 0 replies; 8+ messages in thread From: Bernd Edlinger @ 2021-05-29 15:17 UTC (permalink / raw) To: jingle, 'Dmitry Torokhov' Cc: 'Benjamin Tissoires', 'Dave.Wang', linux-kernel, linux-input, 'Kai-Heng Feng', 'Enrico Weigelt', 'Allison Randal', 'Aaron Ma', '义隆-phoenix' Hi Jingle, apologies for not responding earlier, but better late than never... Okay, if I understood your advice correctly, you want me to elantech_set_absolute_mode from elantech_query_info for hardware version 2 and 3, before sending the ETP_FW_ID_QUERY command, while hardware version 4 devices will not need that. Initially when I wrote this patch I was concerned that there might be a way how the firmware might be in a different state after doing this when elantech_setup_smbus is called later. But meanwhile I convinced myself that this can never happen, since the elantech_setup_smbus seems to be unreachable for version < 4 devices. I'll send a new version of the patch later today, if everything works as expected. Thanks, Bernd. On 4/14/20 8:09 AM, jingle wrote: > Hi Dmitry, Bernd: > > We have checked the related function internal. > It is right to switch the touchpad into absolute mode first to get valid > results from the ID query call in hardware version 2 and 3. > > Thanks > jingle > > -----Original Message----- > From: Dmitry Torokhov [mailto:dmitry.torokhov@gmail.com] > Sent: Friday, April 10, 2020 4:08 AM > To: Bernd Edlinger > Cc: Benjamin Tissoires; Dave.Wang; jingle; linux-kernel@vger.kernel.org; > linux-input@vger.kernel.org; Kai-Heng Feng; Enrico Weigelt; Allison Randal; > Aaron Ma > Subject: Re: [PATCH v2] Input: elantech - fix x_max/y_max values > > Hi Bernd, > > On Thu, Apr 09, 2020 at 07:38:17PM +0200, Bernd Edlinger wrote: >> Are you there? >> >> Should I re-post the v2 patch, was that dropped somehow? >> >> If I don't hear anything I'll assume I just repost, probably as >> unchanged v3, right? > > I do not think we ever got confirmation from Dave or Jingle; from my POV I > really dislike arbitrary mangling of the data. > > I think you are right that the issue is with order of calls, and we need to > switch the touchpad into absolute mode to get valid results from the ID > query call. Dave, Jingle, any impot here? > > Benjamin, Kai-Feng, do you know if we try to switch to absolute mode to > begin with, will it cause issues with SMBus mode? > > Thanks. > >> >> Thanks, >> Bernd. >> >> >> On 4/5/20 7:54 AM, Bernd Edlinger wrote: >>> And, furthermore, there is one thing I find really confusing, >>> >>> I do not see the message v2 quoted below which had an updated commit >>> message, due to that Benjamin Tissoires request. >>> >>> It was from my point of view sent on 2/27/20 11:03 PM, but I cannot >>> find it neither on spinics, nor on marc.info. >>> That is funny. >>> >>> Did it reach you guys at all? >>> Or should I re-send it just in case? >>> >>> >>> Thanks >>> Bernd. >>> >>> On 4/5/20 7:26 AM, Bernd Edlinger wrote: >>>> Ping... >>>> >>>> This patch works fine for me since several weeks, without it I >>>> would not be able to use my laptop any more. >>>> >>>> Could you please accept this patch? >>>> >>>> >>>> Thanks >>>> Bernd. >>>> >>>> >>>> On 2/27/20 11:03 PM, Bernd Edlinger wrote: >>>>> Since commit 37548659bb22 ("Input: elantech - query the min/max >>>>> information beforehand too") moved the querying of the x_max/y_max >>>>> values from elantech_set_input_params to elantech_query_info, the >>>>> returned x_max/y_max values are different than before, at least >>>>> for some firmware versions. >>>>> >>>>> The reason is likely that this is now done before >>>>> elantech_set_absolute_mode does run. So it may happen that the >>>>> returned values are exactly half of what they used to be, which >>>>> makes input_report_abs in PS/2 mode report ABS_X values which >>>>> exceed the x_max value, which is very annoying since the mouse >>>>> stops to move then, and ABS_Y value become negative, which is benign. >>>>> >>>>> This was observed with a MSI GX70 laptop: >>>>> >>>>> elantech: assuming hardware version 3 (with firmware version >>>>> 0x250f01) >>>>> elantech: Synaptics capabilities query result 0x18, 0x17, 0x0b. >>>>> elantech: Elan sample query result 05, 0e, 00 >>>>> input: ETPS/2 Elantech Touchpad as /devices/platform/i8042/serio... >>>>> >>>>> Correct this by doubling the returned x_max and y_max value for >>>>> this specific firmware version. >>>>> >>>>> Fixes: 37548659bb22 ("Input: elantech - query the min/max >>>>> information beforehand too") >>>>> >>>>> Signed-off-by: Bernd Edlinger <bernd.edlinger@hotmail.de> >>>>> --- >>>>> drivers/input/mouse/elantech.c | 4 ++++ >>>>> 1 file changed, 4 insertions(+) >>>>> >>>>> diff --git a/drivers/input/mouse/elantech.c >>>>> b/drivers/input/mouse/elantech.c index 2d8434b..3399db8 100644 >>>>> --- a/drivers/input/mouse/elantech.c >>>>> +++ b/drivers/input/mouse/elantech.c >>>>> @@ -1720,6 +1720,10 @@ static int elantech_query_info(struct >>>>> psmouse *psmouse, >>>>> >>>>> info->x_max = (0x0f & param[0]) << 8 | param[1]; >>>>> info->y_max = (0xf0 & param[0]) << 4 | param[2]; >>>>> + if (info->fw_version == 0x250f01) { >>>>> + info->x_max <<= 1; >>>>> + info->y_max <<= 1; >>>>> + } >>>>> break; >>>>> >>>>> case 4: >>>>> > > -- > Dmitry > ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-05-29 15:17 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-27 11:59 [PATCH] Input: elantech - fix x_max/y_max values Bernd Edlinger
2020-02-27 12:59 ` Benjamin Tissoires
[not found] ` <PR2PR03MB51799BF709B3975A08F139F4E4EB0@PR2PR03MB5179.eurprd03.prod.outlook.com>
[not found] ` <AM6PR03MB5170F5FC30556BEF89C775C2E4EB0@AM6PR03MB5170.eurprd03.prod.outlook.com>
2020-04-05 5:26 ` [PATCH v2] " Bernd Edlinger
2020-04-05 5:54 ` Bernd Edlinger
2020-04-09 17:38 ` Bernd Edlinger
2020-04-09 20:07 ` Dmitry Torokhov
2020-04-14 6:09 ` jingle
2021-05-29 15:17 ` Bernd Edlinger
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).