linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mfd: ipaq-micro: Use devm_ioremap_resource()
@ 2014-05-14  3:17 Jingoo Han
  2014-05-16 16:22 ` Linus Walleij
  2014-05-19  8:11 ` Lee Jones
  0 siblings, 2 replies; 3+ messages in thread
From: Jingoo Han @ 2014-05-14  3:17 UTC (permalink / raw)
  To: 'Lee Jones'
  Cc: linux-kernel, 'Samuel Ortiz', 'Linus Walleij',
	'Jingoo Han'

Use devm_ioremap_resource() because devm_request_and_ioremap() is
obsoleted by devm_ioremap_resource().

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/mfd/ipaq-micro.c |   12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/mfd/ipaq-micro.c b/drivers/mfd/ipaq-micro.c
index 1763d6d..5d08daf 100644
--- a/drivers/mfd/ipaq-micro.c
+++ b/drivers/mfd/ipaq-micro.c
@@ -403,17 +403,17 @@ static int micro_probe(struct platform_device *pdev)
 	if (!res)
 		return -EINVAL;
 
-	micro->base = devm_request_and_ioremap(&pdev->dev, res);
-	if (!micro->base)
-		return -ENOMEM;
+	micro->base = devm_ioremap_resource(&pdev->dev, res);
+	if (IS_ERR(micro->base))
+		return PTR_ERR(micro->base);
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
 	if (!res)
 		return -EINVAL;
 
-	micro->sdlc = devm_request_and_ioremap(&pdev->dev, res);
-	if (!micro->sdlc)
-		return -ENOMEM;
+	micro->sdlc = devm_ioremap_resource(&pdev->dev, res);
+	if (IS_ERR(micro->sdlc))
+		return PTR_ERR(micro->sdlc);
 
 	micro_reset_comm(micro);
 
-- 
1.7.10.4



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] mfd: ipaq-micro: Use devm_ioremap_resource()
  2014-05-14  3:17 [PATCH] mfd: ipaq-micro: Use devm_ioremap_resource() Jingoo Han
@ 2014-05-16 16:22 ` Linus Walleij
  2014-05-19  8:11 ` Lee Jones
  1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2014-05-16 16:22 UTC (permalink / raw)
  To: Jingoo Han; +Cc: Lee Jones, linux-kernel, Samuel Ortiz

On Wed, May 14, 2014 at 5:17 AM, Jingoo Han <jg1.han@samsung.com> wrote:

> Use devm_ioremap_resource() because devm_request_and_ioremap() is
> obsoleted by devm_ioremap_resource().
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>

Acked-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] mfd: ipaq-micro: Use devm_ioremap_resource()
  2014-05-14  3:17 [PATCH] mfd: ipaq-micro: Use devm_ioremap_resource() Jingoo Han
  2014-05-16 16:22 ` Linus Walleij
@ 2014-05-19  8:11 ` Lee Jones
  1 sibling, 0 replies; 3+ messages in thread
From: Lee Jones @ 2014-05-19  8:11 UTC (permalink / raw)
  To: Jingoo Han; +Cc: linux-kernel, 'Samuel Ortiz', 'Linus Walleij'

> Use devm_ioremap_resource() because devm_request_and_ioremap() is
> obsoleted by devm_ioremap_resource().
> 
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
>  drivers/mfd/ipaq-micro.c |   12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)

Applied with Linus' Ack, thanks.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-05-19  8:11 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-14  3:17 [PATCH] mfd: ipaq-micro: Use devm_ioremap_resource() Jingoo Han
2014-05-16 16:22 ` Linus Walleij
2014-05-19  8:11 ` Lee Jones

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).