* [PATCH] mfd: mc13xxx: remove unnecessary spi_set_drvdata()
@ 2013-11-25 3:27 Jingoo Han
2013-11-25 9:36 ` Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: Jingoo Han @ 2013-11-25 3:27 UTC (permalink / raw)
To: 'Lee Jones'
Cc: linux-kernel, 'Samuel Ortiz', 'Jingoo Han',
'Uwe Kleine-König', 'Marc Reilly'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/mfd/mc13xxx-spi.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mfd/mc13xxx-spi.c b/drivers/mfd/mc13xxx-spi.c
index 5f14ef6..cbcc86d 100644
--- a/drivers/mfd/mc13xxx-spi.c
+++ b/drivers/mfd/mc13xxx-spi.c
@@ -149,7 +149,6 @@ static int mc13xxx_spi_probe(struct spi_device *spi)
ret = PTR_ERR(mc13xxx->regmap);
dev_err(mc13xxx->dev, "Failed to initialize register map: %d\n",
ret);
- spi_set_drvdata(spi, NULL);
return ret;
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mfd: mc13xxx: remove unnecessary spi_set_drvdata()
2013-11-25 3:27 [PATCH] mfd: mc13xxx: remove unnecessary spi_set_drvdata() Jingoo Han
@ 2013-11-25 9:36 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2013-11-25 9:36 UTC (permalink / raw)
To: Jingoo Han
Cc: linux-kernel, 'Samuel Ortiz',
'Uwe Kleine-König', 'Marc Reilly'
On Mon, 25 Nov 2013, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure. Thus, it is not needed to manually clear the
> device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/mfd/mc13xxx-spi.c | 1 -
> 1 file changed, 1 deletion(-)
Applied, thanks.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-11-25 9:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-11-25 3:27 [PATCH] mfd: mc13xxx: remove unnecessary spi_set_drvdata() Jingoo Han
2013-11-25 9:36 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).