RE: [PATCH] infiniband:cxgb4:Make the function rdma_supported bool

RE: [PATCH] infiniband:cxgb4:Make the function rdma_supported bool

[Steve Wise]

Is this change really worth the effort?


> -----Original Message-----
> From: Nicholas Krause [mailto:xerofoify@gmail.com]
> Sent: Thursday, July 16, 2015 1:34 PM
> To: swise@chelsio.com
> Cc: dledford@redhat.com; sean.hefty@intel.com; hal.rosenstock@gmail.com; linux-rdma@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] infiniband:cxgb4:Make the function rdma_supported bool
> 
> This makes the function rdma_supported have a return type of bool
> due to this particular function's return statement always returning
> either one or zero as its return value.
> 
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
>  drivers/infiniband/hw/cxgb4/device.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/hw/cxgb4/device.c b/drivers/infiniband/hw/cxgb4/device.c
> index 1a29739..285f6606 100644
> --- a/drivers/infiniband/hw/cxgb4/device.c
> +++ b/drivers/infiniband/hw/cxgb4/device.c
> @@ -912,7 +912,7 @@ static void c4iw_remove(struct uld_ctx *ctx)
>  	c4iw_dealloc(ctx);
>  }
> 
> -static int rdma_supported(const struct cxgb4_lld_info *infop)
> +static bool rdma_supported(const struct cxgb4_lld_info *infop)
>  {
>  	return infop->vr->stag.size > 0 && infop->vr->pbl.size > 0 &&
>  	       infop->vr->rq.size > 0 && infop->vr->qp.size > 0 &&
> --
> 2.1.4