From: Paul Durrant <xadimgnik@gmail.com>
To: "'Souptick Joarder'" <jrdr.linux@gmail.com>,
<boris.ostrovsky@oracle.com>, <jgross@suse.com>,
<sstabellini@kernel.org>
Cc: <xen-devel@lists.xenproject.org>, <linux-kernel@vger.kernel.org>,
"'John Hubbard'" <jhubbard@nvidia.com>,
"'Paul Durrant'" <xadimgnik@gmail.com>
Subject: RE: [PATCH v3 3/3] xen/privcmd: Convert get_user_pages*() to pin_user_pages*()
Date: Mon, 13 Jul 2020 09:10:38 +0100 [thread overview]
Message-ID: <003a01d658ed$1858e220$490aa660$@xen.org> (raw)
In-Reply-To: <1594525195-28345-4-git-send-email-jrdr.linux@gmail.com>
> -----Original Message-----
> From: Souptick Joarder <jrdr.linux@gmail.com>
> Sent: 12 July 2020 04:40
> To: boris.ostrovsky@oracle.com; jgross@suse.com; sstabellini@kernel.org
> Cc: xen-devel@lists.xenproject.org; linux-kernel@vger.kernel.org; Souptick Joarder
> <jrdr.linux@gmail.com>; John Hubbard <jhubbard@nvidia.com>; Paul Durrant <xadimgnik@gmail.com>
> Subject: [PATCH v3 3/3] xen/privcmd: Convert get_user_pages*() to pin_user_pages*()
>
> In 2019, we introduced pin_user_pages*() and now we are converting
> get_user_pages*() to the new API as appropriate. [1] & [2] could
> be referred for more information. This is case 5 as per document [1].
>
> [1] Documentation/core-api/pin_user_pages.rst
>
> [2] "Explicit pinning of user-space pages":
> https://lwn.net/Articles/807108/
>
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> Reviewed-by: Juergen Gross <jgross@suse.com>
> Cc: John Hubbard <jhubbard@nvidia.com>
> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> Cc: Paul Durrant <xadimgnik@gmail.com>
Reviewed-by: Paul Durrant <paul@xen.org>
> ---
> drivers/xen/privcmd.c | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/xen/privcmd.c b/drivers/xen/privcmd.c
> index 079d35b..63abe6c 100644
> --- a/drivers/xen/privcmd.c
> +++ b/drivers/xen/privcmd.c
> @@ -593,7 +593,7 @@ static int lock_pages(
> if (requested > nr_pages)
> return -ENOSPC;
>
> - page_count = get_user_pages_fast(
> + page_count = pin_user_pages_fast(
> (unsigned long) kbufs[i].uptr,
> requested, FOLL_WRITE, pages);
> if (page_count < 0)
> @@ -609,13 +609,7 @@ static int lock_pages(
>
> static void unlock_pages(struct page *pages[], unsigned int nr_pages)
> {
> - unsigned int i;
> -
> - for (i = 0; i < nr_pages; i++) {
> - if (!PageDirty(pages[i]))
> - set_page_dirty_lock(pages[i]);
> - put_page(pages[i]);
> - }
> + unpin_user_pages_dirty_lock(pages, nr_pages, true);
> }
>
> static long privcmd_ioctl_dm_op(struct file *file, void __user *udata)
> --
> 1.9.1
next prev parent reply other threads:[~2020-07-13 8:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-12 3:39 [PATCH v3 0/3] Few bug fixes and Convert to pin_user_pages*() Souptick Joarder
2020-07-12 3:39 ` [PATCH v3 1/3] xen/privcmd: Corrected error handling path Souptick Joarder
2020-07-13 8:08 ` Paul Durrant
2020-07-12 3:39 ` [PATCH v3 2/3] xen/privcmd: Mark pages as dirty Souptick Joarder
2020-07-13 8:09 ` Paul Durrant
2020-07-12 3:39 ` [PATCH v3 3/3] xen/privcmd: Convert get_user_pages*() to pin_user_pages*() Souptick Joarder
2020-07-13 8:10 ` Paul Durrant [this message]
2020-07-28 7:10 ` [PATCH v3 0/3] Few bug fixes and Convert " Souptick Joarder
2020-07-28 7:38 ` Jürgen Groß
2020-08-03 5:44 ` Jürgen Groß
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='003a01d658ed$1858e220$490aa660$@xen.org' \
--to=xadimgnik@gmail.com \
--cc=boris.ostrovsky@oracle.com \
--cc=jgross@suse.com \
--cc=jhubbard@nvidia.com \
--cc=jrdr.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paul@xen.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).