From: Souptick Joarder <jrdr.linux@gmail.com>
To: boris.ostrovsky@oracle.com, jgross@suse.com, sstabellini@kernel.org
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
Souptick Joarder <jrdr.linux@gmail.com>,
John Hubbard <jhubbard@nvidia.com>,
Paul Durrant <xadimgnik@gmail.com>
Subject: [PATCH v3 2/3] xen/privcmd: Mark pages as dirty
Date: Sun, 12 Jul 2020 09:09:54 +0530 [thread overview]
Message-ID: <1594525195-28345-3-git-send-email-jrdr.linux@gmail.com> (raw)
In-Reply-To: <1594525195-28345-1-git-send-email-jrdr.linux@gmail.com>
pages need to be marked as dirty before unpinned it in
unlock_pages() which was oversight. This is fixed now.
Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
Suggested-by: John Hubbard <jhubbard@nvidia.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Cc: John Hubbard <jhubbard@nvidia.com>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Paul Durrant <xadimgnik@gmail.com>
---
drivers/xen/privcmd.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/xen/privcmd.c b/drivers/xen/privcmd.c
index b001673..079d35b 100644
--- a/drivers/xen/privcmd.c
+++ b/drivers/xen/privcmd.c
@@ -611,8 +611,11 @@ static void unlock_pages(struct page *pages[], unsigned int nr_pages)
{
unsigned int i;
- for (i = 0; i < nr_pages; i++)
+ for (i = 0; i < nr_pages; i++) {
+ if (!PageDirty(pages[i]))
+ set_page_dirty_lock(pages[i]);
put_page(pages[i]);
+ }
}
static long privcmd_ioctl_dm_op(struct file *file, void __user *udata)
--
1.9.1
next prev parent reply other threads:[~2020-07-12 3:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-12 3:39 [PATCH v3 0/3] Few bug fixes and Convert to pin_user_pages*() Souptick Joarder
2020-07-12 3:39 ` [PATCH v3 1/3] xen/privcmd: Corrected error handling path Souptick Joarder
2020-07-13 8:08 ` Paul Durrant
2020-07-12 3:39 ` Souptick Joarder [this message]
2020-07-13 8:09 ` [PATCH v3 2/3] xen/privcmd: Mark pages as dirty Paul Durrant
2020-07-12 3:39 ` [PATCH v3 3/3] xen/privcmd: Convert get_user_pages*() to pin_user_pages*() Souptick Joarder
2020-07-13 8:10 ` Paul Durrant
2020-07-28 7:10 ` [PATCH v3 0/3] Few bug fixes and Convert " Souptick Joarder
2020-07-28 7:38 ` Jürgen Groß
2020-08-03 5:44 ` Jürgen Groß
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1594525195-28345-3-git-send-email-jrdr.linux@gmail.com \
--to=jrdr.linux@gmail.com \
--cc=boris.ostrovsky@oracle.com \
--cc=jgross@suse.com \
--cc=jhubbard@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sstabellini@kernel.org \
--cc=xadimgnik@gmail.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).