* Re: [PATCH] hugetlb: clear PG_reserved before setting PG_head on gigantic pages
[not found] <004b01d10596$60e7eae0$22b7c0a0$@alibaba-inc.com>
@ 2015-10-13 9:09 ` Hillf Danton
0 siblings, 0 replies; 2+ messages in thread
From: Hillf Danton @ 2015-10-13 9:09 UTC (permalink / raw)
To: Kirill A. Shutemov, Sasha Levin; +Cc: Andrew Morton, linux-kernel, linux-mm
> PF_NO_COMPOUND for PG_reserved assumes we don't use PG_reserved for
> compound pages. And we generally don't. But during allocation of
> gigantic pages we set PG_head before clearing PG_reserved and
> __ClearPageReserved() steps on the VM_BUG_ON_PAGE().
>
> The fix is trivial: set PG_head after PG_reserved.
>
> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> Reported-by: Sasha Levin <sasha.levin@oracle.com>
> ---
Acked-by: Hillf Danton <hillf.zj@alibaba-inc.com>
>
> Andrew, this patch can be folded into "page-flags: define PG_reserved behavior on compound pages".
>
> ---
> mm/hugetlb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> index 6ecf61ffa65d..bd3f3e20313b 100644
> --- a/mm/hugetlb.c
> +++ b/mm/hugetlb.c
> @@ -1258,8 +1258,8 @@ static void prep_compound_gigantic_page(struct page *page, unsigned int order)
>
> /* we rely on prep_new_huge_page to set the destructor */
> set_compound_order(page, order);
> - __SetPageHead(page);
> __ClearPageReserved(page);
> + __SetPageHead(page);
> for (i = 1; i < nr_pages; i++, p = mem_map_next(p, page, i)) {
> /*
> * For gigantic hugepages allocated through bootmem at
> --
> 2.5.3
>
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] hugetlb: clear PG_reserved before setting PG_head on gigantic pages
@ 2015-10-06 14:35 Kirill A. Shutemov
0 siblings, 0 replies; 2+ messages in thread
From: Kirill A. Shutemov @ 2015-10-06 14:35 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel, linux-mm, Kirill A. Shutemov
PF_NO_COMPOUND for PG_reserved assumes we don't use PG_reserved for
compound pages. And we generally don't. But during allocation of
gigantic pages we set PG_head before clearing PG_reserved and
__ClearPageReserved() steps on the VM_BUG_ON_PAGE().
The fix is trivial: set PG_head after PG_reserved.
Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Reported-by: Sasha Levin <sasha.levin@oracle.com>
---
Andrew, this patch can be folded into "page-flags: define PG_reserved behavior on compound pages".
---
mm/hugetlb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index 6ecf61ffa65d..bd3f3e20313b 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -1258,8 +1258,8 @@ static void prep_compound_gigantic_page(struct page *page, unsigned int order)
/* we rely on prep_new_huge_page to set the destructor */
set_compound_order(page, order);
- __SetPageHead(page);
__ClearPageReserved(page);
+ __SetPageHead(page);
for (i = 1; i < nr_pages; i++, p = mem_map_next(p, page, i)) {
/*
* For gigantic hugepages allocated through bootmem at
--
2.5.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-13 9:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <004b01d10596$60e7eae0$22b7c0a0$@alibaba-inc.com>
2015-10-13 9:09 ` [PATCH] hugetlb: clear PG_reserved before setting PG_head on gigantic pages Hillf Danton
2015-10-06 14:35 Kirill A. Shutemov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).