From: "erich" <erich@areca.com.tw>
To: "Arjan van de Ven" <arjan@infradead.org>
Cc: "\"\"Christoph Hellwig\"\"" <hch@infradead.org>,
<linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<billion.wu@areca.com.tw>, <alan@lxorguk.ukuu.org.uk>,
<akpm@osdl.org>, <oliver@neukum.org>
Subject: Re: Areca RAID driver remaining items?
Date: Thu, 23 Feb 2006 19:51:41 +0800 [thread overview]
Message-ID: <005a01c6386f$84b30d50$b100a8c0@erich2003> (raw)
In-Reply-To: 1140688569.4672.24.camel@laptopd505.fenrus.org
Dear Arjan van de Ven,
Thanks for your answer.
I will remove CONFIG_SCSI_ARCMSR_MSI in next patch.
If Linux can not assurent the contingous memory space allocating of
"dma_alloc_coherent" .
When arcmsr get a physical ccb address from areca's firmware.
Does linux has any functions for converting of "bus to virtual" ?
Best Regards
Erich Chen
----- Original Message -----
From: "Arjan van de Ven" <arjan@infradead.org>
To: "erich" <erich@areca.com.tw>
Cc: ""Christoph Hellwig"" <hch@infradead.org>; <linux-scsi@vger.kernel.org>;
<linux-kernel@vger.kernel.org>; <billion.wu@areca.com.tw>;
<alan@lxorguk.ukuu.org.uk>; <akpm@osdl.org>; <oliver@neukum.org>
Sent: Thursday, February 23, 2006 5:56 PM
Subject: Re: Areca RAID driver remaining items?
> On Thu, 2006-02-23 at 17:50 +0800, erich wrote:
>> Dear Arjan van de Ven,
>>
>> The following contex is coming from comment of Christoph Hellwig.
>>
>> - msi should be a module options if at all, but defintitly not
>> a config options
>>
>> #ifdef CONFIG_SCSI_ARCMSR_MSI
>> if (!pci_enable_msi(pci_device))
>> pACB->acb_flags |= ACB_F_HAVE_MSI;
>> #endif
>>
>> I make an option config for prevent some mainboards hang up if arcmsr
>> enable
>> msi function.
>> Areca RAID controller is bridged hardware.
>> There were a lots of mainboards had wrong IRQ routing table issue with
>> it.
>> If somebody meet this issue and people can enable msi function to fix its
>> hardware bug.
>> But unfortunately I found some mainboards will hang up if I always enable
>> this function in my lab.
>> To avoid this issue, I do an option for this case.
>
>
> yes the reason for making this optional is clear, and Christoph also
> understands that.
>
> However the idea that Christoph is proposing is to not make it a compile
> time option, but a runtime option. Compile-time is not very flexible,
> especially not for linux distributions. Making it a module option means
> it becomes runtime behavior, and the user can load the module like
>
> modprobe aerca msi=0
>
> and msi gets turned off. No need to recompile anything! That has many
> advantages over a more inflexible (from the user view) compiletime-only
> option.
>
>
next prev parent reply other threads:[~2006-02-23 11:51 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-20 18:02 Areca RAID driver remaining items? Dax Kelson
2006-02-20 18:11 ` Arjan van de Ven
2006-02-20 18:20 ` Christoph Hellwig
2006-02-22 6:27 ` erich
2006-02-22 14:57 ` Christoph Hellwig
2006-02-23 6:27 ` erich
2006-02-23 8:25 ` Arjan van de Ven
2006-02-23 9:50 ` erich
2006-02-23 9:56 ` Arjan van de Ven
2006-02-23 11:51 ` erich [this message]
2006-02-23 12:07 ` Arjan van de Ven
2006-02-24 2:08 ` erich
2006-02-24 8:50 ` Arjan van de Ven
2006-02-23 11:59 ` Alan Cox
2006-02-24 2:36 ` erich
2006-02-24 16:56 ` Christoph Hellwig
2006-02-24 17:03 ` Randy.Dunlap
2006-02-24 19:38 ` Matthew Wilcox
2006-02-24 20:14 ` Randy.Dunlap
2006-02-26 6:41 ` Randy.Dunlap
2006-02-26 16:02 ` Matthew Wilcox
2006-02-26 19:00 ` Randy.Dunlap
2006-02-24 3:18 erich
2006-02-27 11:27 erich
2006-02-27 12:36 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='005a01c6386f$84b30d50$b100a8c0@erich2003' \
--to=erich@areca.com.tw \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=arjan@infradead.org \
--cc=billion.wu@areca.com.tw \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=oliver@neukum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).