From: "Johnny.Chuang" <johnny.chuang@emc.com.tw>
To: "'Peter Hutterer'" <peter.hutterer@who-t.net>,
"'Johnny Chuang'" <johnny.chuang.emc@gmail.com>
Cc: "'Dmitry Torokhov'" <dmitry.torokhov@gmail.com>,
"'Benjamin Tissoires'" <benjamin.tissoires@redhat.com>,
<linux-kernel@vger.kernel.org>, <linux-input@vger.kernel.org>,
"'Jennifer Tsai'" <jennifer.tsai@emc.com.tw>,
"'James Chen'" <james.chen@emc.com.tw>,
"'Paul Liang'" <paul.liang@emc.com.tw>,
"'Jeff Chuang'" <jeff.chuang@emc.com.tw>
Subject: RE: [PATCH] Input: elants_i2c - Report resolution information for touch major
Date: Mon, 2 Mar 2020 16:14:51 +0800 [thread overview]
Message-ID: <007201d5f06a$a5f341c0$f1d9c540$@emc.com.tw> (raw)
In-Reply-To: <20200227223608.GB1087116@jelly>
> -----Original Message-----
> From: Peter Hutterer [mailto:peter.hutterer@who-t.net]
> Sent: Friday, February 28, 2020 6:36 AM
> To: Johnny Chuang
> Cc: Dmitry Torokhov; Benjamin Tissoires; linux-kernel@vger.kernel.org;
> linux-input@vger.kernel.org; Johnny Chuang; Jennifer Tsai; James Chen;
Paul
> Liang; Jeff Chuang
> Subject: Re: [PATCH] Input: elants_i2c - Report resolution information for
touch
> major
>
> On Thu, Feb 27, 2020 at 09:13:20AM +0800, Johnny Chuang wrote:
> > From: Johnny Chuang <johnny.chuang@emc.com.tw>
> >
> > This patch supports reporting resolution for ABS_MT_TOUCH_MAJOR event.
> > This information is needed in showing pressure/width radius.
> >
> > Signed-off-by: Johnny Chuang <johnny.chuang@emc.com.tw>
> > ---
> > drivers/input/touchscreen/elants_i2c.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/input/touchscreen/elants_i2c.c
> b/drivers/input/touchscreen/elants_i2c.c
> > index 4911799..14c577c 100644
> > --- a/drivers/input/touchscreen/elants_i2c.c
> > +++ b/drivers/input/touchscreen/elants_i2c.c
> > @@ -1309,6 +1309,7 @@ static int elants_i2c_probe(struct i2c_client
> *client,
> > input_set_abs_params(ts->input, ABS_MT_PRESSURE, 0, 255, 0, 0);
> > input_abs_set_res(ts->input, ABS_MT_POSITION_X, ts->x_res);
> > input_abs_set_res(ts->input, ABS_MT_POSITION_Y, ts->y_res);
> > + input_abs_set_res(ts->input, ABS_MT_TOUCH_MAJOR, 1);
>
> official resolution for absinfo is "units per mm", so a value of 3 would
> mean 3mm, is that correct?
Correct.
This resolution (1 unit/mm) is for all elan I2C touchscreen devices,
including the touchscreen devices in the future.
This information is from our firmware members.
>
> Not that it matters too much, since touch major is already all over the
> place and needs userspace overrides for every device but it'd be nice to
at
> least make this useful out of the box on one device class.
>
> Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>
>
> otherwise
>
> Cheers,
> Peter
>
> >
> > error = input_register_device(ts->input);
> > if (error) {
> > --
> > 2.7.4
> >
next prev parent reply other threads:[~2020-03-02 8:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 1:13 [PATCH] Input: elants_i2c - Report resolution information for touch major Johnny Chuang
2020-02-27 18:44 ` Harry Cutts
2020-02-27 22:36 ` Peter Hutterer
2020-03-02 8:14 ` Johnny.Chuang [this message]
2020-03-06 6:27 ` Johnny.Chuang
2020-03-06 7:46 ` Johnny.Chuang
2020-03-06 17:45 ` Benjamin Tissoires
2020-03-06 18:05 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='007201d5f06a$a5f341c0$f1d9c540$@emc.com.tw' \
--to=johnny.chuang@emc.com.tw \
--cc=benjamin.tissoires@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=james.chen@emc.com.tw \
--cc=jeff.chuang@emc.com.tw \
--cc=jennifer.tsai@emc.com.tw \
--cc=johnny.chuang.emc@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.liang@emc.com.tw \
--cc=peter.hutterer@who-t.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).