* [PATCH] Input: elants_i2c - Report resolution information for touch major @ 2020-02-27 1:13 Johnny Chuang 2020-02-27 18:44 ` Harry Cutts ` (3 more replies) 0 siblings, 4 replies; 8+ messages in thread From: Johnny Chuang @ 2020-02-27 1:13 UTC (permalink / raw) To: Dmitry Torokhov, Benjamin Tissoires, Peter Hutterer, linux-kernel, linux-input, Johnny Chuang, Jennifer Tsai Cc: James Chen, Paul Liang, Jeff Chuang From: Johnny Chuang <johnny.chuang@emc.com.tw> This patch supports reporting resolution for ABS_MT_TOUCH_MAJOR event. This information is needed in showing pressure/width radius. Signed-off-by: Johnny Chuang <johnny.chuang@emc.com.tw> --- drivers/input/touchscreen/elants_i2c.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/input/touchscreen/elants_i2c.c b/drivers/input/touchscreen/elants_i2c.c index 4911799..14c577c 100644 --- a/drivers/input/touchscreen/elants_i2c.c +++ b/drivers/input/touchscreen/elants_i2c.c @@ -1309,6 +1309,7 @@ static int elants_i2c_probe(struct i2c_client *client, input_set_abs_params(ts->input, ABS_MT_PRESSURE, 0, 255, 0, 0); input_abs_set_res(ts->input, ABS_MT_POSITION_X, ts->x_res); input_abs_set_res(ts->input, ABS_MT_POSITION_Y, ts->y_res); + input_abs_set_res(ts->input, ABS_MT_TOUCH_MAJOR, 1); error = input_register_device(ts->input); if (error) { -- 2.7.4 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] Input: elants_i2c - Report resolution information for touch major 2020-02-27 1:13 [PATCH] Input: elants_i2c - Report resolution information for touch major Johnny Chuang @ 2020-02-27 18:44 ` Harry Cutts 2020-02-27 22:36 ` Peter Hutterer ` (2 subsequent siblings) 3 siblings, 0 replies; 8+ messages in thread From: Harry Cutts @ 2020-02-27 18:44 UTC (permalink / raw) To: Johnny Chuang Cc: Dmitry Torokhov, Benjamin Tissoires, Peter Hutterer, lkml, linux-input, Johnny Chuang, Jennifer Tsai, James Chen, Paul Liang, Jeff Chuang On Wed, 26 Feb 2020 at 17:13, Johnny Chuang <johnny.chuang.emc@gmail.com> wrote: > > From: Johnny Chuang <johnny.chuang@emc.com.tw> > > This patch supports reporting resolution for ABS_MT_TOUCH_MAJOR event. > This information is needed in showing pressure/width radius. > > Signed-off-by: Johnny Chuang <johnny.chuang@emc.com.tw> > --- > drivers/input/touchscreen/elants_i2c.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Harry Cutts <hcutts@chromium.org> Harry Cutts Chrome OS Touch/Input team ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Input: elants_i2c - Report resolution information for touch major 2020-02-27 1:13 [PATCH] Input: elants_i2c - Report resolution information for touch major Johnny Chuang 2020-02-27 18:44 ` Harry Cutts @ 2020-02-27 22:36 ` Peter Hutterer 2020-03-02 8:14 ` Johnny.Chuang ` (2 more replies) 2020-03-06 17:45 ` Benjamin Tissoires 2020-03-06 18:05 ` Dmitry Torokhov 3 siblings, 3 replies; 8+ messages in thread From: Peter Hutterer @ 2020-02-27 22:36 UTC (permalink / raw) To: Johnny Chuang Cc: Dmitry Torokhov, Benjamin Tissoires, linux-kernel, linux-input, Johnny Chuang, Jennifer Tsai, James Chen, Paul Liang, Jeff Chuang On Thu, Feb 27, 2020 at 09:13:20AM +0800, Johnny Chuang wrote: > From: Johnny Chuang <johnny.chuang@emc.com.tw> > > This patch supports reporting resolution for ABS_MT_TOUCH_MAJOR event. > This information is needed in showing pressure/width radius. > > Signed-off-by: Johnny Chuang <johnny.chuang@emc.com.tw> > --- > drivers/input/touchscreen/elants_i2c.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/input/touchscreen/elants_i2c.c b/drivers/input/touchscreen/elants_i2c.c > index 4911799..14c577c 100644 > --- a/drivers/input/touchscreen/elants_i2c.c > +++ b/drivers/input/touchscreen/elants_i2c.c > @@ -1309,6 +1309,7 @@ static int elants_i2c_probe(struct i2c_client *client, > input_set_abs_params(ts->input, ABS_MT_PRESSURE, 0, 255, 0, 0); > input_abs_set_res(ts->input, ABS_MT_POSITION_X, ts->x_res); > input_abs_set_res(ts->input, ABS_MT_POSITION_Y, ts->y_res); > + input_abs_set_res(ts->input, ABS_MT_TOUCH_MAJOR, 1); official resolution for absinfo is "units per mm", so a value of 3 would mean 3mm, is that correct? Not that it matters too much, since touch major is already all over the place and needs userspace overrides for every device but it'd be nice to at least make this useful out of the box on one device class. Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net> otherwise Cheers, Peter > > error = input_register_device(ts->input); > if (error) { > -- > 2.7.4 > ^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH] Input: elants_i2c - Report resolution information for touch major 2020-02-27 22:36 ` Peter Hutterer @ 2020-03-02 8:14 ` Johnny.Chuang 2020-03-06 6:27 ` Johnny.Chuang 2020-03-06 7:46 ` Johnny.Chuang 2 siblings, 0 replies; 8+ messages in thread From: Johnny.Chuang @ 2020-03-02 8:14 UTC (permalink / raw) To: 'Peter Hutterer', 'Johnny Chuang' Cc: 'Dmitry Torokhov', 'Benjamin Tissoires', linux-kernel, linux-input, 'Jennifer Tsai', 'James Chen', 'Paul Liang', 'Jeff Chuang' > -----Original Message----- > From: Peter Hutterer [mailto:peter.hutterer@who-t.net] > Sent: Friday, February 28, 2020 6:36 AM > To: Johnny Chuang > Cc: Dmitry Torokhov; Benjamin Tissoires; linux-kernel@vger.kernel.org; > linux-input@vger.kernel.org; Johnny Chuang; Jennifer Tsai; James Chen; Paul > Liang; Jeff Chuang > Subject: Re: [PATCH] Input: elants_i2c - Report resolution information for touch > major > > On Thu, Feb 27, 2020 at 09:13:20AM +0800, Johnny Chuang wrote: > > From: Johnny Chuang <johnny.chuang@emc.com.tw> > > > > This patch supports reporting resolution for ABS_MT_TOUCH_MAJOR event. > > This information is needed in showing pressure/width radius. > > > > Signed-off-by: Johnny Chuang <johnny.chuang@emc.com.tw> > > --- > > drivers/input/touchscreen/elants_i2c.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/input/touchscreen/elants_i2c.c > b/drivers/input/touchscreen/elants_i2c.c > > index 4911799..14c577c 100644 > > --- a/drivers/input/touchscreen/elants_i2c.c > > +++ b/drivers/input/touchscreen/elants_i2c.c > > @@ -1309,6 +1309,7 @@ static int elants_i2c_probe(struct i2c_client > *client, > > input_set_abs_params(ts->input, ABS_MT_PRESSURE, 0, 255, 0, 0); > > input_abs_set_res(ts->input, ABS_MT_POSITION_X, ts->x_res); > > input_abs_set_res(ts->input, ABS_MT_POSITION_Y, ts->y_res); > > + input_abs_set_res(ts->input, ABS_MT_TOUCH_MAJOR, 1); > > official resolution for absinfo is "units per mm", so a value of 3 would > mean 3mm, is that correct? Correct. This resolution (1 unit/mm) is for all elan I2C touchscreen devices, including the touchscreen devices in the future. This information is from our firmware members. > > Not that it matters too much, since touch major is already all over the > place and needs userspace overrides for every device but it'd be nice to at > least make this useful out of the box on one device class. > > Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net> > > otherwise > > Cheers, > Peter > > > > > error = input_register_device(ts->input); > > if (error) { > > -- > > 2.7.4 > > ^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH] Input: elants_i2c - Report resolution information for touch major 2020-02-27 22:36 ` Peter Hutterer 2020-03-02 8:14 ` Johnny.Chuang @ 2020-03-06 6:27 ` Johnny.Chuang 2020-03-06 7:46 ` Johnny.Chuang 2 siblings, 0 replies; 8+ messages in thread From: Johnny.Chuang @ 2020-03-06 6:27 UTC (permalink / raw) To: 'Peter Hutterer', 'Johnny Chuang' Cc: 'Dmitry Torokhov', 'Benjamin Tissoires', linux-kernel, linux-input, 'Jennifer Tsai', 'James Chen', 'Paul Liang', 'Jeff Chuang' > > -----Original Message----- > > From: Peter Hutterer [mailto:peter.hutterer@who-t.net] > > Sent: Friday, February 28, 2020 6:36 AM > > To: Johnny Chuang > > Cc: Dmitry Torokhov; Benjamin Tissoires; linux-kernel@vger.kernel.org; > > linux-input@vger.kernel.org; Johnny Chuang; Jennifer Tsai; James Chen; > > Paul Liang; Jeff Chuang > > Subject: Re: [PATCH] Input: elants_i2c - Report resolution information > > for touch major > > > > On Thu, Feb 27, 2020 at 09:13:20AM +0800, Johnny Chuang wrote: > > > From: Johnny Chuang <johnny.chuang@emc.com.tw> > > > > > > This patch supports reporting resolution for ABS_MT_TOUCH_MAJOR > event. > > > This information is needed in showing pressure/width radius. > > > > > > Signed-off-by: Johnny Chuang <johnny.chuang@emc.com.tw> > > > --- > > > drivers/input/touchscreen/elants_i2c.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/input/touchscreen/elants_i2c.c > > b/drivers/input/touchscreen/elants_i2c.c > > > index 4911799..14c577c 100644 > > > --- a/drivers/input/touchscreen/elants_i2c.c > > > +++ b/drivers/input/touchscreen/elants_i2c.c > > > @@ -1309,6 +1309,7 @@ static int elants_i2c_probe(struct i2c_client > > *client, > > > input_set_abs_params(ts->input, ABS_MT_PRESSURE, 0, 255, 0, 0); > > > input_abs_set_res(ts->input, ABS_MT_POSITION_X, ts->x_res); > > > input_abs_set_res(ts->input, ABS_MT_POSITION_Y, ts->y_res); > > > + input_abs_set_res(ts->input, ABS_MT_TOUCH_MAJOR, 1); > > > > official resolution for absinfo is "units per mm", so a value of 3 > > would mean 3mm, is that correct? > > Correct. > This resolution (1 unit/mm) is for all elan I2C touchscreen devices, including > the touchscreen devices in the future. > This information is from our firmware members. Hi Peter / Benjamin, Could you help to review and approve this patch? > > > > > Not that it matters too much, since touch major is already all over > > the place and needs userspace overrides for every device but it'd be > > nice to at least make this useful out of the box on one device class. > > > > Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net> > > > > otherwise > > > > Cheers, > > Peter > > > > > > > > error = input_register_device(ts->input); > > > if (error) { > > > -- > > > 2.7.4 > > > ^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH] Input: elants_i2c - Report resolution information for touch major 2020-02-27 22:36 ` Peter Hutterer 2020-03-02 8:14 ` Johnny.Chuang 2020-03-06 6:27 ` Johnny.Chuang @ 2020-03-06 7:46 ` Johnny.Chuang 2 siblings, 0 replies; 8+ messages in thread From: Johnny.Chuang @ 2020-03-06 7:46 UTC (permalink / raw) To: 'Peter Hutterer', 'Johnny Chuang' Cc: 'Dmitry Torokhov', 'Benjamin Tissoires', linux-kernel, linux-input, 'Jennifer Tsai', 'James Chen', 'Paul Liang', 'Jeff Chuang' > > > -----Original Message----- > > > From: Peter Hutterer [mailto:peter.hutterer@who-t.net] > > > Sent: Friday, February 28, 2020 6:36 AM > > > To: Johnny Chuang > > > Cc: Dmitry Torokhov; Benjamin Tissoires; > > > linux-kernel@vger.kernel.org; linux-input@vger.kernel.org; Johnny > > > Chuang; Jennifer Tsai; James Chen; Paul Liang; Jeff Chuang > > > Subject: Re: [PATCH] Input: elants_i2c - Report resolution > > > information for touch major > > > > > > On Thu, Feb 27, 2020 at 09:13:20AM +0800, Johnny Chuang wrote: > > > > From: Johnny Chuang <johnny.chuang@emc.com.tw> > > > > > > > > This patch supports reporting resolution for ABS_MT_TOUCH_MAJOR > > event. > > > > This information is needed in showing pressure/width radius. > > > > > > > > Signed-off-by: Johnny Chuang <johnny.chuang@emc.com.tw> > > > > --- > > > > drivers/input/touchscreen/elants_i2c.c | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > > diff --git a/drivers/input/touchscreen/elants_i2c.c > > > b/drivers/input/touchscreen/elants_i2c.c > > > > index 4911799..14c577c 100644 > > > > --- a/drivers/input/touchscreen/elants_i2c.c > > > > +++ b/drivers/input/touchscreen/elants_i2c.c > > > > @@ -1309,6 +1309,7 @@ static int elants_i2c_probe(struct > > > > i2c_client > > > *client, > > > > input_set_abs_params(ts->input, ABS_MT_PRESSURE, 0, 255, 0, 0); > > > > input_abs_set_res(ts->input, ABS_MT_POSITION_X, ts->x_res); > > > > input_abs_set_res(ts->input, ABS_MT_POSITION_Y, ts->y_res); > > > > + input_abs_set_res(ts->input, ABS_MT_TOUCH_MAJOR, 1); > > > > > > official resolution for absinfo is "units per mm", so a value of 3 > > > would mean 3mm, is that correct? > > > > Correct. > > This resolution (1 unit/mm) is for all elan I2C touchscreen devices, > > including the touchscreen devices in the future. > > This information is from our firmware members. > > Hi Peter / Benjamin, > Could you help to review and approve this patch? > Hi Peter / Benjamin, HP project Mordin mass production on 2020/3/10. ODM needs to upgrade new image with this patch to verify. Because ODM can not get the image link from Google, already delay verify schedule. Please help to review and approve this patch ASAP. Thank you very much. > > > > > > > > Not that it matters too much, since touch major is already all over > > > the place and needs userspace overrides for every device but it'd be > > > nice to at least make this useful out of the box on one device class. > > > > > > Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net> > > > > > > otherwise > > > > > > Cheers, > > > Peter > > > > > > > > > > > error = input_register_device(ts->input); > > > > if (error) { > > > > -- > > > > 2.7.4 > > > > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Input: elants_i2c - Report resolution information for touch major 2020-02-27 1:13 [PATCH] Input: elants_i2c - Report resolution information for touch major Johnny Chuang 2020-02-27 18:44 ` Harry Cutts 2020-02-27 22:36 ` Peter Hutterer @ 2020-03-06 17:45 ` Benjamin Tissoires 2020-03-06 18:05 ` Dmitry Torokhov 3 siblings, 0 replies; 8+ messages in thread From: Benjamin Tissoires @ 2020-03-06 17:45 UTC (permalink / raw) To: Johnny Chuang Cc: Dmitry Torokhov, Peter Hutterer, lkml, open list:HID CORE LAYER, Johnny Chuang, Jennifer Tsai, James Chen, Paul Liang, Jeff Chuang On Thu, Feb 27, 2020 at 2:13 AM Johnny Chuang <johnny.chuang.emc@gmail.com> wrote: > > From: Johnny Chuang <johnny.chuang@emc.com.tw> > > This patch supports reporting resolution for ABS_MT_TOUCH_MAJOR event. > This information is needed in showing pressure/width radius. > > Signed-off-by: Johnny Chuang <johnny.chuang@emc.com.tw> > --- Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> Cheers, Benjamin > drivers/input/touchscreen/elants_i2c.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/input/touchscreen/elants_i2c.c b/drivers/input/touchscreen/elants_i2c.c > index 4911799..14c577c 100644 > --- a/drivers/input/touchscreen/elants_i2c.c > +++ b/drivers/input/touchscreen/elants_i2c.c > @@ -1309,6 +1309,7 @@ static int elants_i2c_probe(struct i2c_client *client, > input_set_abs_params(ts->input, ABS_MT_PRESSURE, 0, 255, 0, 0); > input_abs_set_res(ts->input, ABS_MT_POSITION_X, ts->x_res); > input_abs_set_res(ts->input, ABS_MT_POSITION_Y, ts->y_res); > + input_abs_set_res(ts->input, ABS_MT_TOUCH_MAJOR, 1); > > error = input_register_device(ts->input); > if (error) { > -- > 2.7.4 > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Input: elants_i2c - Report resolution information for touch major 2020-02-27 1:13 [PATCH] Input: elants_i2c - Report resolution information for touch major Johnny Chuang ` (2 preceding siblings ...) 2020-03-06 17:45 ` Benjamin Tissoires @ 2020-03-06 18:05 ` Dmitry Torokhov 3 siblings, 0 replies; 8+ messages in thread From: Dmitry Torokhov @ 2020-03-06 18:05 UTC (permalink / raw) To: Johnny Chuang Cc: Benjamin Tissoires, Peter Hutterer, linux-kernel, linux-input, Johnny Chuang, Jennifer Tsai, James Chen, Paul Liang, Jeff Chuang On Thu, Feb 27, 2020 at 09:13:20AM +0800, Johnny Chuang wrote: > From: Johnny Chuang <johnny.chuang@emc.com.tw> > > This patch supports reporting resolution for ABS_MT_TOUCH_MAJOR event. > This information is needed in showing pressure/width radius. > > Signed-off-by: Johnny Chuang <johnny.chuang@emc.com.tw> Applied, thank you. > --- > drivers/input/touchscreen/elants_i2c.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/input/touchscreen/elants_i2c.c b/drivers/input/touchscreen/elants_i2c.c > index 4911799..14c577c 100644 > --- a/drivers/input/touchscreen/elants_i2c.c > +++ b/drivers/input/touchscreen/elants_i2c.c > @@ -1309,6 +1309,7 @@ static int elants_i2c_probe(struct i2c_client *client, > input_set_abs_params(ts->input, ABS_MT_PRESSURE, 0, 255, 0, 0); > input_abs_set_res(ts->input, ABS_MT_POSITION_X, ts->x_res); > input_abs_set_res(ts->input, ABS_MT_POSITION_Y, ts->y_res); > + input_abs_set_res(ts->input, ABS_MT_TOUCH_MAJOR, 1); > > error = input_register_device(ts->input); > if (error) { > -- > 2.7.4 > -- Dmitry ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-03-06 18:05 UTC | newest] Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-02-27 1:13 [PATCH] Input: elants_i2c - Report resolution information for touch major Johnny Chuang 2020-02-27 18:44 ` Harry Cutts 2020-02-27 22:36 ` Peter Hutterer 2020-03-02 8:14 ` Johnny.Chuang 2020-03-06 6:27 ` Johnny.Chuang 2020-03-06 7:46 ` Johnny.Chuang 2020-03-06 17:45 ` Benjamin Tissoires 2020-03-06 18:05 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).