linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: net: can: Document power-domains property
@ 2021-07-31  4:51 Aswath Govindraju
  2021-08-02  7:10 ` Marc Kleine-Budde
  2021-08-02  9:21 ` Aswath Govindraju
  0 siblings, 2 replies; 4+ messages in thread
From: Aswath Govindraju @ 2021-07-31  4:51 UTC (permalink / raw)
  Cc: Lokesh Vutla, Nishanth Menon, Kishon Vijay Abraham I,
	Vignesh Raghavendra, Aswath Govindraju,
	Chandrasekar Ramakrishnan, Wolfgang Grandegger,
	Marc Kleine-Budde, David S. Miller, Jakub Kicinski, Rob Herring,
	Sriram Dash, linux-can, netdev, devicetree, linux-kernel

Document power-domains property for adding the Power domain provider.

Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
---
 Documentation/devicetree/bindings/net/can/bosch,m_can.yaml | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
index a7b5807c5543..d633fe1da870 100644
--- a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
+++ b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
@@ -104,6 +104,13 @@ properties:
           maximum: 32
     maxItems: 1
 
+  power-domains:
+    description:
+      Power domain provider node and an args specifier containing
+      the can device id value. Please see,
+      Documentation/devicetree/bindings/soc/ti/sci-pm-domain.yaml
+    maxItems: 1
+
   can-transceiver:
     $ref: can-transceiver.yaml#
 
-- 
2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] dt-bindings: net: can: Document power-domains property
  2021-07-31  4:51 [PATCH] dt-bindings: net: can: Document power-domains property Aswath Govindraju
@ 2021-08-02  7:10 ` Marc Kleine-Budde
  2021-08-02  8:31   ` Aswath Govindraju
  2021-08-02  9:21 ` Aswath Govindraju
  1 sibling, 1 reply; 4+ messages in thread
From: Marc Kleine-Budde @ 2021-08-02  7:10 UTC (permalink / raw)
  To: Aswath Govindraju
  Cc: Lokesh Vutla, Nishanth Menon, Kishon Vijay Abraham I,
	Vignesh Raghavendra, Chandrasekar Ramakrishnan,
	Wolfgang Grandegger, David S. Miller, Jakub Kicinski,
	Rob Herring, Sriram Dash, linux-can, netdev, devicetree,
	linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1286 bytes --]

On 31.07.2021 10:21:38, Aswath Govindraju wrote:
> Document power-domains property for adding the Power domain provider.
> 
> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
> ---
>  Documentation/devicetree/bindings/net/can/bosch,m_can.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
> index a7b5807c5543..d633fe1da870 100644
> --- a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
> +++ b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
> @@ -104,6 +104,13 @@ properties:
>            maximum: 32
>      maxItems: 1
>  
> +  power-domains:
> +    description:
> +      Power domain provider node and an args specifier containing
> +      the can device id value. Please see,
> +      Documentation/devicetree/bindings/soc/ti/sci-pm-domain.yaml

Why are you referring to a TI specific file in a generic binding?

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] dt-bindings: net: can: Document power-domains property
  2021-08-02  7:10 ` Marc Kleine-Budde
@ 2021-08-02  8:31   ` Aswath Govindraju
  0 siblings, 0 replies; 4+ messages in thread
From: Aswath Govindraju @ 2021-08-02  8:31 UTC (permalink / raw)
  To: Marc Kleine-Budde
  Cc: Lokesh Vutla, Nishanth Menon, Kishon Vijay Abraham I,
	Vignesh Raghavendra, Chandrasekar Ramakrishnan,
	Wolfgang Grandegger, David S. Miller, Jakub Kicinski,
	Rob Herring, Sriram Dash, linux-can, netdev, devicetree,
	linux-kernel

Hi Marc,

On 02/08/21 12:40 pm, Marc Kleine-Budde wrote:
> On 31.07.2021 10:21:38, Aswath Govindraju wrote:
>> Document power-domains property for adding the Power domain provider.
>>
>> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
>> ---
>>  Documentation/devicetree/bindings/net/can/bosch,m_can.yaml | 7 +++++++
>>  1 file changed, 7 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
>> index a7b5807c5543..d633fe1da870 100644
>> --- a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
>> +++ b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
>> @@ -104,6 +104,13 @@ properties:
>>            maximum: 32
>>      maxItems: 1
>>  
>> +  power-domains:
>> +    description:
>> +      Power domain provider node and an args specifier containing
>> +      the can device id value. Please see,
>> +      Documentation/devicetree/bindings/soc/ti/sci-pm-domain.yaml
> 
> Why are you referring to a TI specific file in a generic binding?
> 

I was trying to refer to an example. If it shouldn't be referred then I
will remove it an post a post a respin.

Thanks,
Aswath

> Marc
> 


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] dt-bindings: net: can: Document power-domains property
  2021-07-31  4:51 [PATCH] dt-bindings: net: can: Document power-domains property Aswath Govindraju
  2021-08-02  7:10 ` Marc Kleine-Budde
@ 2021-08-02  9:21 ` Aswath Govindraju
  1 sibling, 0 replies; 4+ messages in thread
From: Aswath Govindraju @ 2021-08-02  9:21 UTC (permalink / raw)
  Cc: Lokesh Vutla, Nishanth Menon, Kishon Vijay Abraham I,
	Vignesh Raghavendra, Chandrasekar Ramakrishnan,
	Wolfgang Grandegger, Marc Kleine-Budde, David S. Miller,
	Jakub Kicinski, Rob Herring, Sriram Dash, linux-can, netdev,
	devicetree, linux-kernel

Hi all,

On 31/07/21 10:21 am, Aswath Govindraju wrote:
> Document power-domains property for adding the Power domain provider.
> 
> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
> ---

Posted respin v2[1] for this patch, after removing the reference in
description.

[1] - https://lore.kernel.org/patchwork/patch/1470806/

Thanks,
Aswath

>  Documentation/devicetree/bindings/net/can/bosch,m_can.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
> index a7b5807c5543..d633fe1da870 100644
> --- a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
> +++ b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
> @@ -104,6 +104,13 @@ properties:
>            maximum: 32
>      maxItems: 1
>  
> +  power-domains:
> +    description:
> +      Power domain provider node and an args specifier containing
> +      the can device id value. Please see,
> +      Documentation/devicetree/bindings/soc/ti/sci-pm-domain.yaml
> +    maxItems: 1
> +
>    can-transceiver:
>      $ref: can-transceiver.yaml#
>  
> 


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-08-02  9:21 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-31  4:51 [PATCH] dt-bindings: net: can: Document power-domains property Aswath Govindraju
2021-08-02  7:10 ` Marc Kleine-Budde
2021-08-02  8:31   ` Aswath Govindraju
2021-08-02  9:21 ` Aswath Govindraju

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).