* [PATCH] usb: Document clocks in samsung,exynos4210-ehci/ohci bindings
@ 2013-03-14 23:00 Doug Anderson
2013-03-15 1:30 ` Jingoo Han
2013-03-15 2:58 ` [PATCH v2] " Doug Anderson
0 siblings, 2 replies; 5+ messages in thread
From: Doug Anderson @ 2013-03-14 23:00 UTC (permalink / raw)
To: Kukjin Kim
Cc: Olof Johansson, Thomas Abraham, Vivek Gautam, Doug Anderson,
Grant Likely, Rob Herring, Rob Landley, Jingoo Han,
devicetree-discuss, linux-doc, linux-kernel
The exynox4210-ehci and exynos4210-ohci nodes need a clock specified
using the common clock framework. Document it.
Signed-off-by: Doug Anderson <dianders@chromium.org>
---
Documentation/devicetree/bindings/usb/exynos-usb.txt | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/Documentation/devicetree/bindings/usb/exynos-usb.txt b/Documentation/devicetree/bindings/usb/exynos-usb.txt
index f66fcdd..d557cf7 100644
--- a/Documentation/devicetree/bindings/usb/exynos-usb.txt
+++ b/Documentation/devicetree/bindings/usb/exynos-usb.txt
@@ -10,6 +10,8 @@ Required properties:
- reg: physical base address of the controller and length of memory mapped
region.
- interrupts: interrupt number to the cpu.
+ - clocks: from common clock binding: handle to adc clock.
+ - clock-names: from common clock binding: Shall be "usbhost".
Optional properties:
- samsung,vbus-gpio: if present, specifies the GPIO that
@@ -22,6 +24,9 @@ Example:
reg = <0x12110000 0x100>;
interrupts = <0 71 0>;
samsung,vbus-gpio = <&gpx2 6 1 3 3>;
+
+ clocks = <&clock 285>;
+ clock-names = "usbhost";
};
OHCI
@@ -31,10 +36,15 @@ Required properties:
- reg: physical base address of the controller and length of memory mapped
region.
- interrupts: interrupt number to the cpu.
+ - clocks: from common clock binding: handle to adc clock.
+ - clock-names: from common clock binding: Shall be "usbhost".
Example:
usb@12120000 {
compatible = "samsung,exynos4210-ohci";
reg = <0x12120000 0x100>;
interrupts = <0 71 0>;
+
+ clocks = <&clock 285>;
+ clock-names = "usbhost";
};
--
1.8.1.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] usb: Document clocks in samsung,exynos4210-ehci/ohci bindings
2013-03-14 23:00 [PATCH] usb: Document clocks in samsung,exynos4210-ehci/ohci bindings Doug Anderson
@ 2013-03-15 1:30 ` Jingoo Han
2013-03-15 2:58 ` [PATCH v2] " Doug Anderson
1 sibling, 0 replies; 5+ messages in thread
From: Jingoo Han @ 2013-03-15 1:30 UTC (permalink / raw)
To: 'Doug Anderson', 'Kukjin Kim'
Cc: 'Olof Johansson', 'Thomas Abraham',
'Vivek Gautam', 'Grant Likely',
'Rob Herring', 'Rob Landley',
devicetree-discuss, linux-doc, linux-kernel, 'Jingoo Han'
On Friday, March 15, 2013 8:01 AM, Doug Anderson wrote:
>
> The exynox4210-ehci and exynos4210-ohci nodes need a clock specified
> using the common clock framework. Document it.
>
> Signed-off-by: Doug Anderson <dianders@chromium.org>
> ---
> Documentation/devicetree/bindings/usb/exynos-usb.txt | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/exynos-usb.txt
> b/Documentation/devicetree/bindings/usb/exynos-usb.txt
> index f66fcdd..d557cf7 100644
> --- a/Documentation/devicetree/bindings/usb/exynos-usb.txt
> +++ b/Documentation/devicetree/bindings/usb/exynos-usb.txt
> @@ -10,6 +10,8 @@ Required properties:
> - reg: physical base address of the controller and length of memory mapped
> region.
> - interrupts: interrupt number to the cpu.
> + - clocks: from common clock binding: handle to adc clock.
^^^
Is it right? I think that 'adc' can be changed to 'usb host'.
Best regards,
Jingoo Han
> + - clock-names: from common clock binding: Shall be "usbhost".
>
> Optional properties:
> - samsung,vbus-gpio: if present, specifies the GPIO that
> @@ -22,6 +24,9 @@ Example:
> reg = <0x12110000 0x100>;
> interrupts = <0 71 0>;
> samsung,vbus-gpio = <&gpx2 6 1 3 3>;
> +
> + clocks = <&clock 285>;
> + clock-names = "usbhost";
> };
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] usb: Document clocks in samsung,exynos4210-ehci/ohci bindings
2013-03-14 23:00 [PATCH] usb: Document clocks in samsung,exynos4210-ehci/ohci bindings Doug Anderson
2013-03-15 1:30 ` Jingoo Han
@ 2013-03-15 2:58 ` Doug Anderson
2013-03-15 3:06 ` Jingoo Han
1 sibling, 1 reply; 5+ messages in thread
From: Doug Anderson @ 2013-03-15 2:58 UTC (permalink / raw)
To: Kukjin Kim
Cc: Olof Johansson, Thomas Abraham, Vivek Gautam, Doug Anderson,
Grant Likely, Rob Herring, Rob Landley, Jingoo Han,
devicetree-discuss, linux-doc, linux-kernel
The exynox4210-ehci and exynos4210-ohci nodes need a clock specified
using the common clock framework. Document it.
Signed-off-by: Doug Anderson <dianders@chromium.org>
---
Changes in v2:
- Fixed embarrassing typo adc=>usb. Thanks Jingoo!
Documentation/devicetree/bindings/usb/exynos-usb.txt | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/Documentation/devicetree/bindings/usb/exynos-usb.txt b/Documentation/devicetree/bindings/usb/exynos-usb.txt
index f66fcdd..b3abde7 100644
--- a/Documentation/devicetree/bindings/usb/exynos-usb.txt
+++ b/Documentation/devicetree/bindings/usb/exynos-usb.txt
@@ -10,6 +10,8 @@ Required properties:
- reg: physical base address of the controller and length of memory mapped
region.
- interrupts: interrupt number to the cpu.
+ - clocks: from common clock binding: handle to usb clock.
+ - clock-names: from common clock binding: Shall be "usbhost".
Optional properties:
- samsung,vbus-gpio: if present, specifies the GPIO that
@@ -22,6 +24,9 @@ Example:
reg = <0x12110000 0x100>;
interrupts = <0 71 0>;
samsung,vbus-gpio = <&gpx2 6 1 3 3>;
+
+ clocks = <&clock 285>;
+ clock-names = "usbhost";
};
OHCI
@@ -31,10 +36,15 @@ Required properties:
- reg: physical base address of the controller and length of memory mapped
region.
- interrupts: interrupt number to the cpu.
+ - clocks: from common clock binding: handle to usb clock.
+ - clock-names: from common clock binding: Shall be "usbhost".
Example:
usb@12120000 {
compatible = "samsung,exynos4210-ohci";
reg = <0x12120000 0x100>;
interrupts = <0 71 0>;
+
+ clocks = <&clock 285>;
+ clock-names = "usbhost";
};
--
1.8.1.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] usb: Document clocks in samsung,exynos4210-ehci/ohci bindings
2013-03-15 2:58 ` [PATCH v2] " Doug Anderson
@ 2013-03-15 3:06 ` Jingoo Han
2013-04-04 6:12 ` Kukjin Kim
0 siblings, 1 reply; 5+ messages in thread
From: Jingoo Han @ 2013-03-15 3:06 UTC (permalink / raw)
To: 'Doug Anderson', 'Kukjin Kim'
Cc: 'Olof Johansson', 'Thomas Abraham',
'Vivek Gautam', 'Grant Likely',
'Rob Herring', 'Rob Landley',
devicetree-discuss, linux-doc, linux-kernel, 'Jingoo Han'
On Friday, March 15, 2013 8:01 AM, Doug Anderson wrote:
>
> The exynox4210-ehci and exynos4210-ohci nodes need a clock specified
> using the common clock framework. Document it.
>
> Signed-off-by: Doug Anderson <dianders@chromium.org>
It looks good.
Acked-by: Jingoo Han <jg1.han@samsung.com>
Best regards,
Jingoo Han
> ---
> Changes in v2:
> - Fixed embarrassing typo adc=>usb. Thanks Jingoo!
>
> Documentation/devicetree/bindings/usb/exynos-usb.txt | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/exynos-usb.txt
> b/Documentation/devicetree/bindings/usb/exynos-usb.txt
> index f66fcdd..b3abde7 100644
> --- a/Documentation/devicetree/bindings/usb/exynos-usb.txt
> +++ b/Documentation/devicetree/bindings/usb/exynos-usb.txt
> @@ -10,6 +10,8 @@ Required properties:
> - reg: physical base address of the controller and length of memory mapped
> region.
> - interrupts: interrupt number to the cpu.
> + - clocks: from common clock binding: handle to usb clock.
> + - clock-names: from common clock binding: Shall be "usbhost".
>
> Optional properties:
> - samsung,vbus-gpio: if present, specifies the GPIO that
> @@ -22,6 +24,9 @@ Example:
> reg = <0x12110000 0x100>;
> interrupts = <0 71 0>;
> samsung,vbus-gpio = <&gpx2 6 1 3 3>;
> +
> + clocks = <&clock 285>;
> + clock-names = "usbhost";
> };
>
> OHCI
> @@ -31,10 +36,15 @@ Required properties:
> - reg: physical base address of the controller and length of memory mapped
> region.
> - interrupts: interrupt number to the cpu.
> + - clocks: from common clock binding: handle to usb clock.
> + - clock-names: from common clock binding: Shall be "usbhost".
>
> Example:
> usb@12120000 {
> compatible = "samsung,exynos4210-ohci";
> reg = <0x12120000 0x100>;
> interrupts = <0 71 0>;
> +
> + clocks = <&clock 285>;
> + clock-names = "usbhost";
> };
> --
> 1.8.1.3
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH v2] usb: Document clocks in samsung,exynos4210-ehci/ohci bindings
2013-03-15 3:06 ` Jingoo Han
@ 2013-04-04 6:12 ` Kukjin Kim
0 siblings, 0 replies; 5+ messages in thread
From: Kukjin Kim @ 2013-04-04 6:12 UTC (permalink / raw)
To: 'Jingoo Han', 'Doug Anderson'
Cc: 'Olof Johansson', 'Thomas Abraham',
'Vivek Gautam', 'Grant Likely',
'Rob Herring', 'Rob Landley',
devicetree-discuss, linux-doc, linux-kernel
Jingoo Han wrote:
>
> On Friday, March 15, 2013 8:01 AM, Doug Anderson wrote:
> >
> > The exynox4210-ehci and exynos4210-ohci nodes need a clock specified
> > using the common clock framework. Document it.
> >
> > Signed-off-by: Doug Anderson <dianders@chromium.org>
>
> It looks good.
> Acked-by: Jingoo Han <jg1.han@samsung.com>
>
>
Applied, thanks.
- Kukjin
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-04-04 6:13 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-03-14 23:00 [PATCH] usb: Document clocks in samsung,exynos4210-ehci/ohci bindings Doug Anderson
2013-03-15 1:30 ` Jingoo Han
2013-03-15 2:58 ` [PATCH v2] " Doug Anderson
2013-03-15 3:06 ` Jingoo Han
2013-04-04 6:12 ` Kukjin Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).