* [PATCH 1/2] ARM: dts: rockchip: add cpu opp table for rv1108
@ 2017-08-21 9:06 Andy Yan
2017-08-21 9:10 ` [PATCH 2/2] cpufreq: dt: add support for rockchip rv1108 Andy Yan
2017-08-21 15:30 ` [PATCH 1/2] ARM: dts: rockchip: add cpu opp table for rv1108 Heiko Stuebner
0 siblings, 2 replies; 7+ messages in thread
From: Andy Yan @ 2017-08-21 9:06 UTC (permalink / raw)
To: heiko; +Cc: devicetree, linux-kernel, linux-rockchip, robh+dt, Andy Yan
Add cpu opp table for rv1108 to support frequency
from 408MHZ to 1008MHZ.
Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
---
arch/arm/boot/dts/rv1108-evb.dts | 4 ++++
arch/arm/boot/dts/rv1108.dtsi | 9 +++++++++
2 files changed, 13 insertions(+)
diff --git a/arch/arm/boot/dts/rv1108-evb.dts b/arch/arm/boot/dts/rv1108-evb.dts
index 32fb09a..e517aa3 100644
--- a/arch/arm/boot/dts/rv1108-evb.dts
+++ b/arch/arm/boot/dts/rv1108-evb.dts
@@ -104,6 +104,10 @@
};
};
+&cpu0 {
+ cpu-supply = <&vdd_core>;
+};
+
&i2c0 {
status = "okay";
i2c-scl-rising-time-ns = <275>;
diff --git a/arch/arm/boot/dts/rv1108.dtsi b/arch/arm/boot/dts/rv1108.dtsi
index 064cec3..6ebf07c 100644
--- a/arch/arm/boot/dts/rv1108.dtsi
+++ b/arch/arm/boot/dts/rv1108.dtsi
@@ -69,6 +69,15 @@
device_type = "cpu";
compatible = "arm,cortex-a7";
reg = <0xf00>;
+ operating-points = <
+ /* KHz uV */
+ 408000 975000
+ 600000 975000
+ 816000 1025000
+ 1008000 1150000
+ >;
+ clock-latency = <40000>;
+ clocks = <&cru ARMCLK>;
};
};
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/2] cpufreq: dt: add support for rockchip rv1108
2017-08-21 9:06 [PATCH 1/2] ARM: dts: rockchip: add cpu opp table for rv1108 Andy Yan
@ 2017-08-21 9:10 ` Andy Yan
2017-08-22 22:54 ` Heiko Stuebner
2017-09-13 19:18 ` Viresh Kumar
2017-08-21 15:30 ` [PATCH 1/2] ARM: dts: rockchip: add cpu opp table for rv1108 Heiko Stuebner
1 sibling, 2 replies; 7+ messages in thread
From: Andy Yan @ 2017-08-21 9:10 UTC (permalink / raw)
To: rjw, viresh.kumar; +Cc: linux-kernel, linux-pm, heiko, Andy Yan
Add the compatible string to support the generic device tree
cpufreq-dt driver on rockchip rv1108 soc.
Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
---
drivers/cpufreq/cpufreq-dt-platdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c
index 1c26292..2d71c09 100644
--- a/drivers/cpufreq/cpufreq-dt-platdev.c
+++ b/drivers/cpufreq/cpufreq-dt-platdev.c
@@ -69,6 +69,7 @@ static const struct of_device_id machines[] __initconst = {
{ .compatible = "renesas,r8a7794", },
{ .compatible = "renesas,sh73a0", },
+ { .compatible = "rockchip,rv1108", },
{ .compatible = "rockchip,rk2928", },
{ .compatible = "rockchip,rk3036", },
{ .compatible = "rockchip,rk3066a", },
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] ARM: dts: rockchip: add cpu opp table for rv1108
2017-08-21 9:06 [PATCH 1/2] ARM: dts: rockchip: add cpu opp table for rv1108 Andy Yan
2017-08-21 9:10 ` [PATCH 2/2] cpufreq: dt: add support for rockchip rv1108 Andy Yan
@ 2017-08-21 15:30 ` Heiko Stuebner
1 sibling, 0 replies; 7+ messages in thread
From: Heiko Stuebner @ 2017-08-21 15:30 UTC (permalink / raw)
To: Andy Yan; +Cc: devicetree, linux-kernel, linux-rockchip, robh+dt
Hi Andy,
Am Montag, 21. August 2017, 17:06:44 CEST schrieb Andy Yan:
> Add cpu opp table for rv1108 to support frequency
> from 408MHZ to 1008MHZ.
>
> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
> ---
>
> arch/arm/boot/dts/rv1108-evb.dts | 4 ++++
> arch/arm/boot/dts/rv1108.dtsi | 9 +++++++++
> 2 files changed, 13 insertions(+)
>
> diff --git a/arch/arm/boot/dts/rv1108-evb.dts b/arch/arm/boot/dts/rv1108-evb.dts
> index 32fb09a..e517aa3 100644
> --- a/arch/arm/boot/dts/rv1108-evb.dts
> +++ b/arch/arm/boot/dts/rv1108-evb.dts
> @@ -104,6 +104,10 @@
> };
> };
>
> +&cpu0 {
> + cpu-supply = <&vdd_core>;
> +};
> +
please split into two patches (operating points + cpu-supply)
and use the operating-points-v2 binding.
Thanks
Heiko
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] cpufreq: dt: add support for rockchip rv1108
2017-08-21 9:10 ` [PATCH 2/2] cpufreq: dt: add support for rockchip rv1108 Andy Yan
@ 2017-08-22 22:54 ` Heiko Stuebner
2017-09-13 19:18 ` Viresh Kumar
1 sibling, 0 replies; 7+ messages in thread
From: Heiko Stuebner @ 2017-08-22 22:54 UTC (permalink / raw)
To: Andy Yan; +Cc: rjw, viresh.kumar, linux-kernel, linux-pm
Am Montag, 21. August 2017, 17:10:24 CEST schrieb Andy Yan:
> Add the compatible string to support the generic device tree
> cpufreq-dt driver on rockchip rv1108 soc.
>
> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] cpufreq: dt: add support for rockchip rv1108
2017-08-21 9:10 ` [PATCH 2/2] cpufreq: dt: add support for rockchip rv1108 Andy Yan
2017-08-22 22:54 ` Heiko Stuebner
@ 2017-09-13 19:18 ` Viresh Kumar
2017-09-14 0:52 ` Andy Yan
1 sibling, 1 reply; 7+ messages in thread
From: Viresh Kumar @ 2017-09-13 19:18 UTC (permalink / raw)
To: Andy Yan; +Cc: rjw, linux-kernel, linux-pm, heiko
On 21-08-17, 17:10, Andy Yan wrote:
> Add the compatible string to support the generic device tree
> cpufreq-dt driver on rockchip rv1108 soc.
>
> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
> ---
>
> drivers/cpufreq/cpufreq-dt-platdev.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c
> index 1c26292..2d71c09 100644
> --- a/drivers/cpufreq/cpufreq-dt-platdev.c
> +++ b/drivers/cpufreq/cpufreq-dt-platdev.c
> @@ -69,6 +69,7 @@ static const struct of_device_id machines[] __initconst = {
> { .compatible = "renesas,r8a7794", },
> { .compatible = "renesas,sh73a0", },
>
> + { .compatible = "rockchip,rv1108", },
> { .compatible = "rockchip,rk2928", },
> { .compatible = "rockchip,rk3036", },
> { .compatible = "rockchip,rk3066a", },
You use operating-points-v2 or the V1 bindings for this SoC? The SoCs using
operating-points-v2 don't need such changes anymore.
--
viresh
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] cpufreq: dt: add support for rockchip rv1108
2017-09-13 19:18 ` Viresh Kumar
@ 2017-09-14 0:52 ` Andy Yan
2017-09-19 18:48 ` Viresh Kumar
0 siblings, 1 reply; 7+ messages in thread
From: Andy Yan @ 2017-09-14 0:52 UTC (permalink / raw)
To: Viresh Kumar; +Cc: rjw, linux-kernel, linux-pm, heiko
Hi Viresh:
On 2017年09月14日 03:18, Viresh Kumar wrote:
> On 21-08-17, 17:10, Andy Yan wrote:
>> Add the compatible string to support the generic device tree
>> cpufreq-dt driver on rockchip rv1108 soc.
>>
>> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
>> ---
>>
>> drivers/cpufreq/cpufreq-dt-platdev.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c
>> index 1c26292..2d71c09 100644
>> --- a/drivers/cpufreq/cpufreq-dt-platdev.c
>> +++ b/drivers/cpufreq/cpufreq-dt-platdev.c
>> @@ -69,6 +69,7 @@ static const struct of_device_id machines[] __initconst = {
>> { .compatible = "renesas,r8a7794", },
>> { .compatible = "renesas,sh73a0", },
>>
>> + { .compatible = "rockchip,rv1108", },
>> { .compatible = "rockchip,rk2928", },
>> { .compatible = "rockchip,rk3036", },
>> { .compatible = "rockchip,rk3066a", },
> You use operating-points-v2 or the V1 bindings for this SoC? The SoCs using
> operating-points-v2 don't need such changes anymore.
Yes, I use operating-points-v2.
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] cpufreq: dt: add support for rockchip rv1108
2017-09-14 0:52 ` Andy Yan
@ 2017-09-19 18:48 ` Viresh Kumar
0 siblings, 0 replies; 7+ messages in thread
From: Viresh Kumar @ 2017-09-19 18:48 UTC (permalink / raw)
To: Andy Yan; +Cc: rjw, linux-kernel, linux-pm, heiko
On 14-09-17, 08:52, Andy Yan wrote:
> Yes, I use operating-points-v2.
Did you check with current mainline? It should work without this patches.
--
viresh
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-09-19 18:49 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-21 9:06 [PATCH 1/2] ARM: dts: rockchip: add cpu opp table for rv1108 Andy Yan
2017-08-21 9:10 ` [PATCH 2/2] cpufreq: dt: add support for rockchip rv1108 Andy Yan
2017-08-22 22:54 ` Heiko Stuebner
2017-09-13 19:18 ` Viresh Kumar
2017-09-14 0:52 ` Andy Yan
2017-09-19 18:48 ` Viresh Kumar
2017-08-21 15:30 ` [PATCH 1/2] ARM: dts: rockchip: add cpu opp table for rv1108 Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).