From: Chao Yu <chao2.yu@samsung.com>
To: "'Jaegeuk Kim'" <jaegeuk@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: RE: [f2fs-dev] [PATCH 2/2] f2fs: no need to lock for update_inode_page all the time
Date: Thu, 17 Sep 2015 20:19:06 +0800 [thread overview]
Message-ID: <009901d0f143$28f593b0$7ae0bb10$@samsung.com> (raw)
In-Reply-To: <1442336146-82492-2-git-send-email-jaegeuk@kernel.org>
Hi Jaegeuk,
> -----Original Message-----
> From: Jaegeuk Kim [mailto:jaegeuk@kernel.org]
> Sent: Wednesday, September 16, 2015 12:56 AM
> To: linux-kernel@vger.kernel.org; linux-fsdevel@vger.kernel.org;
> linux-f2fs-devel@lists.sourceforge.net
> Cc: Jaegeuk Kim
> Subject: [f2fs-dev] [PATCH 2/2] f2fs: no need to lock for update_inode_page all the time
>
> As comment says, we don't need to call f2fs_lock_op in write_inode to prevent
> from producing dirty node pages all the time.
> That happens only when there is not enough free sections and we can avoid that
> by calling balance_fs in prior to that.
>
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> ---
> fs/f2fs/inode.c | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c
> index 35aae65..0fc4d02 100644
> --- a/fs/f2fs/inode.c
> +++ b/fs/f2fs/inode.c
> @@ -296,16 +296,12 @@ int f2fs_write_inode(struct inode *inode, struct writeback_control *wbc)
> return 0;
>
> /*
> - * We need to lock here to prevent from producing dirty node pages
> + * We need to balance fs here to prevent from producing dirty node pages
> * during the urgent cleaning time when runing out of free sections.
> */
> - f2fs_lock_op(sbi);
> - update_inode_page(inode);
> - f2fs_unlock_op(sbi);
> -
> - if (wbc)
> - f2fs_balance_fs(sbi);
f2fs_balance_fs was moved here intentionally by Jin Xu in commit 92c4342fb72a
("f2fs: avoid writing inode redundantly when creating a file") to avoid
redundantly inode page submitting, I was confused since I didn't know all
history here. So, should we change the position of f2fs_balance_fs?
Thanks,
> + f2fs_balance_fs(sbi);
>
> + update_inode_page(inode);
> return 0;
> }
>
> --
> 2.1.1
>
>
> ------------------------------------------------------------------------------
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2015-09-17 12:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-15 16:55 [PATCH 1/2] f2fs: cover number of dirty node pages under node_write lock Jaegeuk Kim
2015-09-15 16:55 ` [PATCH 2/2] f2fs: no need to lock for update_inode_page all the time Jaegeuk Kim
2015-09-17 12:19 ` Chao Yu [this message]
2015-09-17 18:00 ` [f2fs-dev] " Jaegeuk Kim
2015-09-17 11:43 ` [f2fs-dev] [PATCH 1/2] f2fs: cover number of dirty node pages under node_write lock Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='009901d0f143$28f593b0$7ae0bb10$@samsung.com' \
--to=chao2.yu@samsung.com \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).