From: Marek Vasut <marek.vasut@gmail.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Boris Brezillon <boris.brezillon@free-electrons.com>,
Richard Weinberger <richard@nod.at>,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Cyrille Pitchen <cyrille.pitchen@atmel.com>
Cc: linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org
Subject: Re: [PATCH] mtd: nand: nandsim: fix error check
Date: Wed, 16 Nov 2016 17:56:22 +0100 [thread overview]
Message-ID: <009a3016-3fe9-bda0-feb7-7d2cc132b091@gmail.com> (raw)
In-Reply-To: <582C1041.7040809@gmail.com>
On 11/16/2016 08:52 AM, Sudip Mukherjee wrote:
> On Tuesday 15 November 2016 11:42 PM, Marek Vasut wrote:
>> On 11/16/2016 12:09 AM, Sudip Mukherjee wrote:
>>> debugfs_create_dir() and debugfs_create_file() returns NULL on error or
>>> a pointer on success. They do not return the error value with ERR_PTR.
>>> So we should not check the return with IS_ERR_OR_NULL, instead we
>>> should just check for NULL.
>>>
>>> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
>>> ---
>>> drivers/mtd/nand/nandsim.c | 9 +++------
>>> 1 file changed, 3 insertions(+), 6 deletions(-)
>>>
>>> diff --git a/drivers/mtd/nand/nandsim.c b/drivers/mtd/nand/nandsim.c
>>> index c76287a..9b0d79a 100644
>>> --- a/drivers/mtd/nand/nandsim.c
>>> +++ b/drivers/mtd/nand/nandsim.c
>>> @@ -525,15 +525,13 @@ static int nandsim_debugfs_create(struct
>>> nandsim *dev)
>>> {
>>> struct nandsim_debug_info *dbg = &dev->dbg;
>>> struct dentry *dent;
>>> - int err;
>>> + int err = -ENODEV;
>>
>> Why don't you just nuke the err altogether and just return -ENODEV ?
>
> That was the first version which i made and discarded before sending. I
> will go and find it now.
Why did you discard it ?
--
Best regards,
Marek Vasut
next prev parent reply other threads:[~2016-11-16 16:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-15 23:09 [PATCH] mtd: nand: nandsim: fix error check Sudip Mukherjee
2016-11-15 23:42 ` Marek Vasut
2016-11-16 7:52 ` Sudip Mukherjee
2016-11-16 16:56 ` Marek Vasut [this message]
2016-11-16 20:56 ` Sudip Mukherjee
2016-11-17 13:21 ` Marek Vasut
2016-11-17 17:22 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=009a3016-3fe9-bda0-feb7-7d2cc132b091@gmail.com \
--to=marek.vasut@gmail.com \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@atmel.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).