* [PATCH] Remove unselectable rule for arm-exynos-cpufreq.o
@ 2015-08-13 10:32 Jonas Rabenstein
2015-08-13 10:35 ` Viresh Kumar
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Jonas Rabenstein @ 2015-08-13 10:32 UTC (permalink / raw)
To: Rafael J. Wysocki", Viresh Kumar, linux-pm, linux-kernel
Cc: Jonas Rabenstein
With commit 2907ed4377d9 ("cpufreq: exynos: remove Exynos4x12 specific
cpufreq driver support"), the last specific Exynos-cpufreq driver
depending on ARM_EXYNOS_CPUFREQ was removed. As there is no
Exynos-specific cpufreq driver depending on the code in
drivers/cpufreq/exynos-cpufreq.c (selected by ARM_EXYNOS_CPUFREQ),
this file was deleted and ARM_EXYNOS_CPUFREQ removed from Kconfig.
After all, the rule in drivers/cpufreq/Makefile, to combine all
specific cpufreq drivers depending on the generic code for Exynos into
one objectfile is obsolete and can be removed.
Remove unselectable rule for arm-exynos-cpufreq.o from
drivers/cpufreq/Makefile, which - if selectable - would generate an
always empty objectfile.
Signed-off-by: Jonas Rabenstein <jonas.rabenstein@studium.uni-erlangen.de>
---
I found this inconsistency using the undertaker and
undertaker-checkpatch tools (https://undertaker.cs.fau.de/).
drivers/cpufreq/Makefile | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/cpufreq/Makefile b/drivers/cpufreq/Makefile
index bbc4a9f..958be2b 100644
--- a/drivers/cpufreq/Makefile
+++ b/drivers/cpufreq/Makefile
@@ -52,7 +52,6 @@ obj-$(CONFIG_ARM_DT_BL_CPUFREQ) += arm_big_little_dt.o
obj-$(CONFIG_ARCH_DAVINCI) += davinci-cpufreq.o
obj-$(CONFIG_UX500_SOC_DB8500) += dbx500-cpufreq.o
-obj-$(CONFIG_ARM_EXYNOS_CPUFREQ) += arm-exynos-cpufreq.o
obj-$(CONFIG_ARM_EXYNOS5440_CPUFREQ) += exynos5440-cpufreq.o
obj-$(CONFIG_ARM_HIGHBANK_CPUFREQ) += highbank-cpufreq.o
obj-$(CONFIG_ARM_HISI_ACPU_CPUFREQ) += hisi-acpu-cpufreq.o
--
2.5.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] Remove unselectable rule for arm-exynos-cpufreq.o
2015-08-13 10:32 [PATCH] Remove unselectable rule for arm-exynos-cpufreq.o Jonas Rabenstein
@ 2015-08-13 10:35 ` Viresh Kumar
2015-08-13 10:53 ` Krzysztof Kozlowski
2015-08-13 11:28 ` [PATCH v2] " Jonas Rabenstein
2 siblings, 0 replies; 8+ messages in thread
From: Viresh Kumar @ 2015-08-13 10:35 UTC (permalink / raw)
To: Jonas Rabenstein; +Cc: Rafael J. Wysocki", linux-pm, linux-kernel
On 13-08-15, 12:32, Jonas Rabenstein wrote:
> With commit 2907ed4377d9 ("cpufreq: exynos: remove Exynos4x12 specific
> cpufreq driver support"), the last specific Exynos-cpufreq driver
> depending on ARM_EXYNOS_CPUFREQ was removed. As there is no
> Exynos-specific cpufreq driver depending on the code in
> drivers/cpufreq/exynos-cpufreq.c (selected by ARM_EXYNOS_CPUFREQ),
> this file was deleted and ARM_EXYNOS_CPUFREQ removed from Kconfig.
> After all, the rule in drivers/cpufreq/Makefile, to combine all
> specific cpufreq drivers depending on the generic code for Exynos into
> one objectfile is obsolete and can be removed.
>
> Remove unselectable rule for arm-exynos-cpufreq.o from
> drivers/cpufreq/Makefile, which - if selectable - would generate an
> always empty objectfile.
>
> Signed-off-by: Jonas Rabenstein <jonas.rabenstein@studium.uni-erlangen.de>
> ---
> I found this inconsistency using the undertaker and
> undertaker-checkpatch tools (https://undertaker.cs.fau.de/).
>
> drivers/cpufreq/Makefile | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/cpufreq/Makefile b/drivers/cpufreq/Makefile
> index bbc4a9f..958be2b 100644
> --- a/drivers/cpufreq/Makefile
> +++ b/drivers/cpufreq/Makefile
> @@ -52,7 +52,6 @@ obj-$(CONFIG_ARM_DT_BL_CPUFREQ) += arm_big_little_dt.o
>
> obj-$(CONFIG_ARCH_DAVINCI) += davinci-cpufreq.o
> obj-$(CONFIG_UX500_SOC_DB8500) += dbx500-cpufreq.o
> -obj-$(CONFIG_ARM_EXYNOS_CPUFREQ) += arm-exynos-cpufreq.o
> obj-$(CONFIG_ARM_EXYNOS5440_CPUFREQ) += exynos5440-cpufreq.o
> obj-$(CONFIG_ARM_HIGHBANK_CPUFREQ) += highbank-cpufreq.o
> obj-$(CONFIG_ARM_HISI_ACPU_CPUFREQ) += hisi-acpu-cpufreq.o
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Remove unselectable rule for arm-exynos-cpufreq.o
2015-08-13 10:32 [PATCH] Remove unselectable rule for arm-exynos-cpufreq.o Jonas Rabenstein
2015-08-13 10:35 ` Viresh Kumar
@ 2015-08-13 10:53 ` Krzysztof Kozlowski
2015-08-13 10:58 ` Viresh Kumar
2015-08-13 11:28 ` [PATCH v2] " Jonas Rabenstein
2 siblings, 1 reply; 8+ messages in thread
From: Krzysztof Kozlowski @ 2015-08-13 10:53 UTC (permalink / raw)
To: Jonas Rabenstein; +Cc: Rafael J. Wysocki, Viresh Kumar, linux-pm, linux-kernel
2015-08-13 19:32 GMT+09:00 Jonas Rabenstein
<jonas.rabenstein@studium.uni-erlangen.de>:
> With commit 2907ed4377d9 ("cpufreq: exynos: remove Exynos4x12 specific
> cpufreq driver support"), the last specific Exynos-cpufreq driver
> depending on ARM_EXYNOS_CPUFREQ was removed. As there is no
> Exynos-specific cpufreq driver depending on the code in
> drivers/cpufreq/exynos-cpufreq.c (selected by ARM_EXYNOS_CPUFREQ),
> this file was deleted and ARM_EXYNOS_CPUFREQ removed from Kconfig.
> After all, the rule in drivers/cpufreq/Makefile, to combine all
> specific cpufreq drivers depending on the generic code for Exynos into
> one objectfile is obsolete and can be removed.
>
> Remove unselectable rule for arm-exynos-cpufreq.o from
> drivers/cpufreq/Makefile, which - if selectable - would generate an
> always empty objectfile.
That's a lot, really a lot of words, just to say that
ARM_EXYNOS_CPUFREQ option was removed and we should get rid of any
left-overs. The patch is of course valid... but could you trim this to
a short sentence giving the reason? Mentioned commit ID comes from
linux-next (or maintainer branch which may rebase) so it won't work
long-term. I think you can just leave the title of the commit.
When re-spinning:
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Viresh,
Do you want this to go through samsung-soc tree?
Best regards,
Krzysztof
>
> Signed-off-by: Jonas Rabenstein <jonas.rabenstein@studium.uni-erlangen.de>
> ---
> I found this inconsistency using the undertaker and
> undertaker-checkpatch tools (https://undertaker.cs.fau.de/).
>
> drivers/cpufreq/Makefile | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/cpufreq/Makefile b/drivers/cpufreq/Makefile
> index bbc4a9f..958be2b 100644
> --- a/drivers/cpufreq/Makefile
> +++ b/drivers/cpufreq/Makefile
> @@ -52,7 +52,6 @@ obj-$(CONFIG_ARM_DT_BL_CPUFREQ) += arm_big_little_dt.o
>
> obj-$(CONFIG_ARCH_DAVINCI) += davinci-cpufreq.o
> obj-$(CONFIG_UX500_SOC_DB8500) += dbx500-cpufreq.o
> -obj-$(CONFIG_ARM_EXYNOS_CPUFREQ) += arm-exynos-cpufreq.o
> obj-$(CONFIG_ARM_EXYNOS5440_CPUFREQ) += exynos5440-cpufreq.o
> obj-$(CONFIG_ARM_HIGHBANK_CPUFREQ) += highbank-cpufreq.o
> obj-$(CONFIG_ARM_HISI_ACPU_CPUFREQ) += hisi-acpu-cpufreq.o
> --
> 2.5.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Remove unselectable rule for arm-exynos-cpufreq.o
2015-08-13 10:53 ` Krzysztof Kozlowski
@ 2015-08-13 10:58 ` Viresh Kumar
0 siblings, 0 replies; 8+ messages in thread
From: Viresh Kumar @ 2015-08-13 10:58 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Jonas Rabenstein, Rafael J. Wysocki, linux-pm, linux-kernel
On 13-08-15, 19:53, Krzysztof Kozlowski wrote:
> 2015-08-13 19:32 GMT+09:00 Jonas Rabenstein
> <jonas.rabenstein@studium.uni-erlangen.de>:
> > With commit 2907ed4377d9 ("cpufreq: exynos: remove Exynos4x12 specific
> > cpufreq driver support"), the last specific Exynos-cpufreq driver
> > depending on ARM_EXYNOS_CPUFREQ was removed. As there is no
> > Exynos-specific cpufreq driver depending on the code in
> > drivers/cpufreq/exynos-cpufreq.c (selected by ARM_EXYNOS_CPUFREQ),
> > this file was deleted and ARM_EXYNOS_CPUFREQ removed from Kconfig.
> > After all, the rule in drivers/cpufreq/Makefile, to combine all
> > specific cpufreq drivers depending on the generic code for Exynos into
> > one objectfile is obsolete and can be removed.
> >
> > Remove unselectable rule for arm-exynos-cpufreq.o from
> > drivers/cpufreq/Makefile, which - if selectable - would generate an
> > always empty objectfile.
>
> That's a lot, really a lot of words, just to say that
> ARM_EXYNOS_CPUFREQ option was removed and we should get rid of any
> left-overs. The patch is of course valid... but could you trim this to
> a short sentence giving the reason? Mentioned commit ID comes from
> linux-next (or maintainer branch which may rebase) so it won't work
> long-term. I think you can just leave the title of the commit.
>
> When re-spinning:
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>
> Viresh,
> Do you want this to go through samsung-soc tree?
That's Rafael's call, but even he can't take it right now. This patch
has dependency on the samsung pull request. So it should go that way
only.
But if you are already late, then Rafael can apply this after 4.3-rc1
is out.
--
viresh
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2] Remove unselectable rule for arm-exynos-cpufreq.o
2015-08-13 10:32 [PATCH] Remove unselectable rule for arm-exynos-cpufreq.o Jonas Rabenstein
2015-08-13 10:35 ` Viresh Kumar
2015-08-13 10:53 ` Krzysztof Kozlowski
@ 2015-08-13 11:28 ` Jonas Rabenstein
2015-08-13 11:33 ` Viresh Kumar
2 siblings, 1 reply; 8+ messages in thread
From: Jonas Rabenstein @ 2015-08-13 11:28 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rafael J. Wysocki",
Viresh Kumar, linux-pm, linux-kernel, Jonas Rabenstein
Commit "cpufreq: exynos: remove Exynos4x12 specific cpufreq driver
support" deleted option ARM_EXYNOS_CPUFREQ but missed to delete a rule
in drivers/cpufreq/Makefile which depends on that option.
Remove unselectable rule for arm-exynos-cpufreq.o from
drivers/cpufreq/Makefile.
Signed-off-by: Jonas Rabenstein <jonas.rabenstein@studium.uni-erlangen.de>
---
I found this inconsistency using the undertaker and
undertaker-checkpatch tools (https://undertaker.cs.fau.de/).
drivers/cpufreq/Makefile | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/cpufreq/Makefile b/drivers/cpufreq/Makefile
index bbc4a9f..958be2b 100644
--- a/drivers/cpufreq/Makefile
+++ b/drivers/cpufreq/Makefile
@@ -52,7 +52,6 @@ obj-$(CONFIG_ARM_DT_BL_CPUFREQ) += arm_big_little_dt.o
obj-$(CONFIG_ARCH_DAVINCI) += davinci-cpufreq.o
obj-$(CONFIG_UX500_SOC_DB8500) += dbx500-cpufreq.o
-obj-$(CONFIG_ARM_EXYNOS_CPUFREQ) += arm-exynos-cpufreq.o
obj-$(CONFIG_ARM_EXYNOS5440_CPUFREQ) += exynos5440-cpufreq.o
obj-$(CONFIG_ARM_HIGHBANK_CPUFREQ) += highbank-cpufreq.o
obj-$(CONFIG_ARM_HISI_ACPU_CPUFREQ) += hisi-acpu-cpufreq.o
--
2.5.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2] Remove unselectable rule for arm-exynos-cpufreq.o
2015-08-13 11:28 ` [PATCH v2] " Jonas Rabenstein
@ 2015-08-13 11:33 ` Viresh Kumar
2015-08-13 11:39 ` Krzysztof Kozlowski
0 siblings, 1 reply; 8+ messages in thread
From: Viresh Kumar @ 2015-08-13 11:33 UTC (permalink / raw)
To: Jonas Rabenstein
Cc: Krzysztof Kozlowski, Rafael J. Wysocki", linux-pm, linux-kernel
On 13-08-15, 13:28, Jonas Rabenstein wrote:
> Commit "cpufreq: exynos: remove Exynos4x12 specific cpufreq driver
> support" deleted option ARM_EXYNOS_CPUFREQ but missed to delete a rule
> in drivers/cpufreq/Makefile which depends on that option.
>
> Remove unselectable rule for arm-exynos-cpufreq.o from
> drivers/cpufreq/Makefile.
>
> Signed-off-by: Jonas Rabenstein <jonas.rabenstein@studium.uni-erlangen.de>
> ---
> I found this inconsistency using the undertaker and
> undertaker-checkpatch tools (https://undertaker.cs.fau.de/).
>
> drivers/cpufreq/Makefile | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/cpufreq/Makefile b/drivers/cpufreq/Makefile
> index bbc4a9f..958be2b 100644
> --- a/drivers/cpufreq/Makefile
> +++ b/drivers/cpufreq/Makefile
> @@ -52,7 +52,6 @@ obj-$(CONFIG_ARM_DT_BL_CPUFREQ) += arm_big_little_dt.o
>
> obj-$(CONFIG_ARCH_DAVINCI) += davinci-cpufreq.o
> obj-$(CONFIG_UX500_SOC_DB8500) += dbx500-cpufreq.o
> -obj-$(CONFIG_ARM_EXYNOS_CPUFREQ) += arm-exynos-cpufreq.o
> obj-$(CONFIG_ARM_EXYNOS5440_CPUFREQ) += exynos5440-cpufreq.o
> obj-$(CONFIG_ARM_HIGHBANK_CPUFREQ) += highbank-cpufreq.o
> obj-$(CONFIG_ARM_HISI_ACPU_CPUFREQ) += hisi-acpu-cpufreq.o
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] Remove unselectable rule for arm-exynos-cpufreq.o
2015-08-13 11:33 ` Viresh Kumar
@ 2015-08-13 11:39 ` Krzysztof Kozlowski
2015-08-13 13:01 ` Kukjin Kim
0 siblings, 1 reply; 8+ messages in thread
From: Krzysztof Kozlowski @ 2015-08-13 11:39 UTC (permalink / raw)
To: Viresh Kumar, Kukjin Kim
Cc: Jonas Rabenstein, Krzysztof Kozlowski, Rafael J. Wysocki,
linux-pm, linux-kernel, linux-samsung-soc
2015-08-13 20:33 GMT+09:00 Viresh Kumar <viresh.kumar@linaro.org>:
> On 13-08-15, 13:28, Jonas Rabenstein wrote:
>> Commit "cpufreq: exynos: remove Exynos4x12 specific cpufreq driver
>> support" deleted option ARM_EXYNOS_CPUFREQ but missed to delete a rule
>> in drivers/cpufreq/Makefile which depends on that option.
>>
>> Remove unselectable rule for arm-exynos-cpufreq.o from
>> drivers/cpufreq/Makefile.
>>
>> Signed-off-by: Jonas Rabenstein <jonas.rabenstein@studium.uni-erlangen.de>
>> ---
>> I found this inconsistency using the undertaker and
>> undertaker-checkpatch tools (https://undertaker.cs.fau.de/).
>>
>> drivers/cpufreq/Makefile | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/cpufreq/Makefile b/drivers/cpufreq/Makefile
>> index bbc4a9f..958be2b 100644
>> --- a/drivers/cpufreq/Makefile
>> +++ b/drivers/cpufreq/Makefile
>> @@ -52,7 +52,6 @@ obj-$(CONFIG_ARM_DT_BL_CPUFREQ) += arm_big_little_dt.o
>>
>> obj-$(CONFIG_ARCH_DAVINCI) += davinci-cpufreq.o
>> obj-$(CONFIG_UX500_SOC_DB8500) += dbx500-cpufreq.o
>> -obj-$(CONFIG_ARM_EXYNOS_CPUFREQ) += arm-exynos-cpufreq.o
>> obj-$(CONFIG_ARM_EXYNOS5440_CPUFREQ) += exynos5440-cpufreq.o
>> obj-$(CONFIG_ARM_HIGHBANK_CPUFREQ) += highbank-cpufreq.o
>> obj-$(CONFIG_ARM_HISI_ACPU_CPUFREQ) += hisi-acpu-cpufreq.o
>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
And again from me:
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Dear Kukjin,
Can you take it and send in (updated) pull request with Exynos4x12
cpufreq patches?
BR,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH v2] Remove unselectable rule for arm-exynos-cpufreq.o
2015-08-13 11:39 ` Krzysztof Kozlowski
@ 2015-08-13 13:01 ` Kukjin Kim
0 siblings, 0 replies; 8+ messages in thread
From: Kukjin Kim @ 2015-08-13 13:01 UTC (permalink / raw)
To: 'Krzysztof Kozlowski', 'Viresh Kumar',
'Kukjin Kim'
Cc: 'Jonas Rabenstein', 'Rafael J. Wysocki',
linux-pm, linux-kernel, linux-samsung-soc
Krzysztof Kozlowski wrote:
>
> 2015-08-13 20:33 GMT+09:00 Viresh Kumar <viresh.kumar@linaro.org>:
> > On 13-08-15, 13:28, Jonas Rabenstein wrote:
> >> Commit "cpufreq: exynos: remove Exynos4x12 specific cpufreq driver
> >> support" deleted option ARM_EXYNOS_CPUFREQ but missed to delete a rule
> >> in drivers/cpufreq/Makefile which depends on that option.
> >>
> >> Remove unselectable rule for arm-exynos-cpufreq.o from
> >> drivers/cpufreq/Makefile.
> >>
> >> Signed-off-by: Jonas Rabenstein <jonas.rabenstein@studium.uni-erlangen.de>
> >> ---
> >> I found this inconsistency using the undertaker and
> >> undertaker-checkpatch tools (https://undertaker.cs.fau.de/).
> >>
> >> drivers/cpufreq/Makefile | 1 -
> >> 1 file changed, 1 deletion(-)
> >>
> >> diff --git a/drivers/cpufreq/Makefile b/drivers/cpufreq/Makefile
> >> index bbc4a9f..958be2b 100644
> >> --- a/drivers/cpufreq/Makefile
> >> +++ b/drivers/cpufreq/Makefile
> >> @@ -52,7 +52,6 @@ obj-$(CONFIG_ARM_DT_BL_CPUFREQ) += arm_big_little_dt.o
> >>
> >> obj-$(CONFIG_ARCH_DAVINCI) += davinci-cpufreq.o
> >> obj-$(CONFIG_UX500_SOC_DB8500) += dbx500-cpufreq.o
> >> -obj-$(CONFIG_ARM_EXYNOS_CPUFREQ) += arm-exynos-cpufreq.o
> >> obj-$(CONFIG_ARM_EXYNOS5440_CPUFREQ) += exynos5440-cpufreq.o
> >> obj-$(CONFIG_ARM_HIGHBANK_CPUFREQ) += highbank-cpufreq.o
> >> obj-$(CONFIG_ARM_HISI_ACPU_CPUFREQ) += hisi-acpu-cpufreq.o
> >
> > Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
>
> And again from me:
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>
> Dear Kukjin,
> Can you take it and send in (updated) pull request with Exynos4x12
> cpufreq patches?
>
OK, sure. I'll take this.
Thanks,
Kukjin
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2015-08-13 13:01 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-08-13 10:32 [PATCH] Remove unselectable rule for arm-exynos-cpufreq.o Jonas Rabenstein
2015-08-13 10:35 ` Viresh Kumar
2015-08-13 10:53 ` Krzysztof Kozlowski
2015-08-13 10:58 ` Viresh Kumar
2015-08-13 11:28 ` [PATCH v2] " Jonas Rabenstein
2015-08-13 11:33 ` Viresh Kumar
2015-08-13 11:39 ` Krzysztof Kozlowski
2015-08-13 13:01 ` Kukjin Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).