From: "Pavel Machek" <pavel@ucw.cz>
To: <Administrator@mangalore.zipworld.com.au>
Cc: <linux-kernel@vger.kernel.org>,
"Rusty trivial patch monkey Russell" <trivial@rustcorp.com.au>,
"Andrew Morton" <akpm@zip.com.au>
Subject: Re: 2.5isms
Date: Mon, 29 Mar 2004 16:40:13 +0100 [thread overview]
Message-ID: <00f301c415a4$208c9340$d100000a@sbs2003.local> (raw)
In-Reply-To: <20031230213050.GA3301@andromeda>
Hi!
> It seems I've found another 2.5ism. 2.6.0, arch/i386/kernel/dmi_scan.c
> has
>
> #ifdef CONFIG_SIMNOW
> /*
> * Skip on x86/64 with simnow. Will eventually go away
> * If you see this ifdef in 2.6pre mail me !
> */
> return -1;
> #endif
>
> I don't know whose file this is ..
>
> Also, 2.6.0 still has the previously mentioned problem in
> include/asm/io.h.
>
> Not subscribed, CC me.
This is obsolete x86-64 code... Please apply,
Pavel
--- tmp/linux/arch/i386/kernel/dmi_scan.c 2004-01-03 16:12:43.000000000 +0100
+++ linux/arch/i386/kernel/dmi_scan.c 2004-01-03 16:12:17.000000000 +0100
@@ -108,15 +108,7 @@
u8 buf[15];
u32 fp=0xF0000;
-#ifdef CONFIG_SIMNOW
- /*
- * Skip on x86/64 with simnow. Will eventually go away
- * If you see this ifdef in 2.6pre mail me !
- */
- return -1;
-#endif
-
- while( fp < 0xFFFFF)
+ while (fp < 0xFFFFF)
{
isa_memcpy_fromio(buf, fp, 15);
if(memcmp(buf, "_DMI_", 5)==0 && dmi_checksum(buf))
--
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
next prev parent reply other threads:[~2004-03-29 15:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-03 20:01 "Will be removed in 2.4" Justin Pryzby
2003-07-03 23:19 ` Jeff Garzik
2003-12-30 21:30 ` 2.5isms Justin Pryzby
2004-01-03 15:18 ` 2.5isms Pavel Machek
2004-01-07 7:28 ` 2.5isms Justin Pryzby
2004-03-29 15:40 ` Pavel Machek [this message]
2004-12-31 23:06 2.5isms Justin Pryzby
2005-01-01 2:34 ` 2.5isms Nick Piggin
2005-01-01 8:40 ` 2.5isms Arjan van de Ven
2005-01-01 9:13 ` 2.5isms Andi Kleen
2005-01-02 0:43 ` 2.5isms Nick Piggin
2005-01-02 8:58 ` 2.5isms Arjan van de Ven
2005-01-03 0:49 ` 2.5isms Nick Piggin
2005-01-02 12:04 ` 2.5isms Andi Kleen
2005-01-03 0:44 ` 2.5isms Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='00f301c415a4$208c9340$d100000a@sbs2003.local' \
--to=pavel@ucw.cz \
--cc=Administrator@mangalore.zipworld.com.au \
--cc=akpm@zip.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).