From: "Hillf Danton" <hillf.zj@alibaba-inc.com>
To: "Gustavo Padovan" <gustavo.padovan@collabora.co.uk>
Cc: "linux-kernel" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 05/13] staging/android: make sync_file_fdget() static
Date: Fri, 29 Apr 2016 16:48:51 +0800 [thread overview]
Message-ID: <00fd01d1a1f3$f48fe190$ddafa4b0$@alibaba-inc.com> (raw)
In-Reply-To: <00fc01d1a1f3$bed68630$3c839290$@alibaba-inc.com>
>
> From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
>
> There is no plan in the near future to use this function outside of this
> file so keep it as static.
>
> Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
Acked-by: Hillf Danton <hillf.zj@alibaba-inc.com>
> drivers/staging/android/sync.c | 3 +--
> drivers/staging/android/sync.h | 1 -
> 2 files changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/staging/android/sync.c b/drivers/staging/android/sync.c
> index e9bf251..7e0fa20 100644
> --- a/drivers/staging/android/sync.c
> +++ b/drivers/staging/android/sync.c
> @@ -212,7 +212,7 @@ EXPORT_SYMBOL(sync_file_create);
> * Ensures @fd references a valid sync_file, increments the refcount of the
> * backing file. Returns the sync_file or NULL in case of error.
> */
> -struct sync_file *sync_file_fdget(int fd)
> +static struct sync_file *sync_file_fdget(int fd)
> {
> struct file *file = fget(fd);
>
> @@ -228,7 +228,6 @@ err:
> fput(file);
> return NULL;
> }
> -EXPORT_SYMBOL(sync_file_fdget);
>
> static void sync_file_add_pt(struct sync_file *sync_file, int *i,
> struct fence *fence)
> diff --git a/drivers/staging/android/sync.h b/drivers/staging/android/sync.h
> index ffc6df6..1f164df 100644
> --- a/drivers/staging/android/sync.h
> +++ b/drivers/staging/android/sync.h
> @@ -168,7 +168,6 @@ void sync_timeline_signal(struct sync_timeline *obj);
> struct fence *sync_pt_create(struct sync_timeline *parent, int size);
>
> struct sync_file *sync_file_create(const char *name, struct fence *fence);
> -struct sync_file *sync_file_fdget(int fd);
>
> #ifdef CONFIG_DEBUG_FS
>
> --
> 2.5.5
>
>
next parent reply other threads:[~2016-04-29 8:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <00fc01d1a1f3$bed68630$3c839290$@alibaba-inc.com>
2016-04-29 8:48 ` Hillf Danton [this message]
2016-04-28 13:46 [PATCH v2 00/13] De-stage Sync File Framework Gustavo Padovan
2016-04-28 13:46 ` [PATCH v2 05/13] staging/android: make sync_file_fdget() static Gustavo Padovan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='00fd01d1a1f3$f48fe190$ddafa4b0$@alibaba-inc.com' \
--to=hillf.zj@alibaba-inc.com \
--cc=gustavo.padovan@collabora.co.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).