Re: [PATCH v2 05/13] staging/android: make sync_file_fdget() static

Re: [PATCH v2 05/13] staging/android: make sync_file_fdget() static

[Hillf Danton]

> 
> From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> 
> There is no plan in the near future to use this function outside of this
> file so keep it as static.
> 
> Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
Acked-by: Hillf Danton <hillf.zj@alibaba-inc.com>

>  drivers/staging/android/sync.c | 3 +--
>  drivers/staging/android/sync.h | 1 -
>  2 files changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/android/sync.c b/drivers/staging/android/sync.c
> index e9bf251..7e0fa20 100644
> --- a/drivers/staging/android/sync.c
> +++ b/drivers/staging/android/sync.c
> @@ -212,7 +212,7 @@ EXPORT_SYMBOL(sync_file_create);
>   * Ensures @fd references a valid sync_file, increments the refcount of the
>   * backing file. Returns the sync_file or NULL in case of error.
>   */
> -struct sync_file *sync_file_fdget(int fd)
> +static struct sync_file *sync_file_fdget(int fd)
>  {
>  	struct file *file = fget(fd);
> 
> @@ -228,7 +228,6 @@ err:
>  	fput(file);
>  	return NULL;
>  }
> -EXPORT_SYMBOL(sync_file_fdget);
> 
>  static void sync_file_add_pt(struct sync_file *sync_file, int *i,
>  			     struct fence *fence)
> diff --git a/drivers/staging/android/sync.h b/drivers/staging/android/sync.h
> index ffc6df6..1f164df 100644
> --- a/drivers/staging/android/sync.h
> +++ b/drivers/staging/android/sync.h
> @@ -168,7 +168,6 @@ void sync_timeline_signal(struct sync_timeline *obj);
>  struct fence *sync_pt_create(struct sync_timeline *parent, int size);
> 
>  struct sync_file *sync_file_create(const char *name, struct fence *fence);
> -struct sync_file *sync_file_fdget(int fd);
> 
>  #ifdef CONFIG_DEBUG_FS
> 
> --
> 2.5.5
> 
> 

[PATCH v2 05/13] staging/android: make sync_file_fdget() static

[Gustavo Padovan]

From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>

There is no plan in the near future to use this function outside of this
file so keep it as static.

Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
 drivers/staging/android/sync.c | 3 +--
 drivers/staging/android/sync.h | 1 -
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/staging/android/sync.c b/drivers/staging/android/sync.c
index e9bf251..7e0fa20 100644
--- a/drivers/staging/android/sync.c
+++ b/drivers/staging/android/sync.c
@@ -212,7 +212,7 @@ EXPORT_SYMBOL(sync_file_create);
  * Ensures @fd references a valid sync_file, increments the refcount of the
  * backing file. Returns the sync_file or NULL in case of error.
  */
-struct sync_file *sync_file_fdget(int fd)
+static struct sync_file *sync_file_fdget(int fd)
 {
 	struct file *file = fget(fd);
 
@@ -228,7 +228,6 @@ err:
 	fput(file);
 	return NULL;
 }
-EXPORT_SYMBOL(sync_file_fdget);
 
 static void sync_file_add_pt(struct sync_file *sync_file, int *i,
 			     struct fence *fence)
diff --git a/drivers/staging/android/sync.h b/drivers/staging/android/sync.h
index ffc6df6..1f164df 100644
--- a/drivers/staging/android/sync.h
+++ b/drivers/staging/android/sync.h
@@ -168,7 +168,6 @@ void sync_timeline_signal(struct sync_timeline *obj);
 struct fence *sync_pt_create(struct sync_timeline *parent, int size);
 
 struct sync_file *sync_file_create(const char *name, struct fence *fence);
-struct sync_file *sync_file_fdget(int fd);
 
 #ifdef CONFIG_DEBUG_FS
 
-- 
2.5.5