From: Christopher Lameter <cl@linux.com>
To: Baoquan He <bhe@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com,
akpm@linux-foundation.org
Subject: Re: [PATCH] slab: Clean up the code comment in slab kmem_cache struct
Date: Tue, 5 Jun 2018 17:04:17 +0000 [thread overview]
Message-ID: <01000163d0e8083c-096b06d6-7202-4ce2-b41c-0f33784afcda-000000@email.amazonses.com> (raw)
In-Reply-To: <20180603032402.27526-1-bhe@redhat.com>
On Sun, 3 Jun 2018, Baoquan He wrote:
> diff --git a/include/linux/slab_def.h b/include/linux/slab_def.h
> index d9228e4d0320..3485c58cfd1c 100644
> --- a/include/linux/slab_def.h
> +++ b/include/linux/slab_def.h
> @@ -67,9 +67,10 @@ struct kmem_cache {
>
> /*
> * If debugging is enabled, then the allocator can add additional
> - * fields and/or padding to every object. size contains the total
> - * object size including these internal fields, the following two
> - * variables contain the offset to the user object and its size.
> + * fields and/or padding to every object. 'size' contains the total
> + * object size including these internal fields, while 'obj_offset'
> + * and 'object_size' contain the offset to the user object and its
> + * size.
> */
> int obj_offset;
> #endif /* CONFIG_DEBUG_SLAB */
>
Wish we had some more consistent naming. object_size and obj_offset??? And
the fields better be as close together as possible.
Acked-by: Christoph Lameter <cl@linux.com>
next prev parent reply other threads:[~2018-06-05 17:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-03 3:24 [PATCH] slab: Clean up the code comment in slab kmem_cache struct Baoquan He
2018-06-05 17:04 ` Christopher Lameter [this message]
2018-06-06 1:26 ` Baoquan He
2018-06-06 23:48 ` Christopher Lameter
2018-06-08 2:04 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01000163d0e8083c-096b06d6-7202-4ce2-b41c-0f33784afcda-000000@email.amazonses.com \
--to=cl@linux.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).