* [PATCH] irq_work: Fix comment for irq_work_run()
@ 2019-12-09 14:34 Mukesh Ojha
0 siblings, 0 replies; 2+ messages in thread
From: Mukesh Ojha @ 2019-12-09 14:34 UTC (permalink / raw)
To: mingo, peterz, tglx, gregkh, linux-kernel; +Cc: Mukesh Ojha
hotplug_cfd() does not exist anymore, update the
comment for irq_work_run() with smpcfd_dying_cpu().
Signed-off-by: Mukesh Ojha <mojha@codeaurora.org>
---
kernel/irq_work.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/irq_work.c b/kernel/irq_work.c
index 828cc30..202a0d3 100644
--- a/kernel/irq_work.c
+++ b/kernel/irq_work.c
@@ -165,7 +165,7 @@ static void irq_work_run_list(struct llist_head *list)
/*
* hotplug calls this through:
- * hotplug_cfd() -> flush_smp_call_function_queue()
+ * smpcfd_dying_cpu() -> flush_smp_call_function_queue()
*/
void irq_work_run(void)
{
--
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center,
Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] irq_work: Fix comment for irq_work_run()
[not found] <0101016eeb1507c9-0db4e0b6-011c-4754-a34c-9ef0b078b23b-000000@us-west-2.amazonses.com>
@ 2020-01-16 0:38 ` Thomas Gleixner
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Gleixner @ 2020-01-16 0:38 UTC (permalink / raw)
To: Mukesh Ojha, mingo, peterz, gregkh, linux-kernel; +Cc: Mukesh Ojha
Mukesh Ojha <mojha@codeaurora.org> writes:
> hotplug_cfd() does not exist anymore, update the
> comment for irq_work_run() with smpcfd_dying_cpu().
That's only half of the truth. Just check the output of:
git grep irq_work_run
So even if the s/hotplug_cfd/smpcfd_dying_cpu/ change is correct, this
comment is actively misleading.
Thanks,
tglx
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-16 0:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-09 14:34 [PATCH] irq_work: Fix comment for irq_work_run() Mukesh Ojha
[not found] <0101016eeb1507c9-0db4e0b6-011c-4754-a34c-9ef0b078b23b-000000@us-west-2.amazonses.com>
2020-01-16 0:38 ` Thomas Gleixner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).