From: David Daney <ddaney@caviumnetworks.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: David Daney <david.daney@cavium.com>,
linux-mips@linux-mips.org, ralf@linux-mips.org,
James Hogan <james.hogan@mips.com>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-kernel@vger.kernel.org,
"Steven J. Hill" <steven.hill@cavium.com>,
devicetree@vger.kernel.org, Carlos Munoz <cmunoz@cavium.com>
Subject: Re: [PATCH 6/7] netdev: octeon-ethernet: Add Cavium Octeon III support.
Date: Thu, 2 Nov 2017 11:31:45 -0700 [thread overview]
Message-ID: <0168761e-cb18-e489-4689-8c9062aa316b@caviumnetworks.com> (raw)
In-Reply-To: <20171102165605.GJ24320@lunn.ch>
On 11/02/2017 09:56 AM, Andrew Lunn wrote:
>> OK, now I think I understand. Yes, the MAC can be hardwired to a switch.
>> In fact, there are system designs that do exactly that.
>>
>> We try to handle this case by not having a "phy-handle" property in the
>> device tree. The link to the remote device (switch IC in this case) is
>> brought up on ndo_open()
>
> O.K, so you totally ignore the Linux way of doing this and hack
> together your own proprietary solution.
I am going to add handling of the "phy-mode" property, but other than
that I don't know what the "Linux way" of specifying a hard MAC-to-MAC
connection with no intervening phy devices is. Wether the remote MAC is
a switch, or something else, would seem to be irrelevant. All we are
concerned about in this code is putting the thing into a state where
data flows in both directions through the MAC.
A pointer to an existing device tree binding for an Ethernet device that
has no (or an optional) phy device would be useful, we can try to do the
same.
>
>> There may be opportunities to improve how this works in the future, but the
>> current code is serviceable.
>
> It might be serviceable, but it will never get into mainline. For
> mainline, you need to use DSA.
>
> http://elixir.free-electrons.com/linux/v4.9.60/source/Documentation/networking/dsa/dsa.txt
I am truly at a loss here. That DSA document states:
Master network devices are regular, unmodified Linux
network device drivers for the CPU/management Ethernet
interface.
What modification do you suggest I make?
>
> Getting back to my original point, having these platform devices can
> cause issues for DSA. Freescale FMAN has a similar architecture, and
> it took a while to restructure it to make DSA work.
>
> https://www.spinics.net/lists/netdev/msg459394.html
>
> Andrew
>
next prev parent reply other threads:[~2017-11-02 18:31 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-02 0:35 [PATCH 0/7] Cavium OCTEON-III network driver David Daney
2017-11-02 0:36 ` [PATCH 1/7] dt-bindings: Add Cavium Octeon Common Ethernet Interface David Daney
2017-11-02 1:09 ` Florian Fainelli
2017-11-02 1:26 ` David Daney
2017-11-02 12:47 ` Andrew Lunn
2017-11-02 16:06 ` David Daney
2017-11-02 0:36 ` [PATCH 2/7] MIPS: Octeon: Enable LMTDMA/LMTST operations David Daney
2017-11-02 0:36 ` [PATCH 3/7] MIPS: Octeon: Add a global resource manager David Daney
2017-11-02 12:23 ` Andrew Lunn
2017-11-02 16:03 ` David Daney
2017-11-02 17:49 ` Florian Fainelli
2017-11-02 0:36 ` [PATCH 4/7] MIPS: Octeon: Add Free Pointer Unit (FPA) support David Daney
2017-11-02 3:29 ` Florian Fainelli
2017-11-02 16:27 ` David Daney
2017-11-02 18:04 ` Florian Fainelli
2017-11-02 19:12 ` David Daney
2017-11-02 13:14 ` James Hogan
2017-11-02 0:36 ` [PATCH 5/7] MIPS: Octeon: Automatically provision CVMSEG space David Daney
2017-11-05 7:45 ` kbuild test robot
2017-11-02 0:36 ` [PATCH 6/7] netdev: octeon-ethernet: Add Cavium Octeon III support David Daney
2017-11-02 12:43 ` Andrew Lunn
2017-11-02 15:55 ` David Daney
2017-11-02 16:10 ` Andrew Lunn
2017-11-02 16:37 ` David Daney
2017-11-02 16:56 ` Andrew Lunn
2017-11-02 18:31 ` David Daney [this message]
2017-11-02 18:53 ` Florian Fainelli
2017-11-02 19:13 ` Florian Fainelli
2017-11-02 22:45 ` David Daney
2017-11-03 15:48 ` Andrew Lunn
2017-11-02 0:36 ` [PATCH 7/7] MAINTAINERS: Add entry for drivers/net/ethernet/cavium/octeon/octeon3-* David Daney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0168761e-cb18-e489-4689-8c9062aa316b@caviumnetworks.com \
--to=ddaney@caviumnetworks.com \
--cc=andrew@lunn.ch \
--cc=cmunoz@cavium.com \
--cc=davem@davemloft.net \
--cc=david.daney@cavium.com \
--cc=devicetree@vger.kernel.org \
--cc=james.hogan@mips.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=robh+dt@kernel.org \
--cc=steven.hill@cavium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).