From: David Daney <ddaney@caviumnetworks.com>
To: Florian Fainelli <f.fainelli@gmail.com>,
David Daney <david.daney@cavium.com>,
linux-mips@linux-mips.org, ralf@linux-mips.org,
James Hogan <james.hogan@mips.com>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Cc: linux-kernel@vger.kernel.org,
"Steven J. Hill" <steven.hill@cavium.com>,
devicetree@vger.kernel.org, Carlos Munoz <cmunoz@cavium.com>
Subject: Re: [PATCH 4/7] MIPS: Octeon: Add Free Pointer Unit (FPA) support.
Date: Thu, 2 Nov 2017 09:27:01 -0700 [thread overview]
Message-ID: <fc2d71e2-cdd4-1cf8-13b0-ea462b5e7e75@caviumnetworks.com> (raw)
In-Reply-To: <d473b10c-ae5d-efa1-7329-de7b68152725@gmail.com>
On 11/01/2017 08:29 PM, Florian Fainelli wrote:
> Le 11/01/17 à 17:36, David Daney a écrit :
>> From: Carlos Munoz <cmunoz@cavium.com>
>>
>> From the hardware user manual: "The FPA is a unit that maintains
>> pools of pointers to free L2/DRAM memory. To provide QoS, the pools
>> are referenced indirectly through 1024 auras. Both core software
>> and hardware units allocate and free pointers."
>
> This looks like a possibly similar implement to what
> drivers/net/ethernet/marvell/mvneta_bm.c, can you see if you can make
> any use of genpool_* and include/net/hwbm.h here as well?
Yikes! Is it permitted to put function definitions that are not "static
inline" in header files?
The driver currently doesn't use page fragments, so I don't think that
the hwbm thing can be used.
Also the FPA unit is used to control RED and back pressure in the PKI
(packet input processor), which are features that are features not
considered in hwbm.
The OCTEON-III hardware also uses the FPA for non-packet-buffer memory
allocations. So for those, it seems that hwbm is also not a good fit.
David Daney
next prev parent reply other threads:[~2017-11-02 16:27 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-02 0:35 [PATCH 0/7] Cavium OCTEON-III network driver David Daney
2017-11-02 0:36 ` [PATCH 1/7] dt-bindings: Add Cavium Octeon Common Ethernet Interface David Daney
2017-11-02 1:09 ` Florian Fainelli
2017-11-02 1:26 ` David Daney
2017-11-02 12:47 ` Andrew Lunn
2017-11-02 16:06 ` David Daney
2017-11-02 0:36 ` [PATCH 2/7] MIPS: Octeon: Enable LMTDMA/LMTST operations David Daney
2017-11-02 0:36 ` [PATCH 3/7] MIPS: Octeon: Add a global resource manager David Daney
2017-11-02 12:23 ` Andrew Lunn
2017-11-02 16:03 ` David Daney
2017-11-02 17:49 ` Florian Fainelli
2017-11-02 0:36 ` [PATCH 4/7] MIPS: Octeon: Add Free Pointer Unit (FPA) support David Daney
2017-11-02 3:29 ` Florian Fainelli
2017-11-02 16:27 ` David Daney [this message]
2017-11-02 18:04 ` Florian Fainelli
2017-11-02 19:12 ` David Daney
2017-11-02 13:14 ` James Hogan
2017-11-02 0:36 ` [PATCH 5/7] MIPS: Octeon: Automatically provision CVMSEG space David Daney
2017-11-05 7:45 ` kbuild test robot
2017-11-02 0:36 ` [PATCH 6/7] netdev: octeon-ethernet: Add Cavium Octeon III support David Daney
2017-11-02 12:43 ` Andrew Lunn
2017-11-02 15:55 ` David Daney
2017-11-02 16:10 ` Andrew Lunn
2017-11-02 16:37 ` David Daney
2017-11-02 16:56 ` Andrew Lunn
2017-11-02 18:31 ` David Daney
2017-11-02 18:53 ` Florian Fainelli
2017-11-02 19:13 ` Florian Fainelli
2017-11-02 22:45 ` David Daney
2017-11-03 15:48 ` Andrew Lunn
2017-11-02 0:36 ` [PATCH 7/7] MAINTAINERS: Add entry for drivers/net/ethernet/cavium/octeon/octeon3-* David Daney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc2d71e2-cdd4-1cf8-13b0-ea462b5e7e75@caviumnetworks.com \
--to=ddaney@caviumnetworks.com \
--cc=cmunoz@cavium.com \
--cc=davem@davemloft.net \
--cc=david.daney@cavium.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=james.hogan@mips.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=robh+dt@kernel.org \
--cc=steven.hill@cavium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).