linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
To: Evan Green <evgreen@chromium.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-efi@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	Ard Biesheuvel <ardb@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	bhe@redhat.com, Petr Mladek <pmladek@suse.com>,
	kexec@lists.infradead.org, linux-hyperv@vger.kernel.org,
	netdev@vger.kernel.org, x86@kernel.org, kernel-dev@igalia.com,
	kernel@gpiccoli.net, halves@canonical.com, fabiomirmar@gmail.com,
	alejandro.j.jimenez@oracle.com,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Arnd Bergmann <arnd@arndb.de>, Borislav Petkov <bp@alien8.de>,
	Jonathan Corbet <corbet@lwn.net>,
	d.hatayama@jp.fujitsu.com, dave.hansen@linux.intel.com,
	dyoung@redhat.com, feng.tang@intel.com, mikelley@microsoft.com,
	hidehiro.kawai.ez@hitachi.com, jgross@suse.com,
	john.ogness@linutronix.de, Kees Cook <keescook@chromium.org>,
	luto@kernel.org, mhiramat@kernel.org, mingo@redhat.com,
	paulmck@kernel.org, peterz@infradead.org, rostedt@goodmis.org,
	senozhatsky@chromium.org, Alan Stern <stern@rowland.harvard.edu>,
	Thomas Gleixner <tglx@linutronix.de>,
	vgoyal@redhat.com, vkuznets@redhat.com,
	Will Deacon <will@kernel.org>, David Gow <davidgow@google.com>,
	Julius Werner <jwerner@chromium.org>
Subject: Re: [PATCH v2 03/13] firmware: google: Test spinlock on panic path to avoid lockups
Date: Mon, 8 Aug 2022 12:14:30 -0300	[thread overview]
Message-ID: <019ae735-3d69-cb4e-c003-b83cc8cd76f8@igalia.com> (raw)
In-Reply-To: <CAE=gft71vH+P3iAFXC0bLu0M2x2V4uJGWc82Xa+246ECuUdT-w@mail.gmail.com>

On 08/08/2022 02:07, Evan Green wrote:
> On Tue, Jul 19, 2022 at 12:55 PM Guilherme G. Piccoli
> <gpiccoli@igalia.com> wrote:
>>
>> Currently the gsmi driver registers a panic notifier as well as
>> reboot and die notifiers. The callbacks registered are called in
>> atomic and very limited context - for instance, panic disables
>> preemption and local IRQs, also all secondary CPUs (not executing
>> the panic path) are shutdown.
>>
>> With that said, taking a spinlock in this scenario is a dangerous
>> invitation for lockup scenarios. So, fix that by checking if the
>> spinlock is free to acquire in the panic notifier callback - if not,
>> bail-out and avoid a potential hang.
>>
>> Fixes: 74c5b31c6618 ("driver: Google EFI SMI")
>> Cc: Ard Biesheuvel <ardb@kernel.org>
>> Cc: David Gow <davidgow@google.com>
>> Cc: Evan Green <evgreen@chromium.org>
>> Cc: Julius Werner <jwerner@chromium.org>
>> Signed-off-by: Guilherme G. Piccoli <gpiccoli@igalia.com>
> 
> Reviewed-by: Evan Green <evgreen@chromium.org>

Thanks a bunch Evan!

Ard / Greg, do you think you could get this patch through your -next (or
-fixes) trees? Not sure which tree is the most common for picking GSMI
stuff.

I'm trying to get these fixes merged individually in their trees to not
stall the whole series and increase the burden of re-submitting.
Thanks in advance,


Guilherme

  reply	other threads:[~2022-08-08 15:15 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-19 19:53 [PATCH v2 00/13] The panic notifiers refactor strikes back - fixes/clean-ups Guilherme G. Piccoli
2022-07-19 19:53 ` [PATCH v2 01/13] ARM: Disable FIQs (but not IRQs) on CPUs shutdown paths Guilherme G. Piccoli
2022-08-07 15:35   ` Guilherme G. Piccoli
2022-07-19 19:53 ` [PATCH v2 02/13] notifier: Add panic notifiers info and purge trailing whitespaces Guilherme G. Piccoli
2022-08-03  9:21   ` Baoquan He
2022-07-19 19:53 ` [PATCH v2 03/13] firmware: google: Test spinlock on panic path to avoid lockups Guilherme G. Piccoli
2022-08-07 15:38   ` Guilherme G. Piccoli
2022-08-08  5:07   ` Evan Green
2022-08-08 15:14     ` Guilherme G. Piccoli [this message]
2022-08-08 15:26       ` Greg Kroah-Hartman
2022-08-08 15:37         ` Guilherme G. Piccoli
2022-08-10 12:54           ` Greg Kroah-Hartman
2022-07-19 19:53 ` [PATCH v2 04/13] soc: bcm: brcmstb: Document panic notifier action and remove useless header Guilherme G. Piccoli
2022-07-20 23:00   ` Florian Fainelli
2022-07-21 13:17     ` Guilherme G. Piccoli
2022-07-19 19:53 ` [PATCH v2 05/13] alpha: Clean-up the panic notifier code Guilherme G. Piccoli
2022-07-19 19:53 ` [PATCH v2 06/13] um: Improve panic notifiers consistency and ordering Guilherme G. Piccoli
2022-08-07 15:40   ` Guilherme G. Piccoli
2022-08-09 18:09     ` Johannes Berg
2022-08-09 19:03       ` Guilherme G. Piccoli
2022-08-09 19:08         ` Johannes Berg
2022-08-09 19:45           ` Guilherme G. Piccoli
2022-07-19 19:53 ` [PATCH v2 07/13] parisc: Replace regular spinlock with spin_trylock on panic path Guilherme G. Piccoli
2022-07-20  1:43   ` Jeroen Roovers
2022-07-21 13:19     ` Guilherme G. Piccoli
2022-07-21 13:45       ` Helge Deller
2022-07-21 14:00         ` Guilherme G. Piccoli
2022-07-19 19:53 ` [PATCH v2 08/13] tracing: Improve panic/die notifiers Guilherme G. Piccoli
2022-08-03  9:36   ` Baoquan He
2022-08-03  9:52     ` Baoquan He
2022-08-03 11:44       ` Guilherme G. Piccoli
2022-08-07 15:46   ` Guilherme G. Piccoli
2022-08-16 14:14   ` Steven Rostedt
2022-08-16 14:57     ` Alan Stern
2022-08-16 15:52       ` Steven Rostedt
2022-08-16 20:12         ` Guilherme G. Piccoli
2022-07-19 19:53 ` [PATCH v2 09/13] notifier: Show function names on notifier routines if DEBUG_NOTIFIERS is set Guilherme G. Piccoli
2022-07-19 20:33   ` Arjan van de Ven
2022-07-19 20:44     ` Guilherme G. Piccoli
2022-07-19 20:48       ` Arjan van de Ven
2022-07-19 21:00         ` Guilherme G. Piccoli
2022-07-19 22:04           ` Arjan van de Ven
2022-07-21 13:20             ` Guilherme G. Piccoli
2022-07-19 19:53 ` [PATCH v2 10/13] EDAC/altera: Skip the panic notifier if kdump is loaded Guilherme G. Piccoli
2022-08-07 15:48   ` Guilherme G. Piccoli
2022-08-16 18:44   ` Dinh Nguyen
2022-08-16 20:16     ` Guilherme G. Piccoli
2022-08-17 17:31   ` Borislav Petkov
2022-08-17 18:45     ` Guilherme G. Piccoli
2022-08-17 19:34       ` Borislav Petkov
2022-08-17 20:28         ` Guilherme G. Piccoli
2022-08-17 21:02           ` Borislav Petkov
2022-08-17 21:39             ` Guilherme G. Piccoli
2022-08-17 21:46               ` Borislav Petkov
2022-08-17 21:56                 ` Guilherme G. Piccoli
2022-08-17 22:00                   ` Borislav Petkov
2022-08-17 22:09                     ` Guilherme G. Piccoli
2022-08-17 22:19                       ` Borislav Petkov
2022-08-17 22:49                         ` Guilherme G. Piccoli
2022-07-19 19:53 ` [PATCH v2 11/13] video/hyperv_fb: Avoid taking busy spinlock on panic path Guilherme G. Piccoli
2022-07-25 18:09   ` Michael Kelley (LINUX)
2022-07-25 22:05     ` Guilherme G. Piccoli
2022-07-19 19:53 ` [PATCH v2 12/13] drivers/hv/vmbus, video/hyperv_fb: Untangle and refactor Hyper-V panic notifiers Guilherme G. Piccoli
2022-07-25 18:55   ` Michael Kelley (LINUX)
2022-07-19 19:53 ` [PATCH v2 13/13] panic: Fixes the panic_print NMI backtrace setting Guilherme G. Piccoli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=019ae735-3d69-cb4e-c003-b83cc8cd76f8@igalia.com \
    --to=gpiccoli@igalia.com \
    --cc=akpm@linux-foundation.org \
    --cc=alejandro.j.jimenez@oracle.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=ardb@kernel.org \
    --cc=arnd@arndb.de \
    --cc=bhe@redhat.com \
    --cc=bp@alien8.de \
    --cc=corbet@lwn.net \
    --cc=d.hatayama@jp.fujitsu.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=davidgow@google.com \
    --cc=dyoung@redhat.com \
    --cc=evgreen@chromium.org \
    --cc=fabiomirmar@gmail.com \
    --cc=feng.tang@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=halves@canonical.com \
    --cc=hidehiro.kawai.ez@hitachi.com \
    --cc=jgross@suse.com \
    --cc=john.ogness@linutronix.de \
    --cc=jwerner@chromium.org \
    --cc=keescook@chromium.org \
    --cc=kernel-dev@igalia.com \
    --cc=kernel@gpiccoli.net \
    --cc=kexec@lists.infradead.org \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-hyperv@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=mikelley@microsoft.com \
    --cc=mingo@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=paulmck@kernel.org \
    --cc=peterz@infradead.org \
    --cc=pmladek@suse.com \
    --cc=rostedt@goodmis.org \
    --cc=senozhatsky@chromium.org \
    --cc=stern@rowland.harvard.edu \
    --cc=tglx@linutronix.de \
    --cc=vgoyal@redhat.com \
    --cc=vkuznets@redhat.com \
    --cc=will@kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).