[PATCH] soc: qcom: remove unused label

[PATCH] soc: qcom: remove unused label

[Arnd Bergmann]

The newly added driver comes with a harmless warning:

drivers/soc/qcom/rmtfs_mem.c: In function 'qcom_rmtfs_mem_probe':
drivers/soc/qcom/rmtfs_mem.c:211:1: error: label 'remove_cdev' defined but not used [-Werror=unused-label]

This removes the unused label to avoid the warning.

Fixes: 702baebb8e00 ("soc: qcom: Remote filesystem memory driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/soc/qcom/rmtfs_mem.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/soc/qcom/rmtfs_mem.c b/drivers/soc/qcom/rmtfs_mem.c
index f6f2f0cb3b3a..ce35ff748adf 100644
--- a/drivers/soc/qcom/rmtfs_mem.c
+++ b/drivers/soc/qcom/rmtfs_mem.c
@@ -208,8 +208,6 @@ static int qcom_rmtfs_mem_probe(struct platform_device *pdev)
 
 	return 0;
 
-remove_cdev:
-	cdev_device_del(&rmtfs_mem->cdev, &rmtfs_mem->dev);
 put_device:
 	put_device(&rmtfs_mem->dev);
 
-- 
2.9.0

Re: [PATCH] soc: qcom: remove unused label

[Arnd Bergmann]

On Wed, Oct 18, 2017 at 10:30 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> The newly added driver comes with a harmless warning:
>
> drivers/soc/qcom/rmtfs_mem.c: In function 'qcom_rmtfs_mem_probe':
> drivers/soc/qcom/rmtfs_mem.c:211:1: error: label 'remove_cdev' defined but not used [-Werror=unused-label]
>
> This removes the unused label to avoid the warning.
>
> Fixes: 702baebb8e00 ("soc: qcom: Remote filesystem memory driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

I just noticed that the build bots now show the warning
arm-soc/next/drivers, so I've
applied my patch on top of that branch.

       Arnd

Re: [PATCH] soc: qcom: remove unused label

[Alex Elder]

On 10/18/2017 03:30 AM, Arnd Bergmann wrote:
> The newly added driver comes with a harmless warning:
> 
> drivers/soc/qcom/rmtfs_mem.c: In function 'qcom_rmtfs_mem_probe':
> drivers/soc/qcom/rmtfs_mem.c:211:1: error: label 'remove_cdev' defined but not used [-Werror=unused-label]
> 
> This removes the unused label to avoid the warning.
> 
> Fixes: 702baebb8e00 ("soc: qcom: Remote filesystem memory driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Looks good.

Reviewed-by: Alex Elder <elder@linaro.org>

> ---
>  drivers/soc/qcom/rmtfs_mem.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/soc/qcom/rmtfs_mem.c b/drivers/soc/qcom/rmtfs_mem.c
> index f6f2f0cb3b3a..ce35ff748adf 100644
> --- a/drivers/soc/qcom/rmtfs_mem.c
> +++ b/drivers/soc/qcom/rmtfs_mem.c
> @@ -208,8 +208,6 @@ static int qcom_rmtfs_mem_probe(struct platform_device *pdev)
>  
>  	return 0;
>  
> -remove_cdev:
> -	cdev_device_del(&rmtfs_mem->cdev, &rmtfs_mem->dev);
>  put_device:
>  	put_device(&rmtfs_mem->dev);
>  
> 

Re: [PATCH] soc: qcom: remove unused label

[Bjorn Andersson]

On Fri 03 Nov 05:25 PDT 2017, Arnd Bergmann wrote:

> On Wed, Oct 18, 2017 at 10:30 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> > The newly added driver comes with a harmless warning:
> >
> > drivers/soc/qcom/rmtfs_mem.c: In function 'qcom_rmtfs_mem_probe':
> > drivers/soc/qcom/rmtfs_mem.c:211:1: error: label 'remove_cdev' defined but not used [-Werror=unused-label]
> >
> > This removes the unused label to avoid the warning.
> >
> > Fixes: 702baebb8e00 ("soc: qcom: Remote filesystem memory driver")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> 
> I just noticed that the build bots now show the warning
> arm-soc/next/drivers, so I've
> applied my patch on top of that branch.
> 

Okay, that sounds good. Sorry for missing your previous email.

I apparently got that snippet sqaushed into the wrong commit, will add
it back when I post the follow-up patch needing it.

Regards,
Bjorn