* [PATCH 0/3] drm: Use tabs for code indents @ 2021-04-21 19:42 Beatriz Martins de Carvalho 2021-04-21 19:42 ` [PATCH 1/3] drm: drm_atomic_uapi.c: " Beatriz Martins de Carvalho ` (2 more replies) 0 siblings, 3 replies; 5+ messages in thread From: Beatriz Martins de Carvalho @ 2021-04-21 19:42 UTC (permalink / raw) To: maarten.lankhorst, mripard, tzimmermann, airlied, daniel Cc: melissa.srw, dri-devel, linux-kernel, outreachy-kernel Remove space and use tabs for indent the code to follow the Linux kernel coding conventions. Problem found by checkpatch Beatriz Martins de Carvalho (3): drm: drm_atomic_uapi.c: Use tabs for code indents drm: drm_blend.c: Use tabs for code indents drm: drm_connector.c: Use tabs for code indents drivers/gpu/drm/drm_atomic_uapi.c | 6 ++--- drivers/gpu/drm/drm_blend.c | 4 ++-- drivers/gpu/drm/drm_connector.c | 38 +++++++++++++++---------------- 3 files changed, 24 insertions(+), 24 deletions(-) -- 2.25.1 ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/3] drm: drm_atomic_uapi.c: Use tabs for code indents 2021-04-21 19:42 [PATCH 0/3] drm: Use tabs for code indents Beatriz Martins de Carvalho @ 2021-04-21 19:42 ` Beatriz Martins de Carvalho 2021-04-21 19:42 ` [PATCH 2/3] drm: drm_blend.c: " Beatriz Martins de Carvalho 2021-04-21 19:42 ` [PATCH 3/3] drm: drm_connector.c: " Beatriz Martins de Carvalho 2 siblings, 0 replies; 5+ messages in thread From: Beatriz Martins de Carvalho @ 2021-04-21 19:42 UTC (permalink / raw) To: maarten.lankhorst, mripard, tzimmermann, airlied, daniel Cc: melissa.srw, dri-devel, linux-kernel, outreachy-kernel Remove space and use tabs for indent the code to follow the Linux kernel coding conventions. Problem found by checkpatch. Signed-off-by: Beatriz Martins de Carvalho <martinsdecarvalhobeatriz@gmail.com> --- drivers/gpu/drm/drm_atomic_uapi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_atomic_uapi.c b/drivers/gpu/drm/drm_atomic_uapi.c index 268bb69c2e2f..438e9585b225 100644 --- a/drivers/gpu/drm/drm_atomic_uapi.c +++ b/drivers/gpu/drm/drm_atomic_uapi.c @@ -78,8 +78,8 @@ int drm_atomic_set_mode_for_crtc(struct drm_crtc_state *state, drm_mode_convert_to_umode(&umode, mode); state->mode_blob = drm_property_create_blob(state->crtc->dev, - sizeof(umode), - &umode); + sizeof(umode), + &umode); if (IS_ERR(state->mode_blob)) return PTR_ERR(state->mode_blob); @@ -114,7 +114,7 @@ EXPORT_SYMBOL(drm_atomic_set_mode_for_crtc); * Zero on success, error code on failure. Cannot return -EDEADLK. */ int drm_atomic_set_mode_prop_for_crtc(struct drm_crtc_state *state, - struct drm_property_blob *blob) + struct drm_property_blob *blob) { struct drm_crtc *crtc = state->crtc; -- 2.25.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/3] drm: drm_blend.c: Use tabs for code indents 2021-04-21 19:42 [PATCH 0/3] drm: Use tabs for code indents Beatriz Martins de Carvalho 2021-04-21 19:42 ` [PATCH 1/3] drm: drm_atomic_uapi.c: " Beatriz Martins de Carvalho @ 2021-04-21 19:42 ` Beatriz Martins de Carvalho 2021-04-21 19:42 ` [PATCH 3/3] drm: drm_connector.c: " Beatriz Martins de Carvalho 2 siblings, 0 replies; 5+ messages in thread From: Beatriz Martins de Carvalho @ 2021-04-21 19:42 UTC (permalink / raw) To: maarten.lankhorst, mripard, tzimmermann, airlied, daniel Cc: melissa.srw, dri-devel, linux-kernel, outreachy-kernel Remove space and use tabs for indent the code to follow the Linux kernel coding conventions. Problem found by checkpatch. Signed-off-by: Beatriz Martins de Carvalho <martinsdecarvalhobeatriz@gmail.com> --- drivers/gpu/drm/drm_blend.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_blend.c b/drivers/gpu/drm/drm_blend.c index 26e2f2ffd255..ec37cbfabb50 100644 --- a/drivers/gpu/drm/drm_blend.c +++ b/drivers/gpu/drm/drm_blend.c @@ -328,8 +328,8 @@ unsigned int drm_rotation_simplify(unsigned int rotation, if (rotation & ~supported_rotations) { rotation ^= DRM_MODE_REFLECT_X | DRM_MODE_REFLECT_Y; rotation = (rotation & DRM_MODE_REFLECT_MASK) | - BIT((ffs(rotation & DRM_MODE_ROTATE_MASK) + 1) - % 4); + BIT((ffs(rotation & DRM_MODE_ROTATE_MASK) + 1) + % 4); } return rotation; -- 2.25.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 3/3] drm: drm_connector.c: Use tabs for code indents 2021-04-21 19:42 [PATCH 0/3] drm: Use tabs for code indents Beatriz Martins de Carvalho 2021-04-21 19:42 ` [PATCH 1/3] drm: drm_atomic_uapi.c: " Beatriz Martins de Carvalho 2021-04-21 19:42 ` [PATCH 2/3] drm: drm_blend.c: " Beatriz Martins de Carvalho @ 2021-04-21 19:42 ` Beatriz Martins de Carvalho 2021-04-22 8:47 ` Daniel Vetter 2 siblings, 1 reply; 5+ messages in thread From: Beatriz Martins de Carvalho @ 2021-04-21 19:42 UTC (permalink / raw) To: maarten.lankhorst, mripard, tzimmermann, airlied, daniel Cc: melissa.srw, dri-devel, linux-kernel, outreachy-kernel Remove space and use tabs for indent the code to follow the Linux kernel coding conventions. Problem found by checkpatch Signed-off-by: Beatriz Martins de Carvalho <martinsdecarvalhobeatriz@gmail.com> --- drivers/gpu/drm/drm_connector.c | 38 ++++++++++++++++----------------- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c index 7631f76e7f34..38600c3a6ab2 100644 --- a/drivers/gpu/drm/drm_connector.c +++ b/drivers/gpu/drm/drm_connector.c @@ -1958,11 +1958,11 @@ int drm_connector_set_path_property(struct drm_connector *connector, int ret; ret = drm_property_replace_global_blob(dev, - &connector->path_blob_ptr, - strlen(path) + 1, - path, - &connector->base, - dev->mode_config.path_property); + &connector->path_blob_ptr, + strlen(path) + 1, + path, + &connector->base, + dev->mode_config.path_property); return ret; } EXPORT_SYMBOL(drm_connector_set_path_property); @@ -1988,11 +1988,11 @@ int drm_connector_set_tile_property(struct drm_connector *connector) if (!connector->has_tile) { ret = drm_property_replace_global_blob(dev, - &connector->tile_blob_ptr, - 0, - NULL, - &connector->base, - dev->mode_config.tile_property); + &connector->tile_blob_ptr, + 0, + NULL, + &connector->base, + dev->mode_config.tile_property); return ret; } @@ -2003,11 +2003,11 @@ int drm_connector_set_tile_property(struct drm_connector *connector) connector->tile_h_size, connector->tile_v_size); ret = drm_property_replace_global_blob(dev, - &connector->tile_blob_ptr, - strlen(tile) + 1, - tile, - &connector->base, - dev->mode_config.tile_property); + &connector->tile_blob_ptr, + strlen(tile) + 1, + tile, + &connector->base, + dev->mode_config.tile_property); return ret; } EXPORT_SYMBOL(drm_connector_set_tile_property); @@ -2076,10 +2076,10 @@ int drm_connector_update_edid_property(struct drm_connector *connector, ret = drm_property_replace_global_blob(dev, &connector->edid_blob_ptr, - size, - edid, - &connector->base, - dev->mode_config.edid_property); + size, + edid, + &connector->base, + dev->mode_config.edid_property); if (ret) return ret; return drm_connector_set_tile_property(connector); -- 2.25.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 3/3] drm: drm_connector.c: Use tabs for code indents 2021-04-21 19:42 ` [PATCH 3/3] drm: drm_connector.c: " Beatriz Martins de Carvalho @ 2021-04-22 8:47 ` Daniel Vetter 0 siblings, 0 replies; 5+ messages in thread From: Daniel Vetter @ 2021-04-22 8:47 UTC (permalink / raw) To: Beatriz Martins de Carvalho Cc: maarten.lankhorst, mripard, tzimmermann, airlied, daniel, melissa.srw, dri-devel, linux-kernel, outreachy-kernel On Wed, Apr 21, 2021 at 08:42:49PM +0100, Beatriz Martins de Carvalho wrote: > Remove space and use tabs for indent the code to follow the > Linux kernel coding conventions. > Problem found by checkpatch > > Signed-off-by: Beatriz Martins de Carvalho <martinsdecarvalhobeatriz@gmail.com> Both of your patch sets applied to drm-misc-next for 5.14, thanks a lot. -Daniel > --- > drivers/gpu/drm/drm_connector.c | 38 ++++++++++++++++----------------- > 1 file changed, 19 insertions(+), 19 deletions(-) > > diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c > index 7631f76e7f34..38600c3a6ab2 100644 > --- a/drivers/gpu/drm/drm_connector.c > +++ b/drivers/gpu/drm/drm_connector.c > @@ -1958,11 +1958,11 @@ int drm_connector_set_path_property(struct drm_connector *connector, > int ret; > > ret = drm_property_replace_global_blob(dev, > - &connector->path_blob_ptr, > - strlen(path) + 1, > - path, > - &connector->base, > - dev->mode_config.path_property); > + &connector->path_blob_ptr, > + strlen(path) + 1, > + path, > + &connector->base, > + dev->mode_config.path_property); > return ret; > } > EXPORT_SYMBOL(drm_connector_set_path_property); > @@ -1988,11 +1988,11 @@ int drm_connector_set_tile_property(struct drm_connector *connector) > > if (!connector->has_tile) { > ret = drm_property_replace_global_blob(dev, > - &connector->tile_blob_ptr, > - 0, > - NULL, > - &connector->base, > - dev->mode_config.tile_property); > + &connector->tile_blob_ptr, > + 0, > + NULL, > + &connector->base, > + dev->mode_config.tile_property); > return ret; > } > > @@ -2003,11 +2003,11 @@ int drm_connector_set_tile_property(struct drm_connector *connector) > connector->tile_h_size, connector->tile_v_size); > > ret = drm_property_replace_global_blob(dev, > - &connector->tile_blob_ptr, > - strlen(tile) + 1, > - tile, > - &connector->base, > - dev->mode_config.tile_property); > + &connector->tile_blob_ptr, > + strlen(tile) + 1, > + tile, > + &connector->base, > + dev->mode_config.tile_property); > return ret; > } > EXPORT_SYMBOL(drm_connector_set_tile_property); > @@ -2076,10 +2076,10 @@ int drm_connector_update_edid_property(struct drm_connector *connector, > > ret = drm_property_replace_global_blob(dev, > &connector->edid_blob_ptr, > - size, > - edid, > - &connector->base, > - dev->mode_config.edid_property); > + size, > + edid, > + &connector->base, > + dev->mode_config.edid_property); > if (ret) > return ret; > return drm_connector_set_tile_property(connector); > -- > 2.25.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-04-22 8:47 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-04-21 19:42 [PATCH 0/3] drm: Use tabs for code indents Beatriz Martins de Carvalho 2021-04-21 19:42 ` [PATCH 1/3] drm: drm_atomic_uapi.c: " Beatriz Martins de Carvalho 2021-04-21 19:42 ` [PATCH 2/3] drm: drm_blend.c: " Beatriz Martins de Carvalho 2021-04-21 19:42 ` [PATCH 3/3] drm: drm_connector.c: " Beatriz Martins de Carvalho 2021-04-22 8:47 ` Daniel Vetter
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).