From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Pavel Machek <pavel@denx.de>,
stable@kernel.org, kernel list <linux-kernel@vger.kernel.org>,
davem@davemloft.net, gregkh@linuxfoundation.org
Subject: Re: net: atm: Spectre v1 fix introduced bug in bcb964012d1b in -stable
Date: Mon, 20 May 2019 09:15:50 -0500 [thread overview]
Message-ID: <02622e60-8ce9-8db3-8d16-fa1a32e063bf@embeddedor.com> (raw)
In-Reply-To: <20190520124014.GA5205@amd>
On 5/20/19 7:40 AM, Pavel Machek wrote:
>
> In lecd_attach, if arg is < 0, it was treated as 0. Spectre v1 fix
> changed that. Bug does not exist in mainline AFAICT.
>
NACK
array_index_nospec() macro returns zero if *arg* is out of bounds.
In any case, if the "bug" does not exist in mainline, what should be
done is to port the code that fixed it in mainline to old kernels,
not randomly add a "fix" here and there because that means we are
breaking backward compatibility.
--
Gustavo
> Signed-off-by: Pavel Machek <pavel@denx.de>
> # for 4.19.y
>
> diff --git a/net/atm/lec.c b/net/atm/lec.c
> index ad4f829193f0..ed279cd912f4 100644
> --- a/net/atm/lec.c
> +++ b/net/atm/lec.c
> @@ -731,7 +731,7 @@ static int lecd_attach(struct atm_vcc *vcc, int arg)
> i = arg;
> if (arg >= MAX_LEC_ITF)
> return -EINVAL;
> - i = array_index_nospec(arg, MAX_LEC_ITF);
> + i = array_index_nospec(i, MAX_LEC_ITF);
> if (!dev_lec[i]) {
> int size;
>
>
next prev parent reply other threads:[~2019-05-20 14:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 12:40 net: atm: Spectre v1 fix introduced bug in bcb964012d1b in -stable Pavel Machek
2019-05-20 14:00 ` Greg KH
2019-05-20 14:26 ` Gustavo A. R. Silva
2019-05-20 21:00 ` Pavel Machek
2019-05-20 16:15 ` Pavel Machek
2019-05-20 14:15 ` Gustavo A. R. Silva [this message]
2019-05-20 16:15 ` Pavel Machek
2019-05-20 16:54 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02622e60-8ce9-8db3-8d16-fa1a32e063bf@embeddedor.com \
--to=gustavo@embeddedor.com \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@denx.de \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).